Re: [PATCH v2 05/13] arm: mach-k3: invert logic for split DM firmware config
On February 2, 2024 thus sayeth Andrew Davis: > On 1/31/24 9:06 PM, Bryan Brattlof wrote: > > Currently, for the K3 generation of SoCs, there are more SoCs that > > utilize the split firmware approach than the combined DMSC firmware. > > Invert the logic to avoid adding more and more SoCs to this list. > > > > Signed-off-by: Bryan Brattlof > > --- > > arch/arm/mach-k3/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig > > index 03898424c9546..0574e81075e6d 100644 > > --- a/arch/arm/mach-k3/Kconfig > > +++ b/arch/arm/mach-k3/Kconfig > > @@ -130,7 +130,7 @@ config K3_ATF_LOAD_ADDR > > config K3_DM_FW > > bool "Separate DM firmware image" > > - depends on CPU_V7R && (SOC_K3_J721E || SOC_K3_J721S2 || SOC_K3_AM625 || > > SOC_K3_AM62A7) && !CLK_TI_SCI && !TI_SCI_POWER_DOMAIN > > + depends on CPU_V7R && ARCH_K3 && !SOC_K3_AM642 && !SOC_K3_AM654 && > > !CLK_TI_SCI && !TI_SCI_POWER_DOMAIN > > Always amusing to see how many SoCs get added to these lists before someone > realizes there is only one or two SoCs that are not on the list :) Haha having to resize my terminal is when I had enough :) > > BTW, this whole file is inside an "if ARCH_K3" block, so all symbols > depend on ARCH_K3 automatically. You can drop that check. > Nice catch! I'll drop that in v2 > Otherwise, > > Acked-by: Andrew Davis > > > default y > > help > > Enabling this will indicate that the system has separate DM
Re: [PATCH v2 05/13] arm: mach-k3: invert logic for split DM firmware config
On 1/31/24 9:06 PM, Bryan Brattlof wrote: Currently, for the K3 generation of SoCs, there are more SoCs that utilize the split firmware approach than the combined DMSC firmware. Invert the logic to avoid adding more and more SoCs to this list. Signed-off-by: Bryan Brattlof --- arch/arm/mach-k3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig index 03898424c9546..0574e81075e6d 100644 --- a/arch/arm/mach-k3/Kconfig +++ b/arch/arm/mach-k3/Kconfig @@ -130,7 +130,7 @@ config K3_ATF_LOAD_ADDR config K3_DM_FW bool "Separate DM firmware image" - depends on CPU_V7R && (SOC_K3_J721E || SOC_K3_J721S2 || SOC_K3_AM625 || SOC_K3_AM62A7) && !CLK_TI_SCI && !TI_SCI_POWER_DOMAIN + depends on CPU_V7R && ARCH_K3 && !SOC_K3_AM642 && !SOC_K3_AM654 && !CLK_TI_SCI && !TI_SCI_POWER_DOMAIN Always amusing to see how many SoCs get added to these lists before someone realizes there is only one or two SoCs that are not on the list :) BTW, this whole file is inside an "if ARCH_K3" block, so all symbols depend on ARCH_K3 automatically. You can drop that check. Otherwise, Acked-by: Andrew Davis default y help Enabling this will indicate that the system has separate DM
[PATCH v2 05/13] arm: mach-k3: invert logic for split DM firmware config
Currently, for the K3 generation of SoCs, there are more SoCs that utilize the split firmware approach than the combined DMSC firmware. Invert the logic to avoid adding more and more SoCs to this list. Signed-off-by: Bryan Brattlof --- arch/arm/mach-k3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig index 03898424c9546..0574e81075e6d 100644 --- a/arch/arm/mach-k3/Kconfig +++ b/arch/arm/mach-k3/Kconfig @@ -130,7 +130,7 @@ config K3_ATF_LOAD_ADDR config K3_DM_FW bool "Separate DM firmware image" - depends on CPU_V7R && (SOC_K3_J721E || SOC_K3_J721S2 || SOC_K3_AM625 || SOC_K3_AM62A7) && !CLK_TI_SCI && !TI_SCI_POWER_DOMAIN + depends on CPU_V7R && ARCH_K3 && !SOC_K3_AM642 && !SOC_K3_AM654 && !CLK_TI_SCI && !TI_SCI_POWER_DOMAIN default y help Enabling this will indicate that the system has separate DM -- 2.43.0
