Re: [PATCH v2 07/10] dts: dra7-ipu-common-early-boot.dtsi: Add all the ipu early boot related nodes

[Amjad Ouled-Ameur]

Hi Tom,

On 11/10/2021 20:59, Tom Rini wrote:

On Thu, Sep 30, 2021 at 06:21:08PM +0200, Amjad Ouled-Ameur wrote:


From: Keerthy 

Add all the ipu early boot related nodes

Signed-off-by: Keerthy 
Signed-off-by: Amjad Ouled-Ameur 
---

(no changes since v1)

  MAINTAINERS  |   1 +
  arch/arm/dts/dra7-ipu-common-early-boot.dtsi | 113 +++
  2 files changed, 114 insertions(+)
  create mode 100644 arch/arm/dts/dra7-ipu-common-early-boot.dtsi

This causes my J6 Eco board:
CPU  : DRA752-GP ES1.1
Model: TI DRA742
Board: DRA74x EVM REV G.0
to stop booting in SPL with no output.


Thank you for reporting the issue.

After debugging the j6eco board, I realized that board stops booting

in SPL when new nodes with "u-boot,dm-spl;"property are added to the

DTS. The issue seems to be unrelated to this patchset but rather to a

SPL's DTS limitation on j6eco. I am currently looking into SPL's linker 
file


and load addresses to understand better why SPL breaks.


Regards,

Amjad

Re: [PATCH v2 07/10] dts: dra7-ipu-common-early-boot.dtsi: Add all the ipu early boot related nodes

[Tom Rini]

On Thu, Sep 30, 2021 at 06:21:08PM +0200, Amjad Ouled-Ameur wrote:

> From: Keerthy 
> 
> Add all the ipu early boot related nodes
> 
> Signed-off-by: Keerthy 
> Signed-off-by: Amjad Ouled-Ameur 
> ---
> 
> (no changes since v1)
> 
>  MAINTAINERS  |   1 +
>  arch/arm/dts/dra7-ipu-common-early-boot.dtsi | 113 +++
>  2 files changed, 114 insertions(+)
>  create mode 100644 arch/arm/dts/dra7-ipu-common-early-boot.dtsi

This causes my J6 Eco board:
CPU  : DRA752-GP ES1.1
Model: TI DRA742
Board: DRA74x EVM REV G.0
to stop booting in SPL with no output.

-- 
Tom


signature.asc
Description: PGP signature

[PATCH v2 07/10] dts: dra7-ipu-common-early-boot.dtsi: Add all the ipu early boot related nodes

[Amjad Ouled-Ameur]

From: Keerthy 

Add all the ipu early boot related nodes

Signed-off-by: Keerthy 
Signed-off-by: Amjad Ouled-Ameur 
---

(no changes since v1)

 MAINTAINERS  |   1 +
 arch/arm/dts/dra7-ipu-common-early-boot.dtsi | 113 +++
 2 files changed, 114 insertions(+)
 create mode 100644 arch/arm/dts/dra7-ipu-common-early-boot.dtsi

diff --git a/MAINTAINERS b/MAINTAINERS
index f7ec528af73a..ffaf2015ca5f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -492,6 +492,7 @@ F:  arch/arm/mach-keystone/
 F: arch/arm/mach-omap2/
 F: arch/arm/include/asm/arch-omap*/
 F: arch/arm/include/asm/ti-common/
+F: arch/arm/dts/dra7*
 F: board/ti/
 F: drivers/dma/ti*
 F: drivers/firmware/ti_sci.*
diff --git a/arch/arm/dts/dra7-ipu-common-early-boot.dtsi 
b/arch/arm/dts/dra7-ipu-common-early-boot.dtsi
new file mode 100644
index ..ec6040ff93eb
--- /dev/null
+++ b/arch/arm/dts/dra7-ipu-common-early-boot.dtsi
@@ -0,0 +1,113 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Texas Instruments Incorporated - http://www.ti.com/
+ */
+
+/ {
+   chosen {
+   firmware-loader = _loader0;
+   };
+
+   fs_loader0: fs_loader@0 {
+   u-boot,dm-pre-reloc;
+   compatible = "u-boot,fs-loader";
+   phandlepart = < 1>;
+   };
+
+   reserved-memory {
+   #address-cells = <2>;
+   #size-cells = <2>;
+   ranges;
+   u-boot,dm-spl;
+
+   ipu2_memory_region: ipu2-memory@9580 {
+   compatible = "shared-dma-pool";
+   reg = <0x0 0x9580 0x0 0x380>;
+   reusable;
+   status = "okay";
+   u-boot,dm-spl;
+   };
+
+   ipu1_memory_region: ipu1-memory@9d00 {
+   compatible = "shared-dma-pool";
+   reg = <0x0 0x9d00 0x0 0x200>;
+   reusable;
+   status = "okay";
+   u-boot,dm-spl;
+   };
+
+   ipu1_pgtbl: ipu1-pgtbl@9570 {
+   reg = <0x0 0x9570 0x0 0x4>;
+   no-map;
+   u-boot,dm-spl;
+   };
+
+   ipu2_pgtbl: ipu2-pgtbl@9574 {
+   reg = <0x0 0x9574 0x0 0x4>;
+   no-map;
+   u-boot,dm-spl;
+   };
+   };
+};
+
+ {
+   u-boot,dm-spl;
+};
+
+ {
+   u-boot,dm-spl;
+};
+
+ {
+   u-boot,dm-spl;
+};
+
+ {
+   u-boot,dm-spl;
+};
+
+ {
+   u-boot,dm-spl;
+};
+
+ {
+   u-boot,dm-spl;
+};
+
+_ipu1 {
+   u-boot,dm-spl;
+};
+
+_ipu2 {
+   u-boot,dm-spl;
+};
+
+ {
+   status = "okay";
+   memory-region = <_memory_region>;
+   pg-tbl = <_pgtbl>;
+   u-boot,dm-spl;
+};
+
+ {
+   status = "okay";
+   memory-region = <_memory_region>;
+   pg-tbl = <_pgtbl>;
+   u-boot,dm-spl;
+};
+
+_wkup {
+   u-boot,dm-spl;
+};
+
+ {
+   u-boot,dm-spl;
+};
+
+_rst {
+   u-boot,dm-spl;
+};
+
+_rst {
+   u-boot,dm-spl;
+};
-- 
2.25.1