[PATCH v2 09/10] test: dm: rtc: add test of rtc_read, rtc_write

2020-05-19 Thread Rasmus Villemoes
Define a few aux registers and check that they can be read/written
individually. Also check that one can access the time-keeping
registers directly and get the expected results.

Signed-off-by: Rasmus Villemoes 
---
 arch/sandbox/include/asm/rtc.h |  5 
 test/dm/rtc.c  | 45 ++
 2 files changed, 50 insertions(+)

diff --git a/arch/sandbox/include/asm/rtc.h b/arch/sandbox/include/asm/rtc.h
index 1fbfea7999..5bb032f59f 100644
--- a/arch/sandbox/include/asm/rtc.h
+++ b/arch/sandbox/include/asm/rtc.h
@@ -21,6 +21,11 @@ enum {
 
REG_RESET   = 0x20,
 
+   REG_AUX0= 0x30,
+   REG_AUX1,
+   REG_AUX2,
+   REG_AUX3,
+
REG_COUNT   = 0x80,
 };
 
diff --git a/test/dm/rtc.c b/test/dm/rtc.c
index e5454139cd..5301805d19 100644
--- a/test/dm/rtc.c
+++ b/test/dm/rtc.c
@@ -9,6 +9,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -129,6 +130,50 @@ static int dm_test_rtc_set_get(struct unit_test_state *uts)
 }
 DM_TEST(dm_test_rtc_set_get, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
 
+static int dm_test_rtc_read_write(struct unit_test_state *uts)
+{
+   struct rtc_time time;
+   struct udevice *dev, *emul;
+   long old_offset;
+   u8 buf[4], reg;
+
+   ut_assertok(uclass_get_device(UCLASS_RTC, 0, &dev));
+
+   memcpy(buf, "car", 4);
+   ut_assertok(rtc_write(dev, REG_AUX0, buf, 4));
+   memset(buf, '\0', sizeof(buf));
+   ut_assertok(rtc_read(dev, REG_AUX0, buf, 4));
+   ut_asserteq(memcmp(buf, "car", 4), 0);
+
+   reg = 'b';
+   ut_assertok(rtc_write(dev, REG_AUX0, ®, 1));
+   memset(buf, '\0', sizeof(buf));
+   ut_assertok(rtc_read(dev, REG_AUX0, buf, 4));
+   ut_asserteq(memcmp(buf, "bar", 4), 0);
+
+   reg = 't';
+   ut_assertok(rtc_write(dev, REG_AUX2, ®, 1));
+   memset(buf, '\0', sizeof(buf));
+   ut_assertok(rtc_read(dev, REG_AUX1, buf, 3));
+   ut_asserteq(memcmp(buf, "at", 3), 0);
+
+   ut_assertok(i2c_emul_find(dev, &emul));
+   ut_assert(emul != NULL);
+
+   old_offset = sandbox_i2c_rtc_set_offset(emul, false, 0);
+   ut_assertok(dm_rtc_get(dev, &time));
+
+   ut_assertok(rtc_read(dev, REG_SEC, ®, 1));
+   ut_asserteq(time.tm_sec, reg);
+   ut_assertok(rtc_read(dev, REG_MDAY, ®, 1));
+   ut_asserteq(time.tm_mday, reg);
+
+   sandbox_i2c_rtc_set_offset(emul, true, old_offset);
+
+   return 0;
+}
+DM_TEST(dm_test_rtc_read_write, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+
 /* Reset the time */
 static int dm_test_rtc_reset(struct unit_test_state *uts)
 {
-- 
2.23.0



Re: [PATCH v2 09/10] test: dm: rtc: add test of rtc_read, rtc_write

2020-05-31 Thread Simon Glass
On Tue, 19 May 2020 at 16:01, Rasmus Villemoes
 wrote:
>
> Define a few aux registers and check that they can be read/written
> individually. Also check that one can access the time-keeping
> registers directly and get the expected results.
>
> Signed-off-by: Rasmus Villemoes 
> ---
>  arch/sandbox/include/asm/rtc.h |  5 
>  test/dm/rtc.c  | 45 ++
>  2 files changed, 50 insertions(+)

Reviewed-by: Simon Glass