Re: [PATCH v2 14/23] rockchip: rk3588-coolpi: Add boards to documentation

2024-04-15 Thread Jonas Karlman 
Hi Quentin and Dragan,

On 2024-04-15 10:58, Dragan Simic wrote:
> Hello Quentin,
> 
> On 2024-04-15 10:56, Quentin Schulz wrote:
>> Hi Jonas,
>>
>> On 4/13/24 20:13, Jonas Karlman wrote:
>>> Add the CoolPi 4 Model B and CoolPi CM5 EVB board to the 
>>> documentation.
>>> Also fix .dtb-file entries in Makefile.
>>>
>>
>> When one needs to use a list or say "also", "moreover", etc... it
>> usually is a tell the commit should be split.
>>
>> Here the changes are not related, so please have two separate patches.
> 
> Agreed.

I will split this patch for v3.

Regards,
Jonas

> 
>> The sum of changes is fine though, thanks.

Re: [PATCH v2 14/23] rockchip: rk3588-coolpi: Add boards to documentation

2024-04-15 Thread Dragan Simic 

Hello Quentin,

On 2024-04-15 10:56, Quentin Schulz wrote:

Hi Jonas,

On 4/13/24 20:13, Jonas Karlman wrote:
Add the CoolPi 4 Model B and CoolPi CM5 EVB board to the 
documentation.

Also fix .dtb-file entries in Makefile.



When one needs to use a list or say "also", "moreover", etc... it
usually is a tell the commit should be split.

Here the changes are not related, so please have two separate patches.


Agreed.


The sum of changes is fine though, thanks.

Re: [PATCH v2 14/23] rockchip: rk3588-coolpi: Add boards to documentation

2024-04-15 Thread Quentin Schulz 

Hi Jonas,

On 4/13/24 20:13, Jonas Karlman wrote:

Add the CoolPi 4 Model B and CoolPi CM5 EVB board to the documentation.
Also fix .dtb-file entries in Makefile.



When one needs to use a list or say "also", "moreover", etc... it 
usually is a tell the commit should be split.


Here the changes are not related, so please have two separate patches.

The sum of changes is fine though, thanks.

Cheers,
Quentin

Re: [PATCH v2 14/23] rockchip: rk3588-coolpi: Add boards to documentation

2024-04-15 Thread Dragan Simic 

On 2024-04-13 20:13, Jonas Karlman wrote:

Add the CoolPi 4 Model B and CoolPi CM5 EVB board to the documentation.
Also fix .dtb-file entries in Makefile.


Perhaps the patch subject could be improved a bit to also mention
fixing of the Makefile, but only if there will be v3.


Fixes: 3e15dee38d45 ("board: rockchip: Add support for rk3588 based
Cool Pi CM5 EVB")
Signed-off-by: Jonas Karlman 


Looking good to me.

Reviewed-by: Dragan Simic 


---
v2: No change
---
 arch/arm/dts/Makefile   | 4 ++--
 doc/board/rockchip/rockchip.rst | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 08dfbdd557b7..38d259a7035c 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -167,8 +167,8 @@ dtb-$(CONFIG_ROCKCHIP_RK3568) += \
rk3568-rock-3a.dtb

 dtb-$(CONFIG_ROCKCHIP_RK3588) += \
-   rk3588s-coolpi-4b.dts \
-   rk3588-coolpi-cm5-evb.dts \
+   rk3588s-coolpi-4b.dtb \
+   rk3588-coolpi-cm5-evb.dtb \
rk3588-edgeble-neu6a-io.dtb \
rk3588-edgeble-neu6b-io.dtb \
rk3588-evb1-v10.dtb \
diff --git a/doc/board/rockchip/rockchip.rst 
b/doc/board/rockchip/rockchip.rst

index 5dd5ea7f1e29..9a726e9cde63 100644
--- a/doc/board/rockchip/rockchip.rst
+++ b/doc/board/rockchip/rockchip.rst
@@ -131,6 +131,8 @@ List of mainline supported Rockchip boards:
  - Turing Machines RK1 (turing-rk1-rk3588)
  - Xunlong Orange Pi 5 (orangepi-5-rk3588s)
  - Xunlong Orange Pi 5 Plus (orangepi-5-plus-rk3588)
+ - Yanyi Tech CoolPi 4 Model B (coolpi-4b-rk3588s)
+ - Yanyi Tech CoolPi CM5 EVB (coolpi-cm5-evb-rk3588)

 * rv1108
  - Rockchip Evb-rv1108 (evb-rv1108)

[PATCH v2 14/23] rockchip: rk3588-coolpi: Add boards to documentation

2024-04-13 Thread Jonas Karlman 
Add the CoolPi 4 Model B and CoolPi CM5 EVB board to the documentation.
Also fix .dtb-file entries in Makefile.

Fixes: 3e15dee38d45 ("board: rockchip: Add support for rk3588 based Cool Pi CM5 
EVB")
Signed-off-by: Jonas Karlman 
---
v2: No change
---
 arch/arm/dts/Makefile   | 4 ++--
 doc/board/rockchip/rockchip.rst | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 08dfbdd557b7..38d259a7035c 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -167,8 +167,8 @@ dtb-$(CONFIG_ROCKCHIP_RK3568) += \
rk3568-rock-3a.dtb
 
 dtb-$(CONFIG_ROCKCHIP_RK3588) += \
-   rk3588s-coolpi-4b.dts \
-   rk3588-coolpi-cm5-evb.dts \
+   rk3588s-coolpi-4b.dtb \
+   rk3588-coolpi-cm5-evb.dtb \
rk3588-edgeble-neu6a-io.dtb \
rk3588-edgeble-neu6b-io.dtb \
rk3588-evb1-v10.dtb \
diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
index 5dd5ea7f1e29..9a726e9cde63 100644
--- a/doc/board/rockchip/rockchip.rst
+++ b/doc/board/rockchip/rockchip.rst
@@ -131,6 +131,8 @@ List of mainline supported Rockchip boards:
  - Turing Machines RK1 (turing-rk1-rk3588)
  - Xunlong Orange Pi 5 (orangepi-5-rk3588s)
  - Xunlong Orange Pi 5 Plus (orangepi-5-plus-rk3588)
+ - Yanyi Tech CoolPi 4 Model B (coolpi-4b-rk3588s)
+ - Yanyi Tech CoolPi CM5 EVB (coolpi-cm5-evb-rk3588)
 
 * rv1108
  - Rockchip Evb-rv1108 (evb-rv1108)
-- 
2.43.2