Re: [PATCH v2 14/28] fs/squashfs: sqfs_read: remove useless sqfs_closedir()

[Tom Rini]

On Tue, Nov 03, 2020 at 12:11:12PM +0100, Richard Genoud wrote:

> as sqfs_opendir failed, there's no need to call sqfs_closedir
> 
> Signed-off-by: Richard Genoud 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature

[PATCH v2 14/28] fs/squashfs: sqfs_read: remove useless sqfs_closedir()

[Richard Genoud]

as sqfs_opendir failed, there's no need to call sqfs_closedir

Signed-off-by: Richard Genoud 
---
 fs/squashfs/sqfs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c
index 13e64bea934..1ac07625889 100644
--- a/fs/squashfs/sqfs.c
+++ b/fs/squashfs/sqfs.c
@@ -1323,7 +1323,6 @@ int sqfs_read(const char *filename, void *buf, loff_t 
offset, loff_t len,
sqfs_split_path(&file, &dir, filename);
ret = sqfs_opendir(dir, &dirsp);
if (ret) {
-   sqfs_closedir(dirsp);
goto free_paths;
}