Re: [PATCH v2 2/5] usb: dwc3: meson-gxl: switch to generic_phy_set_mode

2024-06-20 Thread Marek Vasut 

On 6/20/24 9:42 AM, Neil Armstrong wrote:

Use the PHY set_mode call instead of calling directly in the
PHY shared function.

Signed-off-by: Neil Armstrong 


Reviewed-by: Marek Vasut

[PATCH v2 2/5] usb: dwc3: meson-gxl: switch to generic_phy_set_mode

2024-06-20 Thread Neil Armstrong 
Use the PHY set_mode call instead of calling directly in the
PHY shared function.

Signed-off-by: Neil Armstrong 
---
 drivers/usb/dwc3/dwc3-meson-gxl.c | 15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-meson-gxl.c 
b/drivers/usb/dwc3/dwc3-meson-gxl.c
index 3e693c5ff3..290ac03a37 100644
--- a/drivers/usb/dwc3/dwc3-meson-gxl.c
+++ b/drivers/usb/dwc3/dwc3-meson-gxl.c
@@ -158,9 +158,9 @@ static int dwc3_meson_gxl_usb2_init(struct dwc3_meson_gxl 
*priv)
if (!priv->phys[i].dev)
continue;
 
-   phy_meson_gxl_usb2_set_mode(>phys[i],
-   (i == USB2_OTG_PHY) ? USB_DR_MODE_PERIPHERAL
-   : USB_DR_MODE_HOST);
+   generic_phy_set_mode(>phys[i],
+   (i == USB2_OTG_PHY) ? PHY_MODE_USB_DEVICE
+   : PHY_MODE_USB_HOST, 0);
}
 
return 0;
@@ -224,7 +224,9 @@ int dwc3_meson_gxl_force_mode(struct udevice *dev, enum 
usb_dr_mode mode)
 #endif
priv->otg_phy_mode = mode;
 
-   phy_meson_gxl_usb2_set_mode(>phys[USB2_OTG_PHY], mode);
+   generic_phy_set_mode(>phys[USB2_OTG_PHY],
+mode == USB_DR_MODE_PERIPHERAL ? 
PHY_MODE_USB_DEVICE
+   : 
PHY_MODE_USB_HOST, 0);
 
dwc3_meson_gxl_usb2_set_mode(priv, mode);
 
@@ -361,8 +363,9 @@ static int dwc3_meson_gxl_probe(struct udevice *dev)
}
 
if (priv->phys[USB2_OTG_PHY].dev)
-   phy_meson_gxl_usb2_set_mode(>phys[USB2_OTG_PHY],
-   priv->otg_phy_mode);
+   generic_phy_set_mode(>phys[USB2_OTG_PHY],
+   priv->otg_phy_mode == USB_DR_MODE_PERIPHERAL ? 
PHY_MODE_USB_DEVICE
+: 
PHY_MODE_USB_HOST, 0);
 
dwc3_meson_gxl_usb2_set_mode(priv, priv->otg_phy_mode);
 

-- 
2.34.1