Re: [PATCH v2 20/26] wandboard: use CONFIG_IS_ENABLED(SATA) instead of ifdef CONFIG_SATA

2023-02-26 Thread Simon Glass
On Fri, 24 Feb 2023 at 11:11, Troy Kisky  wrote:
>
> Prepare for linking setup_sata only when CONFIG_SATA/CONFIG_SPL_SATA
> is defined.
>
> Signed-off-by: Troy Kisky 
> ---
>
> Changes in v2:
> - new in series
>
>  board/wandboard/wandboard.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass 


[PATCH v2 20/26] wandboard: use CONFIG_IS_ENABLED(SATA) instead of ifdef CONFIG_SATA

2023-02-24 Thread Troy Kisky
Prepare for linking setup_sata only when CONFIG_SATA/CONFIG_SPL_SATA
is defined.

Signed-off-by: Troy Kisky 
---

Changes in v2:
- new in series

 board/wandboard/wandboard.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index da995dd0f58..48914450a29 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -352,9 +352,8 @@ static void setup_display(void)
 int board_early_init_f(void)
 {
setup_iomux_uart();
-#ifdef CONFIG_SATA
-   setup_sata();
-#endif
+   if (CONFIG_IS_ENABLED(SATA))
+   setup_sata();
 
return 0;
 }
-- 
2.34.1