[PATCH v2 27/35] x86: acpi: Move MADT down a bit

2020-05-10 Thread Simon Glass
Put this table before MCFG so that it matches the order that coreboot uses
when passing tables to Linux. This is a cosmetic change since the order of
the tables does not otherwise matter.

Signed-off-by: Simon Glass 
---

Changes in v2: None
Changes in v1:
- Correct the commit subject

 arch/x86/lib/acpi_table.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c
index 6985ef4ba5..e96acf08d4 100644
--- a/arch/x86/lib/acpi_table.c
+++ b/arch/x86/lib/acpi_table.c
@@ -418,18 +418,18 @@ ulong write_acpi_tables(ulong start_addr)
acpi_create_fadt(fadt, facs, dsdt);
acpi_add_table(ctx, fadt);
 
-   debug("ACPI:* MADT\n");
-   madt = ctx->current;
-   acpi_create_madt(madt);
-   acpi_inc_align(ctx, madt->header.length);
-   acpi_add_table(ctx, madt);
-
debug("ACPI:* MCFG\n");
mcfg = ctx->current;
acpi_create_mcfg(mcfg);
acpi_inc_align(ctx, mcfg->header.length);
acpi_add_table(ctx, mcfg);
 
+   debug("ACPI:* MADT\n");
+   madt = ctx->current;
+   acpi_create_madt(madt);
+   acpi_inc_align(ctx, madt->header.length);
+   acpi_add_table(ctx, madt);
+
debug("ACPI:* CSRT\n");
csrt = ctx->current;
acpi_create_csrt(csrt);
-- 
2.26.2.645.ge9eca65c58-goog



Re: [PATCH v2 27/35] x86: acpi: Move MADT down a bit

2020-06-04 Thread Wolfgang Wallner
Hi Simon,

-"Simon Glass"  schrieb: -
> Betreff: [PATCH v2 27/35] x86: acpi: Move MADT down a bit
> 
> Put this table before MCFG so that it matches the order that coreboot uses
> when passing tables to Linux. This is a cosmetic change since the order of
> the tables does not otherwise matter.
> 
> Signed-off-by: Simon Glass 
> ---
> 
> Changes in v2: None
> Changes in v1:
> - Correct the commit subject
> 
>  arch/x86/lib/acpi_table.c | 12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c
> index 6985ef4ba5..e96acf08d4 100644
> --- a/arch/x86/lib/acpi_table.c
> +++ b/arch/x86/lib/acpi_table.c
> @@ -418,18 +418,18 @@ ulong write_acpi_tables(ulong start_addr)
>   acpi_create_fadt(fadt, facs, dsdt);
>   acpi_add_table(ctx, fadt);
>  
> - debug("ACPI:* MADT\n");
> - madt = ctx->current;
> - acpi_create_madt(madt);
> - acpi_inc_align(ctx, madt->header.length);
> - acpi_add_table(ctx, madt);
> -
>   debug("ACPI:* MCFG\n");
>   mcfg = ctx->current;
>   acpi_create_mcfg(mcfg);
>   acpi_inc_align(ctx, mcfg->header.length);
>   acpi_add_table(ctx, mcfg);
>  
> + debug("ACPI:* MADT\n");
> + madt = ctx->current;
> + acpi_create_madt(madt);
> + acpi_inc_align(ctx, madt->header.length);
> + acpi_add_table(ctx, madt);
> +
>   debug("ACPI:* CSRT\n");
>   csrt = ctx->current;
>   acpi_create_csrt(csrt);
> -- 
> 2.26.2.645.ge9eca65c58-goog

Reviewed-by: Wolfgang Wallner