Re: [PATCH v2 3/3] rk3566: radxa-cm3: Enable USB OTG

2023-04-14 Thread Kever Yang



On 2023/2/26 21:22, Manoj Sai wrote:

Enable USB OTG support and update the fastboot buffer address
for Radxa Compute Module 3 IO Board.

This would help to use fastboot by default.

Signed-off-by: Manoj Sai 
---
Changes for v2 :-
- Updated the fastboot buffer address in drivers/fastboot/Kconfig.
---
  configs/radxa-cm3-io-rk3566_defconfig | 2 ++
  drivers/fastboot/Kconfig  | 1 +
  2 files changed, 3 insertions(+)

diff --git a/configs/radxa-cm3-io-rk3566_defconfig 
b/configs/radxa-cm3-io-rk3566_defconfig
index 2100cf2cb2..aba3a65e7f 100644
--- a/configs/radxa-cm3-io-rk3566_defconfig
+++ b/configs/radxa-cm3-io-rk3566_defconfig
@@ -21,6 +21,7 @@ CONFIG_DEBUG_UART_BASE=0xFE66
  CONFIG_DEBUG_UART_CLOCK=2400
  CONFIG_SYS_LOAD_ADDR=0xc00800
  CONFIG_DEBUG_UART=y
+# CONFIG_ANDROID_BOOT_IMAGE is not set
  CONFIG_FIT=y
  CONFIG_FIT_VERBOSE=y
  CONFIG_SPL_LOAD_FIT=y
@@ -74,4 +75,5 @@ CONFIG_USB_EHCI_HCD=y
  CONFIG_USB_EHCI_GENERIC=y
  CONFIG_USB_DWC3=y
  CONFIG_USB_DWC3_GENERIC=y
+CONFIG_USB_GADGET=y
  CONFIG_ERRNO_STR=y
diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig
index eefa34779c..53f0b3a659 100644
--- a/drivers/fastboot/Kconfig
+++ b/drivers/fastboot/Kconfig
@@ -41,6 +41,7 @@ config FASTBOOT_BUF_ADDR
default 0x800800 if ROCKCHIP_RK3288 || ROCKCHIP_RK3329 || \
ROCKCHIP_RK3399
default 0x28 if ROCKCHIP_RK3368
+   default 0xc00800 if ROCKCHIP_RK3568


Why you need a new address for rk3568?

Thanks,

- Kever


default 0x10 if ARCH_ZYNQMP
default 0 if SANDBOX
help


[PATCH v2 3/3] rk3566: radxa-cm3: Enable USB OTG

2023-02-26 Thread Manoj Sai
Enable USB OTG support and update the fastboot buffer address
for Radxa Compute Module 3 IO Board.

This would help to use fastboot by default.

Signed-off-by: Manoj Sai 
---
Changes for v2 :-
- Updated the fastboot buffer address in drivers/fastboot/Kconfig.
---
 configs/radxa-cm3-io-rk3566_defconfig | 2 ++
 drivers/fastboot/Kconfig  | 1 +
 2 files changed, 3 insertions(+)

diff --git a/configs/radxa-cm3-io-rk3566_defconfig 
b/configs/radxa-cm3-io-rk3566_defconfig
index 2100cf2cb2..aba3a65e7f 100644
--- a/configs/radxa-cm3-io-rk3566_defconfig
+++ b/configs/radxa-cm3-io-rk3566_defconfig
@@ -21,6 +21,7 @@ CONFIG_DEBUG_UART_BASE=0xFE66
 CONFIG_DEBUG_UART_CLOCK=2400
 CONFIG_SYS_LOAD_ADDR=0xc00800
 CONFIG_DEBUG_UART=y
+# CONFIG_ANDROID_BOOT_IMAGE is not set
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_SPL_LOAD_FIT=y
@@ -74,4 +75,5 @@ CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
+CONFIG_USB_GADGET=y
 CONFIG_ERRNO_STR=y
diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig
index eefa34779c..53f0b3a659 100644
--- a/drivers/fastboot/Kconfig
+++ b/drivers/fastboot/Kconfig
@@ -41,6 +41,7 @@ config FASTBOOT_BUF_ADDR
default 0x800800 if ROCKCHIP_RK3288 || ROCKCHIP_RK3329 || \
ROCKCHIP_RK3399
default 0x28 if ROCKCHIP_RK3368
+   default 0xc00800 if ROCKCHIP_RK3568
default 0x10 if ARCH_ZYNQMP
default 0 if SANDBOX
help
-- 
2.25.1