Re: [PATCH v3] net: zynq: Add support for PHY configuration in SGMII mode

2022-01-05 Thread Michal Simek 
st 15. 12. 2021 v 11:00 odesílatel Michal Simek
 napsal:
>
> SGMII configuration depends on proper GT setting that's why when node has
> phys property call PSGTR driver to configure it properly.
>
> Signed-off-by: Michal Simek 
> ---
>
> Changes in v3:
> - Separate phy init from phy power on (IP reset has to be between)
>
> Changes in v2:
> - Handle also cases where phy reference doesn't exist which means
>   that u-boot doesn't need to configure it (configured via psu_init for
>   example)
> - Error out where reference exists but driver is not compiled in - reported
>   by Sean
>
>  drivers/net/zynq_gem.c | 20 
>  1 file changed, 20 insertions(+)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index 5cbe8d28304b..b751d28e611f 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -12,6 +12,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -715,6 +716,19 @@ static int zynq_gem_probe(struct udevice *dev)
> void *bd_space;
> struct zynq_gem_priv *priv = dev_get_priv(dev);
> int ret;
> +   struct phy phy;
> +
> +   if (priv->interface == PHY_INTERFACE_MODE_SGMII) {
> +   ret = generic_phy_get_by_index(dev, 0, &phy);
> +   if (!ret) {
> +   ret = generic_phy_init(&phy);
> +   if (ret)
> +   return ret;
> +   } else if (ret != -ENOENT) {
> +   debug("could not get phy (err %d)\n", ret);
> +   return ret;
> +   }
> +   }
>
> ret = zynq_gem_reset_init(dev);
> if (ret)
> @@ -771,6 +785,12 @@ static int zynq_gem_probe(struct udevice *dev)
> if (ret)
> goto err3;
>
> +   if (priv->interface == PHY_INTERFACE_MODE_SGMII && phy.dev) {
> +   ret = generic_phy_power_on(&phy);
> +   if (ret)
> +   return ret;
> +   }
> +
> return ret;
>
>  err3:
> --
> 2.34.1
>

Applied.
M

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs

Re: [PATCH v3] net: zynq: Add support for PHY configuration in SGMII mode

2021-12-28 Thread Sean Anderson 




On 12/15/21 5:00 AM, Michal Simek wrote:

SGMII configuration depends on proper GT setting that's why when node has
phys property call PSGTR driver to configure it properly.

Signed-off-by: Michal Simek 
---

Changes in v3:
- Separate phy init from phy power on (IP reset has to be between)

Changes in v2:
- Handle also cases where phy reference doesn't exist which means
   that u-boot doesn't need to configure it (configured via psu_init for
   example)
- Error out where reference exists but driver is not compiled in - reported
   by Sean

  drivers/net/zynq_gem.c | 20 
  1 file changed, 20 insertions(+)

diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index 5cbe8d28304b..b751d28e611f 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -12,6 +12,7 @@
  #include 
  #include 
  #include 
+#include 
  #include 
  #include 
  #include 
@@ -715,6 +716,19 @@ static int zynq_gem_probe(struct udevice *dev)
void *bd_space;
struct zynq_gem_priv *priv = dev_get_priv(dev);
int ret;
+   struct phy phy;
+
+   if (priv->interface == PHY_INTERFACE_MODE_SGMII) {
+   ret = generic_phy_get_by_index(dev, 0, &phy);
+   if (!ret) {
+   ret = generic_phy_init(&phy);
+   if (ret)
+   return ret;
+   } else if (ret != -ENOENT) {
+   debug("could not get phy (err %d)\n", ret);
+   return ret;
+   }
+   }
  
  	ret = zynq_gem_reset_init(dev);

if (ret)
@@ -771,6 +785,12 @@ static int zynq_gem_probe(struct udevice *dev)
if (ret)
goto err3;
  
+	if (priv->interface == PHY_INTERFACE_MODE_SGMII && phy.dev) {

+   ret = generic_phy_power_on(&phy);
+   if (ret)
+   return ret;
+   }
+
return ret;
  
  err3:




Reviewed-by: Sean Anderson

[PATCH v3] net: zynq: Add support for PHY configuration in SGMII mode

2021-12-15 Thread Michal Simek 
SGMII configuration depends on proper GT setting that's why when node has
phys property call PSGTR driver to configure it properly.

Signed-off-by: Michal Simek 
---

Changes in v3:
- Separate phy init from phy power on (IP reset has to be between)

Changes in v2:
- Handle also cases where phy reference doesn't exist which means
  that u-boot doesn't need to configure it (configured via psu_init for
  example)
- Error out where reference exists but driver is not compiled in - reported
  by Sean

 drivers/net/zynq_gem.c | 20 
 1 file changed, 20 insertions(+)

diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index 5cbe8d28304b..b751d28e611f 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -12,6 +12,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -715,6 +716,19 @@ static int zynq_gem_probe(struct udevice *dev)
void *bd_space;
struct zynq_gem_priv *priv = dev_get_priv(dev);
int ret;
+   struct phy phy;
+
+   if (priv->interface == PHY_INTERFACE_MODE_SGMII) {
+   ret = generic_phy_get_by_index(dev, 0, &phy);
+   if (!ret) {
+   ret = generic_phy_init(&phy);
+   if (ret)
+   return ret;
+   } else if (ret != -ENOENT) {
+   debug("could not get phy (err %d)\n", ret);
+   return ret;
+   }
+   }
 
ret = zynq_gem_reset_init(dev);
if (ret)
@@ -771,6 +785,12 @@ static int zynq_gem_probe(struct udevice *dev)
if (ret)
goto err3;
 
+   if (priv->interface == PHY_INTERFACE_MODE_SGMII && phy.dev) {
+   ret = generic_phy_power_on(&phy);
+   if (ret)
+   return ret;
+   }
+
return ret;
 
 err3:
-- 
2.34.1