Re: [PATCH v3 2/8] IPQ40xx: clk: Use dt-bindings instead of hardcoding

[Tom Rini]

On Thu, Sep 10, 2020 at 04:00:00PM +0200, Robert Marko wrote:

> Its common to use dt-bindings instead of hard-coding clocks or resets.
> So lets use the imported Linux GCC bindings on IPQ40xx target.
> 
> Signed-off-by: Robert Marko 
> Cc: Luka Perkov 

Applied to u-boot/next, thanks!

-- 
Tom


signature.asc
Description: PGP signature

[PATCH v3 2/8] IPQ40xx: clk: Use dt-bindings instead of hardcoding

[Robert Marko]

Its common to use dt-bindings instead of hard-coding clocks or resets.
So lets use the imported Linux GCC bindings on IPQ40xx target.

Signed-off-by: Robert Marko 
Cc: Luka Perkov 
---
 arch/arm/dts/qcom-ipq4019.dtsi| 3 ++-
 arch/arm/mach-ipq40xx/clock-ipq4019.c | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/qcom-ipq4019.dtsi b/arch/arm/dts/qcom-ipq4019.dtsi
index 5f78bc5ab9..7b3b5e0248 100644
--- a/arch/arm/dts/qcom-ipq4019.dtsi
+++ b/arch/arm/dts/qcom-ipq4019.dtsi
@@ -10,6 +10,7 @@
 #include "skeleton.dtsi"
 #include 
 #include 
+#include 
 
 / {
#address-cells = <1>;
@@ -61,7 +62,7 @@
blsp1_uart1: serial@78af000 {
compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
reg = <0x78af000 0x200>;
-   clock = < 26>;
+   clock = < GCC_BLSP1_UART1_APPS_CLK>;
bit-rate = <0xFF>;
status = "disabled";
u-boot,dm-pre-reloc;
diff --git a/arch/arm/mach-ipq40xx/clock-ipq4019.c 
b/arch/arm/mach-ipq40xx/clock-ipq4019.c
index 7cf98a203c..83a688e625 100644
--- a/arch/arm/mach-ipq40xx/clock-ipq4019.c
+++ b/arch/arm/mach-ipq40xx/clock-ipq4019.c
@@ -13,6 +13,8 @@
 #include 
 #include 
 
+#include 
+
 struct msm_clk_priv {
phys_addr_t base;
 };
@@ -20,7 +22,7 @@ struct msm_clk_priv {
 ulong msm_set_rate(struct clk *clk, ulong rate)
 {
switch (clk->id) {
-   case 26: /*UART1*/
+   case GCC_BLSP1_UART1_APPS_CLK: /*UART1*/
/* This clock is already initialized by SBL1 */
return 0; 
break;
-- 
2.26.2