Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-12-16 Thread Simon Glass
Hi Shantur,

On Thu, 14 Dec 2023 at 07:14, Shantur Rathore  wrote:
>
> Hi,
>
> On Wed, Dec 13, 2023 at 8:41 PM Simon Glass  wrote:
> >
> > Hi Tom,
> >
> > On Wed, 13 Dec 2023 at 13:29, Tom Rini  wrote:
> > >
> > > On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
> > > > Hi Tom,
> > > >
> > > > On Mon, 11 Dec 2023 at 13:53, Tom Rini  wrote:
> > > > >
> > > > > On Mon, Dec 11, 2023 at 08:42:19PM +, Shantur Rathore wrote:
> > > > > > Hi,
> > > > > >
> > > > > > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore  
> > > > > > wrote:
> > > > > > >
> > > > > > > Add smbios information for Pine64 RockPro64 board and enable in
> > > > > > > config
> > > > > > >
> > > > > > > Signed-off-by: Shantur Rathore 
> > > > > > > ---
> > > > > > >  Changes
> > > > > > >  v4: Change PINE64 to Pine64
> > > > > > >  v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> > > > > > >
> > > > > > >  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 
> > > > > > > ++
> > > > > > >  configs/rockpro64-rk3399_defconfig|  2 ++
> > > > > > >  2 files changed, 24 insertions(+)
> > > > > > >
> > > > > > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi 
> > > > > > > b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > > index 732727d9b0..089732524a 100644
> > > > > > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > > @@ -9,6 +9,28 @@
> > > > > > > chosen {
> > > > > > > u-boot,spl-boot-order = "same-as-spl", 
> > > > > > > _flash, , 
> > > > > > > };
> > > > > > > +
> > > > > > > +smbios {
> > > > > > > +compatible = "u-boot,sysinfo-smbios";
> > > > > > > +smbios {
> > > > > > > +system {
> > > > > > > +manufacturer = "Pine64";
> > > > > > > +product = "RockPro64";
> > > > > > > +};
> > > [snip]
> > > > > Yes, we should just defer this and pickup the SMBIOS series that Ilias
> > > > > has posted.
> > > >
> > > > I don't think it is a suitable substitute, it is just a fallback.
> > > >
> > > > So I believe this patch should be applied.
> > >
> > > Please note that this patch is adding _less_ details than the top-level
> > > model field contains today for the platform.  The only difference is
> > > "Pine64" vs "pine64".
> >
> > The top-level model is "Pine64 RockPro64 v2.1", I believe. But:
> >
> > - the first part of that is the manufacturer, not the product
> > - the second part is what we have in this patch
> > - the third part is the version
> >
> > SMBIOS tries to split things up into separate fields.
> >
> > So, perhaps a new version of this patch could add:
> >
> >system {
> >  version = "2.1";
> >};
> >
>
> I can add the above or any more details needed to a new patch
> Will that be enough to make it merge-able

>From my POV, yes. Having dug into this a bit, patches like this are
the only way we can get authoritative SMBIOS data. There are various
user-space workarounds, but these should not cause any problems.

Regards,
Simon


Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-12-14 Thread Shantur Rathore
Hi,

On Wed, Dec 13, 2023 at 8:41 PM Simon Glass  wrote:
>
> Hi Tom,
>
> On Wed, 13 Dec 2023 at 13:29, Tom Rini  wrote:
> >
> > On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Mon, 11 Dec 2023 at 13:53, Tom Rini  wrote:
> > > >
> > > > On Mon, Dec 11, 2023 at 08:42:19PM +, Shantur Rathore wrote:
> > > > > Hi,
> > > > >
> > > > > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore  
> > > > > wrote:
> > > > > >
> > > > > > Add smbios information for Pine64 RockPro64 board and enable in
> > > > > > config
> > > > > >
> > > > > > Signed-off-by: Shantur Rathore 
> > > > > > ---
> > > > > >  Changes
> > > > > >  v4: Change PINE64 to Pine64
> > > > > >  v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> > > > > >
> > > > > >  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 
> > > > > > ++
> > > > > >  configs/rockpro64-rk3399_defconfig|  2 ++
> > > > > >  2 files changed, 24 insertions(+)
> > > > > >
> > > > > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi 
> > > > > > b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > index 732727d9b0..089732524a 100644
> > > > > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > @@ -9,6 +9,28 @@
> > > > > > chosen {
> > > > > > u-boot,spl-boot-order = "same-as-spl", _flash, 
> > > > > > , 
> > > > > > };
> > > > > > +
> > > > > > +smbios {
> > > > > > +compatible = "u-boot,sysinfo-smbios";
> > > > > > +smbios {
> > > > > > +system {
> > > > > > +manufacturer = "Pine64";
> > > > > > +product = "RockPro64";
> > > > > > +};
> > [snip]
> > > > Yes, we should just defer this and pickup the SMBIOS series that Ilias
> > > > has posted.
> > >
> > > I don't think it is a suitable substitute, it is just a fallback.
> > >
> > > So I believe this patch should be applied.
> >
> > Please note that this patch is adding _less_ details than the top-level
> > model field contains today for the platform.  The only difference is
> > "Pine64" vs "pine64".
>
> The top-level model is "Pine64 RockPro64 v2.1", I believe. But:
>
> - the first part of that is the manufacturer, not the product
> - the second part is what we have in this patch
> - the third part is the version
>
> SMBIOS tries to split things up into separate fields.
>
> So, perhaps a new version of this patch could add:
>
>system {
>  version = "2.1";
>};
>

I can add the above or any more details needed to a new patch
Will that be enough to make it merge-able

Kind regards,
Shantur


Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-12-13 Thread Simon Glass
Hi Tom,

On Wed, 13 Dec 2023 at 13:29, Tom Rini  wrote:
>
> On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
> > Hi Tom,
> >
> > On Mon, 11 Dec 2023 at 13:53, Tom Rini  wrote:
> > >
> > > On Mon, Dec 11, 2023 at 08:42:19PM +, Shantur Rathore wrote:
> > > > Hi,
> > > >
> > > > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore  
> > > > wrote:
> > > > >
> > > > > Add smbios information for Pine64 RockPro64 board and enable in
> > > > > config
> > > > >
> > > > > Signed-off-by: Shantur Rathore 
> > > > > ---
> > > > >  Changes
> > > > >  v4: Change PINE64 to Pine64
> > > > >  v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> > > > >
> > > > >  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++
> > > > >  configs/rockpro64-rk3399_defconfig|  2 ++
> > > > >  2 files changed, 24 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi 
> > > > > b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > index 732727d9b0..089732524a 100644
> > > > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > @@ -9,6 +9,28 @@
> > > > > chosen {
> > > > > u-boot,spl-boot-order = "same-as-spl", _flash, 
> > > > > , 
> > > > > };
> > > > > +
> > > > > +smbios {
> > > > > +compatible = "u-boot,sysinfo-smbios";
> > > > > +smbios {
> > > > > +system {
> > > > > +manufacturer = "Pine64";
> > > > > +product = "RockPro64";
> > > > > +};
> [snip]
> > > Yes, we should just defer this and pickup the SMBIOS series that Ilias
> > > has posted.
> >
> > I don't think it is a suitable substitute, it is just a fallback.
> >
> > So I believe this patch should be applied.
>
> Please note that this patch is adding _less_ details than the top-level
> model field contains today for the platform.  The only difference is
> "Pine64" vs "pine64".

The top-level model is "Pine64 RockPro64 v2.1", I believe. But:

- the first part of that is the manufacturer, not the product
- the second part is what we have in this patch
- the third part is the version

SMBIOS tries to split things up into separate fields.

So, perhaps a new version of this patch could add:

   system {
 version = "2.1";
   };

Regards,
Simon


Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-12-13 Thread Tom Rini
On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Mon, 11 Dec 2023 at 13:53, Tom Rini  wrote:
> >
> > On Mon, Dec 11, 2023 at 08:42:19PM +, Shantur Rathore wrote:
> > > Hi,
> > >
> > > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore  wrote:
> > > >
> > > > Add smbios information for Pine64 RockPro64 board and enable in
> > > > config
> > > >
> > > > Signed-off-by: Shantur Rathore 
> > > > ---
> > > >  Changes
> > > >  v4: Change PINE64 to Pine64
> > > >  v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> > > >
> > > >  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++
> > > >  configs/rockpro64-rk3399_defconfig|  2 ++
> > > >  2 files changed, 24 insertions(+)
> > > >
> > > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi 
> > > > b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > index 732727d9b0..089732524a 100644
> > > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > @@ -9,6 +9,28 @@
> > > > chosen {
> > > > u-boot,spl-boot-order = "same-as-spl", _flash, 
> > > > , 
> > > > };
> > > > +
> > > > +smbios {
> > > > +compatible = "u-boot,sysinfo-smbios";
> > > > +smbios {
> > > > +system {
> > > > +manufacturer = "Pine64";
> > > > +product = "RockPro64";
> > > > +};
[snip]
> > Yes, we should just defer this and pickup the SMBIOS series that Ilias
> > has posted.
> 
> I don't think it is a suitable substitute, it is just a fallback.
> 
> So I believe this patch should be applied.

Please note that this patch is adding _less_ details than the top-level
model field contains today for the platform.  The only difference is
"Pine64" vs "pine64".

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-12-13 Thread Simon Glass
Hi Tom,

On Mon, 11 Dec 2023 at 13:53, Tom Rini  wrote:
>
> On Mon, Dec 11, 2023 at 08:42:19PM +, Shantur Rathore wrote:
> > Hi,
> >
> > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore  wrote:
> > >
> > > Add smbios information for Pine64 RockPro64 board and enable in
> > > config
> > >
> > > Signed-off-by: Shantur Rathore 
> > > ---
> > >  Changes
> > >  v4: Change PINE64 to Pine64
> > >  v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> > >
> > >  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++
> > >  configs/rockpro64-rk3399_defconfig|  2 ++
> > >  2 files changed, 24 insertions(+)
> > >
> > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi 
> > > b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > index 732727d9b0..089732524a 100644
> > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > @@ -9,6 +9,28 @@
> > > chosen {
> > > u-boot,spl-boot-order = "same-as-spl", _flash, 
> > > , 
> > > };
> > > +
> > > +smbios {
> > > +compatible = "u-boot,sysinfo-smbios";
> > > +smbios {
> > > +system {
> > > +manufacturer = "Pine64";
> > > +product = "RockPro64";
> > > +};
> > > +
> > > +baseboard {
> > > +manufacturer = "Pine64";
> > > +product = "RockPro64";
> > > +};
> > > +
> > > +chassis {
> > > +manufacturer = "Pine64";
> > > +product = "RockPro64";
> > > +};
> > > +};
> > > +};
> > > +
> > > +
> > >  };
> > >
> > >   {
> > > diff --git a/configs/rockpro64-rk3399_defconfig 
> > > b/configs/rockpro64-rk3399_defconfig
> > > index 4cd6b76665..affb6137e0 100644
> > > --- a/configs/rockpro64-rk3399_defconfig
> > > +++ b/configs/rockpro64-rk3399_defconfig
> > > @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=150
> > >  CONFIG_DEBUG_UART_SHIFT=2
> > >  CONFIG_SYS_NS16550_MEM32=y
> > >  CONFIG_ROCKCHIP_SPI=y
> > > +CONFIG_SYSINFO=y
> > > +CONFIG_SYSINFO_SMBIOS=y
> > >  CONFIG_SYSRESET=y
> > >  CONFIG_USB=y
> > >  CONFIG_USB_XHCI_HCD=y
> > > --
> > > 2.40.1
> > >
> >
> > Can this please be merged if no changes are required?
> >
> > [0] - 
> > https://patchwork.ozlabs.org/project/uboot/patch/20231113112309.730323-...@shantur.com/
>
> Yes, we should just defer this and pickup the SMBIOS series that Ilias
> has posted.

I don't think it is a suitable substitute, it is just a fallback.

So I believe this patch should be applied.

Reviewed-by: Simon Glass 

Regards,
Simon


Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-12-11 Thread Kever Yang



On 2023/11/13 19:23, Shantur Rathore wrote:

Add smbios information for Pine64 RockPro64 board and enable in
config

Signed-off-by: Shantur Rathore 

Reviewed-by: Kever Yang 

Thanks,
- Kever

---
  Changes
  v4: Change PINE64 to Pine64
  v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig

  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++
  configs/rockpro64-rk3399_defconfig|  2 ++
  2 files changed, 24 insertions(+)

diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi 
b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
index 732727d9b0..089732524a 100644
--- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
@@ -9,6 +9,28 @@
chosen {
u-boot,spl-boot-order = "same-as-spl", _flash, , 

};
+
+smbios {
+compatible = "u-boot,sysinfo-smbios";
+smbios {
+system {
+manufacturer = "Pine64";
+product = "RockPro64";
+};
+
+baseboard {
+manufacturer = "Pine64";
+product = "RockPro64";
+};
+
+chassis {
+manufacturer = "Pine64";
+product = "RockPro64";
+};
+};
+};
+
+
  };
  
   {

diff --git a/configs/rockpro64-rk3399_defconfig 
b/configs/rockpro64-rk3399_defconfig
index 4cd6b76665..affb6137e0 100644
--- a/configs/rockpro64-rk3399_defconfig
+++ b/configs/rockpro64-rk3399_defconfig
@@ -90,6 +90,8 @@ CONFIG_BAUDRATE=150
  CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_SYS_NS16550_MEM32=y
  CONFIG_ROCKCHIP_SPI=y
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
  CONFIG_SYSRESET=y
  CONFIG_USB=y
  CONFIG_USB_XHCI_HCD=y


Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-12-11 Thread Tom Rini
On Mon, Dec 11, 2023 at 08:42:19PM +, Shantur Rathore wrote:
> Hi,
> 
> On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore  wrote:
> >
> > Add smbios information for Pine64 RockPro64 board and enable in
> > config
> >
> > Signed-off-by: Shantur Rathore 
> > ---
> >  Changes
> >  v4: Change PINE64 to Pine64
> >  v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> >
> >  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++
> >  configs/rockpro64-rk3399_defconfig|  2 ++
> >  2 files changed, 24 insertions(+)
> >
> > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi 
> > b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > index 732727d9b0..089732524a 100644
> > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > @@ -9,6 +9,28 @@
> > chosen {
> > u-boot,spl-boot-order = "same-as-spl", _flash, , 
> > 
> > };
> > +
> > +smbios {
> > +compatible = "u-boot,sysinfo-smbios";
> > +smbios {
> > +system {
> > +manufacturer = "Pine64";
> > +product = "RockPro64";
> > +};
> > +
> > +baseboard {
> > +manufacturer = "Pine64";
> > +product = "RockPro64";
> > +};
> > +
> > +chassis {
> > +manufacturer = "Pine64";
> > +product = "RockPro64";
> > +};
> > +};
> > +};
> > +
> > +
> >  };
> >
> >   {
> > diff --git a/configs/rockpro64-rk3399_defconfig 
> > b/configs/rockpro64-rk3399_defconfig
> > index 4cd6b76665..affb6137e0 100644
> > --- a/configs/rockpro64-rk3399_defconfig
> > +++ b/configs/rockpro64-rk3399_defconfig
> > @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=150
> >  CONFIG_DEBUG_UART_SHIFT=2
> >  CONFIG_SYS_NS16550_MEM32=y
> >  CONFIG_ROCKCHIP_SPI=y
> > +CONFIG_SYSINFO=y
> > +CONFIG_SYSINFO_SMBIOS=y
> >  CONFIG_SYSRESET=y
> >  CONFIG_USB=y
> >  CONFIG_USB_XHCI_HCD=y
> > --
> > 2.40.1
> >
> 
> Can this please be merged if no changes are required?
> 
> [0] - 
> https://patchwork.ozlabs.org/project/uboot/patch/20231113112309.730323-...@shantur.com/

Yes, we should just defer this and pickup the SMBIOS series that Ilias
has posted.

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-12-11 Thread Shantur Rathore
Hi,

On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore  wrote:
>
> Add smbios information for Pine64 RockPro64 board and enable in
> config
>
> Signed-off-by: Shantur Rathore 
> ---
>  Changes
>  v4: Change PINE64 to Pine64
>  v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
>
>  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++
>  configs/rockpro64-rk3399_defconfig|  2 ++
>  2 files changed, 24 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi 
> b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> index 732727d9b0..089732524a 100644
> --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> @@ -9,6 +9,28 @@
> chosen {
> u-boot,spl-boot-order = "same-as-spl", _flash, , 
> 
> };
> +
> +smbios {
> +compatible = "u-boot,sysinfo-smbios";
> +smbios {
> +system {
> +manufacturer = "Pine64";
> +product = "RockPro64";
> +};
> +
> +baseboard {
> +manufacturer = "Pine64";
> +product = "RockPro64";
> +};
> +
> +chassis {
> +manufacturer = "Pine64";
> +product = "RockPro64";
> +};
> +};
> +};
> +
> +
>  };
>
>   {
> diff --git a/configs/rockpro64-rk3399_defconfig 
> b/configs/rockpro64-rk3399_defconfig
> index 4cd6b76665..affb6137e0 100644
> --- a/configs/rockpro64-rk3399_defconfig
> +++ b/configs/rockpro64-rk3399_defconfig
> @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=150
>  CONFIG_DEBUG_UART_SHIFT=2
>  CONFIG_SYS_NS16550_MEM32=y
>  CONFIG_ROCKCHIP_SPI=y
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
>  CONFIG_SYSRESET=y
>  CONFIG_USB=y
>  CONFIG_USB_XHCI_HCD=y
> --
> 2.40.1
>

Can this please be merged if no changes are required?

[0] - 
https://patchwork.ozlabs.org/project/uboot/patch/20231113112309.730323-...@shantur.com/

Kind regards,
Shantur


[PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-11-13 Thread Shantur Rathore
Add smbios information for Pine64 RockPro64 board and enable in
config

Signed-off-by: Shantur Rathore 
---
 Changes 
 v4: Change PINE64 to Pine64
 v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig

 arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++
 configs/rockpro64-rk3399_defconfig|  2 ++
 2 files changed, 24 insertions(+)

diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi 
b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
index 732727d9b0..089732524a 100644
--- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
@@ -9,6 +9,28 @@
chosen {
u-boot,spl-boot-order = "same-as-spl", _flash, , 

};
+
+smbios {
+compatible = "u-boot,sysinfo-smbios";
+smbios {
+system {
+manufacturer = "Pine64";
+product = "RockPro64";
+};
+
+baseboard {
+manufacturer = "Pine64";
+product = "RockPro64";
+};
+
+chassis {
+manufacturer = "Pine64";
+product = "RockPro64";
+};
+};
+};
+
+
 };
 
  {
diff --git a/configs/rockpro64-rk3399_defconfig 
b/configs/rockpro64-rk3399_defconfig
index 4cd6b76665..affb6137e0 100644
--- a/configs/rockpro64-rk3399_defconfig
+++ b/configs/rockpro64-rk3399_defconfig
@@ -90,6 +90,8 @@ CONFIG_BAUDRATE=150
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550_MEM32=y
 CONFIG_ROCKCHIP_SPI=y
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
-- 
2.40.1