Re: [PATCH v4 2/5] sf: Use const for the stage name
On 9/19/21 23:49, Simon Glass wrote: > This is not updated at runtime so should be marked const. Update the code > accordingly. > > Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt > --- > > (no changes since v1) > > cmd/sf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to u-boot-dm, thanks! Applied to u-boot-dm/next, thanks!
Re: [PATCH v4 2/5] sf: Use const for the stage name
On 9/19/21 23:49, Simon Glass wrote: > This is not updated at runtime so should be marked const. Update the code > accordingly. > > Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt > --- > > (no changes since v1) > > cmd/sf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to u-boot-dm, thanks!
Re: [PATCH v4 2/5] sf: Use const for the stage name
On 9/19/21 23:49, Simon Glass wrote:
This is not updated at runtime so should be marked const. Update the code
accordingly.
Signed-off-by: Simon Glass
Reviewed-by: Heinrich Schuchardt
---
(no changes since v1)
cmd/sf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/sf.c b/cmd/sf.c
index eac27ed2d77..15361a4bddf 100644
--- a/cmd/sf.c
+++ b/cmd/sf.c
@@ -394,7 +394,7 @@ enum {
STAGE_COUNT,
};
-static char *stage_name[STAGE_COUNT] = {
+static const char *stage_name[STAGE_COUNT] = {
"erase",
"check",
"write",
Re: [PATCH v4 2/5] sf: Use const for the stage name
On Mon, Sep 20, 2021 at 3:19 AM Simon Glass wrote: > > This is not updated at runtime so should be marked const. Update the code > accordingly. > > Signed-off-by: Simon Glass > --- > Reviewed-by: Jagan Teki
[PATCH v4 2/5] sf: Use const for the stage name
This is not updated at runtime so should be marked const. Update the code
accordingly.
Signed-off-by: Simon Glass
---
(no changes since v1)
cmd/sf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/sf.c b/cmd/sf.c
index eac27ed2d77..15361a4bddf 100644
--- a/cmd/sf.c
+++ b/cmd/sf.c
@@ -394,7 +394,7 @@ enum {
STAGE_COUNT,
};
-static char *stage_name[STAGE_COUNT] = {
+static const char *stage_name[STAGE_COUNT] = {
"erase",
"check",
"write",
--
2.33.0.464.g1972c5931b-goog
