Re: [PATCH v4 3/3] sunxi: Use mkimage for SPL boot image generation
On 07/01/2021 12:36, Simon Glass wrote: Hi Simon, thanks for the review! > On Wed, 6 Jan 2021 at 02:25, Andre Przywara wrote: >> >> Switch the SPL boot image generation from using mksunxiboot to the new >> sunxi_egon format of mkimage. >> >> Verified to create identical results for all 152 Allwinner boards. >> >> Signed-off-by: Andre Przywara >> --- >> scripts/Makefile.spl | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) > > Reviewed-by: Simon Glass > > Do we need to delete the old tool? I would rather not quite do this yet, instead leave it around for a bit. There is for instance sunxi-tools, that relies on this, and it's also packaged as part of Debian's u-boot-tools package. We surely will transition them over, but this might take a while. Cheers, Andre
Re: [PATCH v4 3/3] sunxi: Use mkimage for SPL boot image generation
On Wed, 6 Jan 2021 at 02:25, Andre Przywara wrote: > > Switch the SPL boot image generation from using mksunxiboot to the new > sunxi_egon format of mkimage. > > Verified to create identical results for all 152 Allwinner boards. > > Signed-off-by: Andre Przywara > --- > scripts/Makefile.spl | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass Do we need to delete the old tool?
[PATCH v4 3/3] sunxi: Use mkimage for SPL boot image generation
Switch the SPL boot image generation from using mksunxiboot to the new sunxi_egon format of mkimage. Verified to create identical results for all 152 Allwinner boards. Signed-off-by: Andre Przywara --- scripts/Makefile.spl | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 9f1f7445d71..db95bd998a8 100644 --- a/scripts/Makefile.spl +++ b/scripts/Makefile.spl @@ -382,11 +382,11 @@ endif $(obj)/$(SPL_BIN).sfp: $(obj)/$(SPL_BIN).bin FORCE $(call if_changed,mkimage) -quiet_cmd_mksunxiboot = MKSUNXI $@ -cmd_mksunxiboot = $(objtree)/tools/mksunxiboot \ - --default-dt $(CONFIG_DEFAULT_DEVICE_TREE) $< $@ +MKIMAGEFLAGS_sunxi-spl.bin = -T sunxi_egon \ + -n $(CONFIG_DEFAULT_DEVICE_TREE) + $(obj)/sunxi-spl.bin: $(obj)/$(SPL_BIN).bin FORCE - $(call if_changed,mksunxiboot) + $(call if_changed,mkimage) quiet_cmd_sunxi_spl_image_builder = SUNXI_SPL_IMAGE_BUILDER $@ cmd_sunxi_spl_image_builder = $(objtree)/tools/sunxi-spl-image-builder \ -- 2.17.5