Re: [PATCH v5 03/17] menu: always show the menu regardless of the number of entry

2022-05-01 Thread Heinrich Schuchardt

On 4/28/22 10:09, Masahisa Kojima wrote:

To make user aware of the menu entry selection, menu always
appears regardless of the number of entry.

Signed-off-by: Masahisa Kojima 


Reviewed-by: Heinrich Schuchardt 


---
No changes since v4

Newly created in v4

  common/menu.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/menu.c b/common/menu.c
index 5fb2ffbd06..b577d80b4f 100644
--- a/common/menu.c
+++ b/common/menu.c
@@ -271,7 +271,7 @@ int menu_get_choice(struct menu *m, void **choice)
if (!m || !choice)
return -EINVAL;

-   if (!m->prompt || m->item_cnt == 1)
+   if (!m->prompt)
return menu_default_choice(m, choice);

return menu_interactive_choice(m, choice);




[PATCH v5 03/17] menu: always show the menu regardless of the number of entry

2022-04-28 Thread Masahisa Kojima
To make user aware of the menu entry selection, menu always
appears regardless of the number of entry.

Signed-off-by: Masahisa Kojima 
---
No changes since v4

Newly created in v4

 common/menu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/menu.c b/common/menu.c
index 5fb2ffbd06..b577d80b4f 100644
--- a/common/menu.c
+++ b/common/menu.c
@@ -271,7 +271,7 @@ int menu_get_choice(struct menu *m, void **choice)
if (!m || !choice)
return -EINVAL;
 
-   if (!m->prompt || m->item_cnt == 1)
+   if (!m->prompt)
return menu_default_choice(m, choice);
 
return menu_interactive_choice(m, choice);
-- 
2.17.1