Re: [PATCH v5 05/17] efi_loader: export efi_locate_device_handle()

[Ilias Apalodimas]

On Sun, 1 May 2022 at 21:59, Heinrich Schuchardt  wrote:
>
> On 4/28/22 10:09, Masahisa Kojima wrote:
> > From: AKASHI Takahiro 
> >
> > This function will be used in the next commit where some behavior
> > of EFI boot manager will be expanded.
> >
> > Signed-off-by: AKASHI Takahiro 
> > Reviewed-by: Ilias Apalodimas 
>
> Reviewed-by: Heinrich Schuchardt 
>
> > ---
> > No changes from original version
> >
> >   include/efi_loader.h  | 4 
> >   lib/efi_loader/efi_boottime.c | 7 +++
> >   2 files changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/include/efi_loader.h b/include/efi_loader.h
> > index ba79a9afb4..effb43369d 100644
> > --- a/include/efi_loader.h
> > +++ b/include/efi_loader.h
> > @@ -595,6 +595,10 @@ efi_status_t efi_create_handle(efi_handle_t *handle);
> >   void efi_delete_handle(efi_handle_t obj);
> >   /* Call this to validate a handle and find the EFI object for it */
> >   struct efi_object *efi_search_obj(const efi_handle_t handle);
> > +/* Locate device_path handle */
> > +efi_status_t EFIAPI efi_locate_device_path(const efi_guid_t *protocol,
> > +struct efi_device_path 
> > **device_path,
> > +efi_handle_t *device);
> >   /* Load image */
> >   efi_status_t EFIAPI efi_load_image(bool boot_policy,
> >  efi_handle_t parent_image,
> > diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
> > index 5bcb8253ed..4da64b5d29 100644
> > --- a/lib/efi_loader/efi_boottime.c
> > +++ b/lib/efi_loader/efi_boottime.c
> > @@ -1799,10 +1799,9 @@ failure:
> >*
> >* Return: status code
> >*/
> > -static efi_status_t EFIAPI efi_locate_device_path(
> > - const efi_guid_t *protocol,
> > - struct efi_device_path **device_path,
> > - efi_handle_t *device)
> > +efi_status_t EFIAPI efi_locate_device_path(const efi_guid_t *protocol,
> > +struct efi_device_path 
> > **device_path,
> > +efi_handle_t *device)
> >   {
> >   struct efi_device_path *dp;
> >   size_t i;
>

Reviewed-by: Ilias Apalodimas 

Re: [PATCH v5 05/17] efi_loader: export efi_locate_device_handle()

[Heinrich Schuchardt]

On 4/28/22 10:09, Masahisa Kojima wrote:

From: AKASHI Takahiro 

This function will be used in the next commit where some behavior
of EFI boot manager will be expanded.

Signed-off-by: AKASHI Takahiro 
Reviewed-by: Ilias Apalodimas 


Reviewed-by: Heinrich Schuchardt 


---
No changes from original version

  include/efi_loader.h  | 4 
  lib/efi_loader/efi_boottime.c | 7 +++
  2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/include/efi_loader.h b/include/efi_loader.h
index ba79a9afb4..effb43369d 100644
--- a/include/efi_loader.h
+++ b/include/efi_loader.h
@@ -595,6 +595,10 @@ efi_status_t efi_create_handle(efi_handle_t *handle);
  void efi_delete_handle(efi_handle_t obj);
  /* Call this to validate a handle and find the EFI object for it */
  struct efi_object *efi_search_obj(const efi_handle_t handle);
+/* Locate device_path handle */
+efi_status_t EFIAPI efi_locate_device_path(const efi_guid_t *protocol,
+  struct efi_device_path **device_path,
+  efi_handle_t *device);
  /* Load image */
  efi_status_t EFIAPI efi_load_image(bool boot_policy,
   efi_handle_t parent_image,
diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index 5bcb8253ed..4da64b5d29 100644
--- a/lib/efi_loader/efi_boottime.c
+++ b/lib/efi_loader/efi_boottime.c
@@ -1799,10 +1799,9 @@ failure:
   *
   * Return: status code
   */
-static efi_status_t EFIAPI efi_locate_device_path(
-   const efi_guid_t *protocol,
-   struct efi_device_path **device_path,
-   efi_handle_t *device)
+efi_status_t EFIAPI efi_locate_device_path(const efi_guid_t *protocol,
+  struct efi_device_path **device_path,
+  efi_handle_t *device)
  {
struct efi_device_path *dp;
size_t i;

[PATCH v5 05/17] efi_loader: export efi_locate_device_handle()

[Masahisa Kojima]

From: AKASHI Takahiro 

This function will be used in the next commit where some behavior
of EFI boot manager will be expanded.

Signed-off-by: AKASHI Takahiro 
Reviewed-by: Ilias Apalodimas 
---
No changes from original version

 include/efi_loader.h  | 4 
 lib/efi_loader/efi_boottime.c | 7 +++
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/include/efi_loader.h b/include/efi_loader.h
index ba79a9afb4..effb43369d 100644
--- a/include/efi_loader.h
+++ b/include/efi_loader.h
@@ -595,6 +595,10 @@ efi_status_t efi_create_handle(efi_handle_t *handle);
 void efi_delete_handle(efi_handle_t obj);
 /* Call this to validate a handle and find the EFI object for it */
 struct efi_object *efi_search_obj(const efi_handle_t handle);
+/* Locate device_path handle */
+efi_status_t EFIAPI efi_locate_device_path(const efi_guid_t *protocol,
+  struct efi_device_path **device_path,
+  efi_handle_t *device);
 /* Load image */
 efi_status_t EFIAPI efi_load_image(bool boot_policy,
   efi_handle_t parent_image,
diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index 5bcb8253ed..4da64b5d29 100644
--- a/lib/efi_loader/efi_boottime.c
+++ b/lib/efi_loader/efi_boottime.c
@@ -1799,10 +1799,9 @@ failure:
  *
  * Return: status code
  */
-static efi_status_t EFIAPI efi_locate_device_path(
-   const efi_guid_t *protocol,
-   struct efi_device_path **device_path,
-   efi_handle_t *device)
+efi_status_t EFIAPI efi_locate_device_path(const efi_guid_t *protocol,
+  struct efi_device_path **device_path,
+  efi_handle_t *device)
 {
struct efi_device_path *dp;
size_t i;
-- 
2.17.1