Re: [PATCH v5 2/6] arm: update comments to the common style

2020-07-10 Thread Tom Rini
On Wed, Jun 03, 2020 at 02:43:41PM +0200, Marek Szyprowski wrote:

> Update the comments in include/asm/system.h to the common style.
> 
> Signed-off-by: Marek Szyprowski 
> Reviewed-by: Tom Rini 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH v5 2/6] arm: update comments to the common style

2020-06-03 Thread Tom Rini
On Wed, Jun 03, 2020 at 02:43:41PM +0200, Marek Szyprowski wrote:

> Update the comments in include/asm/system.h to the common style.
> 
> Signed-off-by: Marek Szyprowski 

Thanks!

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: PGP signature


[PATCH v5 2/6] arm: update comments to the common style

2020-06-03 Thread Marek Szyprowski
Update the comments in include/asm/system.h to the common style.

Signed-off-by: Marek Szyprowski 
---
 arch/arm/include/asm/system.h | 23 ++-
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h
index 1e3f574..63649ed 100644
--- a/arch/arm/include/asm/system.h
+++ b/arch/arm/include/asm/system.h
@@ -205,7 +205,7 @@ int __asm_invalidate_l3_icache(void);
 void __asm_switch_ttbr(u64 new_ttbr);
 
 /*
- * Switch from EL3 to EL2 for ARMv8
+ * armv8_switch_to_el2() - switch from EL3 to EL2 for ARMv8
  *
  * @args:For loading 64-bit OS, fdt address.
  *   For loading 32-bit OS, zero.
@@ -220,7 +220,7 @@ void __asm_switch_ttbr(u64 new_ttbr);
 void __noreturn armv8_switch_to_el2(u64 args, u64 mach_nr, u64 fdt_addr,
u64 arg4, u64 entry_point, u64 es_flag);
 /*
- * Switch from EL2 to EL1 for ARMv8
+ * armv8_switch_to_el1() - switch from EL2 to EL1 for ARMv8
  *
  * @args:For loading 64-bit OS, fdt address.
  *   For loading 32-bit OS, zero.
@@ -246,11 +246,12 @@ void flush_l3_cache(void);
 void mmu_change_region_attr(phys_addr_t start, size_t size, u64 attrs);
 
 /*
- *Issue a secure monitor call in accordance with ARM "SMC Calling convention",
+ * smc_call() - issue a secure monitor call
+ *
+ * Issue a secure monitor call in accordance with ARM "SMC Calling convention",
  * DEN0028A
  *
  * @args: input and output arguments
- *
  */
 void smc_call(struct pt_regs *args);
 
@@ -519,10 +520,12 @@ enum {
 #endif
 
 /**
+ * mmu_page_table_flush() - register an update to page tables
+ *
  * Register an update to the page tables, and flush the TLB
  *
- * \param startstart address of update in page table
- * \param stop stop address of update in page table
+ * @start: start address of update in page table
+ * @stop:  stop address of update in page table
  */
 void mmu_page_table_flush(unsigned long start, unsigned long stop);
 
@@ -582,11 +585,13 @@ s32 psci_features(u32 function_id, u32 psci_fid);
 void save_boot_params_ret(void);
 
 /**
+ * mmu_set_region_dcache_behaviour() - set cache settings
+ *
  * Change the cache settings for a region.
  *
- * \param startstart address of memory region to change
- * \param size size of memory region to change
- * \param option   dcache option to select
+ * @start: start address of memory region to change
+ * @size:  size of memory region to change
+ * @option:dcache option to select
  */
 void mmu_set_region_dcache_behaviour(phys_addr_t start, size_t size,
 enum dcache_option option);
-- 
1.9.1