Re: [PATCH v6 01/25] spl: blk_fs: Fix uninitialized return value when we can't get a blk_desc

[Simon Glass]

On Sun, 5 Nov 2023 at 19:26, Sean Anderson  wrote:
>
> Initialize ret to avoid returning garbage if blk_get_devnum_by_uclass_id
> fails.
>
> Fixes: 8ce6a2e1757 ("spl: blk: Support loading images from fs")
> Signed-off-by: Sean Anderson 
> ---
>
> Changes in v6:
> - New
>
>  common/spl/spl_blk_fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass 

[PATCH v6 01/25] spl: blk_fs: Fix uninitialized return value when we can't get a blk_desc

[Sean Anderson]

Initialize ret to avoid returning garbage if blk_get_devnum_by_uclass_id
fails.

Fixes: 8ce6a2e1757 ("spl: blk: Support loading images from fs")
Signed-off-by: Sean Anderson 
---

Changes in v6:
- New

 common/spl/spl_blk_fs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/spl/spl_blk_fs.c b/common/spl/spl_blk_fs.c
index 63825d620d1..144c8a65b5d 100644
--- a/common/spl/spl_blk_fs.c
+++ b/common/spl/spl_blk_fs.c
@@ -50,7 +50,7 @@ int spl_blk_load_image(struct spl_image_info *spl_image,
struct blk_desc *blk_desc;
loff_t actlen, filesize;
struct blk_dev dev;
-   int ret;
+   int ret = -ENODEV;
 
blk_desc = blk_get_devnum_by_uclass_id(uclass_id, devnum);
if (!blk_desc) {
-- 
2.37.1