Re: [PATCH v6 09/12] arm: mvebu: enable working default boot support
On 16.04.20 07:52, Joel Johnson wrote: On 2020-04-14 03:33, Stefan Roese wrote: Hi Joel, On 23.03.20 21:21, Joel Johnson wrote: With the move to driver model usage, ensure that the required driver support for SPI and MMC booting is available in SPL. Tested on SolidRun ClearFog devices. Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese --- This patch generates multiple warnings on other MVEBU platforms. I've dropped it for now in my upcoming pull request. Please rework the problematic patches (missing in the pull request) and re-send. Thanks, Stefan Sure, I'm looking into the changes and will have a new series with the reworked patches in the next couple of days. The warnings really highlighted additional cleanup on mvebu booting and defaults in general which I'm taking a look at. Thanks. I'm not too familiar with the multi-target building, but have read up on and am currently using the buildman tool with arm and aarch64 toolsets, and building the entire mvebu target set (21 boards currently). Is this the best way to do the testing and building across multiple boards or is there a different way you'd like the testing to be done in the end? buildman is the correct tool for this. It can also automatically download all necessary toolchains for other architectures. Somewhat offtopic, what's the best location to which wiki issues should be reported? The page on Patches [1] still describes the old MAKEALL script. This is outdated. I hadn't found the script originally so skipped that step since it wasn't possible. This time, in digging further in source history I found the commit that removed it and referenced buildman. It would be useful for new contributors to update the wiki with a pointer to buildman if that's the desired replacement tool. Could you please work on the wiki with the updated infos? That would be helpful. Thanks, Stefan
Re: [PATCH v6 09/12] arm: mvebu: enable working default boot support
On 2020-04-14 03:33, Stefan Roese wrote: Hi Joel, On 23.03.20 21:21, Joel Johnson wrote: With the move to driver model usage, ensure that the required driver support for SPI and MMC booting is available in SPL. Tested on SolidRun ClearFog devices. Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese --- This patch generates multiple warnings on other MVEBU platforms. I've dropped it for now in my upcoming pull request. Please rework the problematic patches (missing in the pull request) and re-send. Thanks, Stefan Sure, I'm looking into the changes and will have a new series with the reworked patches in the next couple of days. The warnings really highlighted additional cleanup on mvebu booting and defaults in general which I'm taking a look at. I'm not too familiar with the multi-target building, but have read up on and am currently using the buildman tool with arm and aarch64 toolsets, and building the entire mvebu target set (21 boards currently). Is this the best way to do the testing and building across multiple boards or is there a different way you'd like the testing to be done in the end? Somewhat offtopic, what's the best location to which wiki issues should be reported? The page on Patches [1] still describes the old MAKEALL script. I hadn't found the script originally so skipped that step since it wasn't possible. This time, in digging further in source history I found the commit that removed it and referenced buildman. It would be useful for new contributors to update the wiki with a pointer to buildman if that's the desired replacement tool. Joel [1] https://www.denx.de/wiki/U-Boot/Patches
Re: [PATCH v6 09/12] arm: mvebu: enable working default boot support
Hi Joel, On 23.03.20 21:21, Joel Johnson wrote: With the move to driver model usage, ensure that the required driver support for SPI and MMC booting is available in SPL. Tested on SolidRun ClearFog devices. Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese --- v2 changes: - change "select" for ENV_IS_IN_X to "imply" to allow disabling the default env location and configuring a different one if desired - remove SPL_DM_GPIO from defconfig, only include if needed for MMC booting v3 changes: - none v4 changes: - none v5 changes: - none v6 changes: - none This patch generates multiple warnings on other MVEBU platforms. I've dropped it for now in my upcoming pull request. Please rework the problematic patches (missing in the pull request) and re-send. Thanks, Stefan --- arch/arm/mach-mvebu/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig index 161dee937f..32191e7157 100644 --- a/arch/arm/mach-mvebu/Kconfig +++ b/arch/arm/mach-mvebu/Kconfig @@ -235,9 +235,19 @@ choice config MVEBU_SPL_BOOT_DEVICE_SPI bool "SPI NOR flash" + imply ENV_IS_IN_SPI_FLASH + select SPL_DM_SPI + select SPL_MTD_SUPPORT + select SPL_SPI_FLASH_SUPPORT + select SPL_SPI_LOAD + select SPL_SPI_SUPPORT config MVEBU_SPL_BOOT_DEVICE_MMC bool "SDIO/MMC card" + imply ENV_IS_IN_MMC + # GPIO required for SD card presence detection line + select SPL_DM_GPIO + select SPL_DM_MMC select SPL_LIBDISK_SUPPORT config MVEBU_SPL_BOOT_DEVICE_SATA Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de
[PATCH v6 09/12] arm: mvebu: enable working default boot support
With the move to driver model usage, ensure that the required driver support for SPI and MMC booting is available in SPL. Tested on SolidRun ClearFog devices. Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese --- v2 changes: - change "select" for ENV_IS_IN_X to "imply" to allow disabling the default env location and configuring a different one if desired - remove SPL_DM_GPIO from defconfig, only include if needed for MMC booting v3 changes: - none v4 changes: - none v5 changes: - none v6 changes: - none --- arch/arm/mach-mvebu/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig index 161dee937f..32191e7157 100644 --- a/arch/arm/mach-mvebu/Kconfig +++ b/arch/arm/mach-mvebu/Kconfig @@ -235,9 +235,19 @@ choice config MVEBU_SPL_BOOT_DEVICE_SPI bool "SPI NOR flash" + imply ENV_IS_IN_SPI_FLASH + select SPL_DM_SPI + select SPL_MTD_SUPPORT + select SPL_SPI_FLASH_SUPPORT + select SPL_SPI_LOAD + select SPL_SPI_SUPPORT config MVEBU_SPL_BOOT_DEVICE_MMC bool "SDIO/MMC card" + imply ENV_IS_IN_MMC + # GPIO required for SD card presence detection line + select SPL_DM_GPIO + select SPL_DM_MMC select SPL_LIBDISK_SUPPORT config MVEBU_SPL_BOOT_DEVICE_SATA -- 2.25.0
