Re: [PATCH v6 7/7] test: dm: fwu: fix for the updated api

2023-03-15 Thread Ilias Apalodimas
On Mon, Mar 06, 2023 at 05:18:58PM -0600, jassisinghb...@gmail.com wrote:
> From: Jassi Brar 
>
> fwu_get_mdata() no more requires 'dev' argument and
> fwu_check_mdata_validity() has been rendered useless and dropped.
> Fix the test cases to work with aforementioned changes.
>
> Signed-off-by: Jassi Brar 
> ---
>  test/dm/fwu_mdata.c | 22 +++---
>  1 file changed, 3 insertions(+), 19 deletions(-)
>
> diff --git a/test/dm/fwu_mdata.c b/test/dm/fwu_mdata.c
> index b179a65c15..8b5c83ef4e 100644
> --- a/test/dm/fwu_mdata.c
> +++ b/test/dm/fwu_mdata.c
> @@ -98,7 +98,7 @@ static int dm_test_fwu_mdata_read(struct unit_test_state 
> *uts)
>   ut_assertok(populate_mmc_disk_image(uts));
>   ut_assertok(write_mmc_blk_device(uts));
>
> - ut_assertok(fwu_get_mdata(dev, ));
> + ut_assertok(fwu_get_mdata());
>
>   ut_asserteq(mdata.version, 0x1);
>
> @@ -118,30 +118,14 @@ static int dm_test_fwu_mdata_write(struct 
> unit_test_state *uts)
>
>   ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, ));
>
> - ut_assertok(fwu_get_mdata(dev, ));
> + ut_assertok(fwu_get_mdata());
>
>   active_idx = (mdata.active_index + 1) % CONFIG_FWU_NUM_BANKS;
>   ut_assertok(fwu_set_active_index(active_idx));
>
> - ut_assertok(fwu_get_mdata(dev, ));
> + ut_assertok(fwu_get_mdata());
>   ut_asserteq(mdata.active_index, active_idx);
>
>   return 0;
>  }
>  DM_TEST(dm_test_fwu_mdata_write, UT_TESTF_SCAN_FDT);
> -
> -static int dm_test_fwu_mdata_check(struct unit_test_state *uts)
> -{
> - struct udevice *dev;
> -
> - ut_assertok(setup_blk_device(uts));
> - ut_assertok(populate_mmc_disk_image(uts));
> - ut_assertok(write_mmc_blk_device(uts));
> -
> - ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, ));
> -
> - ut_assertok(fwu_check_mdata_validity());
> -
> - return 0;
> -}
> -DM_TEST(dm_test_fwu_mdata_check, UT_TESTF_SCAN_FDT);
> --
> 2.34.1
>

Acked-by: Ilias Apalodimas 



[PATCH v6 7/7] test: dm: fwu: fix for the updated api

2023-03-06 Thread jassisinghbrar
From: Jassi Brar 

fwu_get_mdata() no more requires 'dev' argument and
fwu_check_mdata_validity() has been rendered useless and dropped.
Fix the test cases to work with aforementioned changes.

Signed-off-by: Jassi Brar 
---
 test/dm/fwu_mdata.c | 22 +++---
 1 file changed, 3 insertions(+), 19 deletions(-)

diff --git a/test/dm/fwu_mdata.c b/test/dm/fwu_mdata.c
index b179a65c15..8b5c83ef4e 100644
--- a/test/dm/fwu_mdata.c
+++ b/test/dm/fwu_mdata.c
@@ -98,7 +98,7 @@ static int dm_test_fwu_mdata_read(struct unit_test_state *uts)
ut_assertok(populate_mmc_disk_image(uts));
ut_assertok(write_mmc_blk_device(uts));
 
-   ut_assertok(fwu_get_mdata(dev, ));
+   ut_assertok(fwu_get_mdata());
 
ut_asserteq(mdata.version, 0x1);
 
@@ -118,30 +118,14 @@ static int dm_test_fwu_mdata_write(struct unit_test_state 
*uts)
 
ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, ));
 
-   ut_assertok(fwu_get_mdata(dev, ));
+   ut_assertok(fwu_get_mdata());
 
active_idx = (mdata.active_index + 1) % CONFIG_FWU_NUM_BANKS;
ut_assertok(fwu_set_active_index(active_idx));
 
-   ut_assertok(fwu_get_mdata(dev, ));
+   ut_assertok(fwu_get_mdata());
ut_asserteq(mdata.active_index, active_idx);
 
return 0;
 }
 DM_TEST(dm_test_fwu_mdata_write, UT_TESTF_SCAN_FDT);
-
-static int dm_test_fwu_mdata_check(struct unit_test_state *uts)
-{
-   struct udevice *dev;
-
-   ut_assertok(setup_blk_device(uts));
-   ut_assertok(populate_mmc_disk_image(uts));
-   ut_assertok(write_mmc_blk_device(uts));
-
-   ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, ));
-
-   ut_assertok(fwu_check_mdata_validity());
-
-   return 0;
-}
-DM_TEST(dm_test_fwu_mdata_check, UT_TESTF_SCAN_FDT);
-- 
2.34.1