[RFC PATCH v3 1/8] lib: allow to build asn1 decoder and oid registry in SPL

[Philippe Reynes]

This commit adds the options:
- SPL_ASN1_DECODER
- SPL_OID_REGISTRY

Signed-off-by: Philippe Reynes 
---
 lib/Kconfig  | 6 ++
 lib/Makefile | 7 +--
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/lib/Kconfig b/lib/Kconfig
index 70bf8e7a46..ebff84f113 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -758,11 +758,17 @@ config ASN1_DECODER
help
  Enable asn1 decoder library.
 
+config SPL_ASN1_DECODER
+   bool
+
 config OID_REGISTRY
bool
help
  Enable fast lookup object identifier registry.
 
+config SPL_OID_REGISTRY
+   bool
+
 config SMBIOS_PARSER
bool "SMBIOS parser"
help
diff --git a/lib/Makefile b/lib/Makefile
index 5ddbc77ed6..900e684d62 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -17,7 +17,6 @@ obj-$(CONFIG_OF_LIVE) += of_live.o
 obj-$(CONFIG_CMD_DHRYSTONE) += dhry/
 obj-$(CONFIG_ARCH_AT91) += at91/
 obj-$(CONFIG_OPTEE_LIB) += optee/
-obj-$(CONFIG_ASN1_DECODER) += asn1_decoder.o
 obj-y += crypto/
 
 obj-$(CONFIG_AES) += aes.o
@@ -67,6 +66,7 @@ obj-$(CONFIG_SHA1) += sha1.o
 obj-$(CONFIG_SHA256) += sha256.o
 obj-$(CONFIG_SHA512) += sha512.o
 obj-$(CONFIG_CRYPT_PW) += crypt/
+obj-$(CONFIG_$(SPL_)ASN1_DECODER) += asn1_decoder.o
 
 obj-$(CONFIG_$(SPL_)ZLIB) += zlib/
 obj-$(CONFIG_$(SPL_)ZSTD) += zstd/
@@ -128,9 +128,9 @@ obj-$(CONFIG_$(SPL_TPL_)STRTO) += strto.o
 else
 # Main U-Boot always uses the full printf support
 obj-y += vsprintf.o strto.o
-obj-$(CONFIG_OID_REGISTRY) += oid_registry.o
 obj-$(CONFIG_SSCANF) += sscanf.o
 endif
+obj-$(CONFIG_$(SPL_)OID_REGISTRY) += oid_registry.o
 
 obj-y += abuf.o
 obj-y += date.o
@@ -141,6 +141,9 @@ obj-$(CONFIG_LIB_ELF) += elf.o
 # Build a fast OID lookup registry from include/linux/oid_registry.h
 #
 $(obj)/oid_registry.o: $(obj)/oid_registry_data.c
+ifdef CONFIG_SPL_BUILD
+CFLAGS_oid_registry.o += -I$(obj)
+endif
 
 $(obj)/oid_registry_data.c: $(srctree)/include/linux/oid_registry.h \
$(srctree)/scripts/build_OID_registry
-- 
2.17.1

Re: [RFC PATCH v3 1/8] lib: allow to build asn1 decoder and oid registry in SPL

[Simon Glass]

Hi Philippe,

On Wed, 17 Nov 2021 at 10:52, Philippe Reynes
 wrote:
>
> This commit adds the options:
> - SPL_ASN1_DECODER
> - SPL_OID_REGISTRY
>
> Signed-off-by: Philippe Reynes 
> ---
>  lib/Kconfig  | 6 ++
>  lib/Makefile | 7 +--
>  2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 70bf8e7a46..ebff84f113 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -758,11 +758,17 @@ config ASN1_DECODER
> help
>   Enable asn1 decoder library.
>
> +config SPL_ASN1_DECODER
> +   bool

Please add help.

While you are here could you fix up the help above? It is pretty
useless. It should mention what ASN stands for, what the library
allows and a link to some information.

> +
>  config OID_REGISTRY
> bool
> help
>   Enable fast lookup object identifier registry.
>
> +config SPL_OID_REGISTRY
> +   bool

help

Again that help is not very useful, please expand.

[..]

Regards,
SImon