Re: [U-Boot] [GIT] Pull request: u-boot-dfu (04.01.2019)
On 1/7/19 3:51 PM, Jean-Jacques Hiblot wrote: > > On 04/01/2019 19:51, Marek Vasut wrote: >> On 1/4/19 4:17 PM, Jean-Jacques Hiblot wrote: >>> On 04/01/2019 16:07, Marek Vasut wrote: On 1/4/19 8:01 AM, Lukasz Majewski wrote: > Dear Marek, > > The following changes since commit > 7436f5e54d35bcad53befec90e2e67288071f74e: > > Merge tag 'for-master-20190103' of > git://git.denx.de/u-boot-rockchip > (2019-01-03 08:39:44 -0500) > > are available in the git repository at: > > git://git.denx.de/u-boot-dfu.git > > for you to fetch changes up to > deb73d0aea6ca09ecb56ea3431d3151427fff4a4: > > dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 > 22:43:02 +0100) > > > Jean-Jacques Hiblot (3): > dm: usb: udc: Use SEQ_ALIAS to index the USB gadget ports > ARM: dts: define USB aliases for all omap5 platforms > dm: usb: gadget: Fix boot breakage on sunxi platforms Why is udc-uclass.c compiled in when CONFIG_(SPL_)DM is enabled ? This doesn't make sense, I don't want any UDC code in builds which enable just DM . >>> It only adds the UCLASS_DRIVER definition for the USB gadget. The rest >>> is compiled out inside udc-uclass.c >> Why do we want it in unconditionally at all ? > > We don't really. I'll post something to make it conditional on USB_GADGET. > > I'll take the opportunity to rename SPL_USB_GADGET_SUPPORT to > SPL_USB_GADGET for consistency. > > But this may take some time to verify (buildman and also boot check), > and the current version seems to work for everyone so far. That's fine, there's still ~1 week till the release. -- Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [GIT] Pull request: u-boot-dfu (04.01.2019)
On 04/01/2019 19:51, Marek Vasut wrote: On 1/4/19 4:17 PM, Jean-Jacques Hiblot wrote: On 04/01/2019 16:07, Marek Vasut wrote: On 1/4/19 8:01 AM, Lukasz Majewski wrote: Dear Marek, The following changes since commit 7436f5e54d35bcad53befec90e2e67288071f74e: Merge tag 'for-master-20190103' of git://git.denx.de/u-boot-rockchip (2019-01-03 08:39:44 -0500) are available in the git repository at: git://git.denx.de/u-boot-dfu.git for you to fetch changes up to deb73d0aea6ca09ecb56ea3431d3151427fff4a4: dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 22:43:02 +0100) Jean-Jacques Hiblot (3): dm: usb: udc: Use SEQ_ALIAS to index the USB gadget ports ARM: dts: define USB aliases for all omap5 platforms dm: usb: gadget: Fix boot breakage on sunxi platforms Why is udc-uclass.c compiled in when CONFIG_(SPL_)DM is enabled ? This doesn't make sense, I don't want any UDC code in builds which enable just DM . It only adds the UCLASS_DRIVER definition for the USB gadget. The rest is compiled out inside udc-uclass.c Why do we want it in unconditionally at all ? We don't really. I'll post something to make it conditional on USB_GADGET. I'll take the opportunity to rename SPL_USB_GADGET_SUPPORT to SPL_USB_GADGET for consistency. But this may take some time to verify (buildman and also boot check), and the current version seems to work for everyone so far. JJ ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [GIT] Pull request: u-boot-dfu (04.01.2019)
On 1/4/19 4:17 PM, Jean-Jacques Hiblot wrote: > > On 04/01/2019 16:07, Marek Vasut wrote: >> On 1/4/19 8:01 AM, Lukasz Majewski wrote: >>> Dear Marek, >>> >>> The following changes since commit >>> 7436f5e54d35bcad53befec90e2e67288071f74e: >>> >>> Merge tag 'for-master-20190103' of git://git.denx.de/u-boot-rockchip >>> (2019-01-03 08:39:44 -0500) >>> >>> are available in the git repository at: >>> >>> git://git.denx.de/u-boot-dfu.git >>> >>> for you to fetch changes up to deb73d0aea6ca09ecb56ea3431d3151427fff4a4: >>> >>> dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 >>> 22:43:02 +0100) >>> >>> >>> Jean-Jacques Hiblot (3): >>> dm: usb: udc: Use SEQ_ALIAS to index the USB gadget ports >>> ARM: dts: define USB aliases for all omap5 platforms >>> dm: usb: gadget: Fix boot breakage on sunxi platforms >> Why is udc-uclass.c compiled in when CONFIG_(SPL_)DM is enabled ? >> This doesn't make sense, I don't want any UDC code in builds which >> enable just DM . > > It only adds the UCLASS_DRIVER definition for the USB gadget. The rest > is compiled out inside udc-uclass.c Why do we want it in unconditionally at all ? -- Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [GIT] Pull request: u-boot-dfu (04.01.2019)
On 04/01/2019 16:07, Marek Vasut wrote: On 1/4/19 8:01 AM, Lukasz Majewski wrote: Dear Marek, The following changes since commit 7436f5e54d35bcad53befec90e2e67288071f74e: Merge tag 'for-master-20190103' of git://git.denx.de/u-boot-rockchip (2019-01-03 08:39:44 -0500) are available in the git repository at: git://git.denx.de/u-boot-dfu.git for you to fetch changes up to deb73d0aea6ca09ecb56ea3431d3151427fff4a4: dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 22:43:02 +0100) Jean-Jacques Hiblot (3): dm: usb: udc: Use SEQ_ALIAS to index the USB gadget ports ARM: dts: define USB aliases for all omap5 platforms dm: usb: gadget: Fix boot breakage on sunxi platforms Why is udc-uclass.c compiled in when CONFIG_(SPL_)DM is enabled ? This doesn't make sense, I don't want any UDC code in builds which enable just DM . It only adds the UCLASS_DRIVER definition for the USB gadget. The rest is compiled out inside udc-uclass.c ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [GIT] Pull request: u-boot-dfu (04.01.2019)
On 1/4/19 8:01 AM, Lukasz Majewski wrote: > Dear Marek, > > The following changes since commit > 7436f5e54d35bcad53befec90e2e67288071f74e: > > Merge tag 'for-master-20190103' of git://git.denx.de/u-boot-rockchip > (2019-01-03 08:39:44 -0500) > > are available in the git repository at: > > git://git.denx.de/u-boot-dfu.git > > for you to fetch changes up to deb73d0aea6ca09ecb56ea3431d3151427fff4a4: > > dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 > 22:43:02 +0100) > > > Jean-Jacques Hiblot (3): > dm: usb: udc: Use SEQ_ALIAS to index the USB gadget ports > ARM: dts: define USB aliases for all omap5 platforms > dm: usb: gadget: Fix boot breakage on sunxi platforms Why is udc-uclass.c compiled in when CONFIG_(SPL_)DM is enabled ? This doesn't make sense, I don't want any UDC code in builds which enable just DM . -- Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [GIT] Pull request: u-boot-dfu (04.01.2019)
Dear Marek, The following changes since commit 7436f5e54d35bcad53befec90e2e67288071f74e: Merge tag 'for-master-20190103' of git://git.denx.de/u-boot-rockchip (2019-01-03 08:39:44 -0500) are available in the git repository at: git://git.denx.de/u-boot-dfu.git for you to fetch changes up to deb73d0aea6ca09ecb56ea3431d3151427fff4a4: dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-03 22:43:02 +0100) Jean-Jacques Hiblot (3): dm: usb: udc: Use SEQ_ALIAS to index the USB gadget ports ARM: dts: define USB aliases for all omap5 platforms dm: usb: gadget: Fix boot breakage on sunxi platforms arch/arm/dts/omap5-u-boot.dtsi | 5 + drivers/usb/gadget/udc/Makefile | 3 ++- drivers/usb/gadget/udc/udc-uclass.c | 7 +-- 3 files changed, 12 insertions(+), 3 deletions(-) Travis-Ci: https://travis-ci.org/lmajewski/u-boot-dfu/builds/475053011 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de pgpMbxKjHNBeP.pgp Description: OpenPGP digital signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
