Re: [U-Boot] [PATCH] 512x: Cleanup for partial linking and --gc-sections

2010-11-29 Thread Anatolij Gustschin
Hello Wolfgang,

On Mon, 22 Nov 2010 23:40:14 +0100
Wolfgang Denk  wrote:

> Signed-off-by: Wolfgang Denk 
> Cc: Anatolij Gustschin 
> Cc: Timur Tabi 
> ---
> 
> Hello Anatolij & Timur,
> 
> I'm not happy about the CONFIG_FSL_DIU_FB hacking I had to do in
> Makefile and arch/powerpc/cpu/mpc512x/Makefile to make the fsl_diu_fb
> driver usable for boards where VENDOR is not set or != 'freescale'.
> 
> Can we not move the fsl_diu_fb driver to a place with better global
> visibility, like drivers/video/ ?

Sorry for the late reply. Yes, we can do this. A patch follows.

Best regards,
Anatolij
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] 512x: Cleanup for partial linking and --gc-sections

2010-11-22 Thread Timur Tabi
Wolfgang Denk wrote:
> I'm not happy about the CONFIG_FSL_DIU_FB hacking I had to do in
> Makefile and arch/powerpc/cpu/mpc512x/Makefile to make the fsl_diu_fb
> driver usable for boards where VENDOR is not set or != 'freescale'.
> 
> Can we not move the fsl_diu_fb driver to a place with better global
> visibility, like drivers/video/ ?

I'm okay with that.

-- 
Timur Tabi
Linux kernel developer at Freescale

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] 512x: Cleanup for partial linking and --gc-sections

2010-11-22 Thread Wolfgang Denk
Signed-off-by: Wolfgang Denk 
Cc: Anatolij Gustschin 
Cc: Timur Tabi 
---

Hello Anatolij & Timur,

I'm not happy about the CONFIG_FSL_DIU_FB hacking I had to do in
Makefile and arch/powerpc/cpu/mpc512x/Makefile to make the fsl_diu_fb
driver usable for boards where VENDOR is not set or != 'freescale'.

Can we not move the fsl_diu_fb driver to a place with better global
visibility, like drivers/video/ ?


 Makefile|5 +++-
 arch/powerpc/cpu/mpc512x/Makefile   |1 -
 arch/powerpc/cpu/mpc512x/u-boot.lds |   51 ++
 board/freescale/common/Makefile |4 +-
 4 files changed, 15 insertions(+), 46 deletions(-)

diff --git a/Makefile b/Makefile
index b4aae89..28028dc 100644
--- a/Makefile
+++ b/Makefile
@@ -185,6 +185,9 @@ LIBS += lib/lzma/liblzma.o
 LIBS += lib/lzo/liblzo.o
 LIBS += $(shell if [ -f board/$(VENDOR)/common/Makefile ]; then echo \
"board/$(VENDOR)/common/lib$(VENDOR).o"; fi)
+ifdef CONFIG_FSL_DIU_FB
+LIBS += board/freescale/common/libfreescale.o
+endif
 LIBS += $(CPUDIR)/lib$(CPU).o
 ifdef SOC
 LIBS += $(CPUDIR)/$(SOC)/lib$(SOC).o
@@ -260,7 +263,7 @@ ifeq ($(SOC),s5pc2xx)
 LIBS += $(CPUDIR)/s5p-common/libs5p-common.o
 endif
 
-LIBS := $(addprefix $(obj),$(LIBS))
+LIBS := $(addprefix $(obj),$(sort $(LIBS)))
 .PHONY : $(LIBS) $(TIMESTAMP_FILE) $(VERSION_FILE)
 
 LIBBOARD = board/$(BOARDDIR)/lib$(BOARD).o
diff --git a/arch/powerpc/cpu/mpc512x/Makefile 
b/arch/powerpc/cpu/mpc512x/Makefile
index cb1263a..4a4bc0d 100644
--- a/arch/powerpc/cpu/mpc512x/Makefile
+++ b/arch/powerpc/cpu/mpc512x/Makefile
@@ -37,7 +37,6 @@ COBJS-y += iopin.o
 COBJS-y += serial.o
 COBJS-y += speed.o
 COBJS-$(CONFIG_FSL_DIU_FB) += diu.o
-COBJS-$(CONFIG_FSL_DIU_FB) += ../../../../board/freescale/common/fsl_diu_fb.o
 COBJS-$(CONFIG_CMD_IDE) += ide.o
 COBJS-$(CONFIG_IIM) += iim.o
 COBJS-$(CONFIG_PCI) += pci.o
diff --git a/arch/powerpc/cpu/mpc512x/u-boot.lds 
b/arch/powerpc/cpu/mpc512x/u-boot.lds
index c716799..6b292a1 100644
--- a/arch/powerpc/cpu/mpc512x/u-boot.lds
+++ b/arch/powerpc/cpu/mpc512x/u-boot.lds
@@ -23,42 +23,13 @@
 OUTPUT_ARCH(powerpc)
 SECTIONS
 {
-  /* Read-only sections, merged into text segment: */
-  . = + SIZEOF_HEADERS;
-  .interp : { *(.interp) }
-  .hash  : { *(.hash)  }
-  .dynsym: { *(.dynsym)}
-  .dynstr: { *(.dynstr)}
-  .rel.text  : { *(.rel.text)  }
-  .rela.text : { *(.rela.text) }
-  .rel.data  : { *(.rel.data)  }
-  .rela.data : { *(.rela.data) }
-  .rel.rodata: { *(.rel.rodata)}
-  .rela.rodata   : { *(.rela.rodata)   }
-  .rel.got   : { *(.rel.got)   }
-  .rela.got  : { *(.rela.got)  }
-  .rel.ctors : { *(.rel.ctors) }
-  .rela.ctors: { *(.rela.ctors)}
-  .rel.dtors : { *(.rel.dtors) }
-  .rela.dtors: { *(.rela.dtors)}
-  .rel.bss   : { *(.rel.bss)   }
-  .rela.bss  : { *(.rela.bss)  }
-  .rel.plt   : { *(.rel.plt)   }
-  .rela.plt  : { *(.rela.plt)  }
-  .init  : { *(.init)  }
-  .plt : { *(.plt) }
   .text  :
   {
-arch/powerpc/cpu/mpc512x/start.o   (.text)
-*(.text)
-*(.got1)
+arch/powerpc/cpu/mpc512x/start.o   (.text*)
+*(.text*)
 . = ALIGN(16);
-*(.eh_frame)
 *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))
   }
-  .fini  : { *(.fini)} =0
-  .ctors : { *(.ctors)   }
-  .dtors : { *(.dtors)   }
 
   /* Read-write section, merged into data segment: */
   . = (. + 0x0FFF) & 0xF000;
@@ -66,10 +37,11 @@ SECTIONS
   PROVIDE (erotext = .);
   .reloc   :
   {
-*(.got)
+KEEP(*(.got))
 _GOT2_TABLE_ = .;
-*(.got2)
+KEEP(*(.got2))
 _FIXUP_TABLE_ = .;
+KEEP(*(.fixup))
 *(.fixup)
   }
   __got2_entries = (_FIXUP_TABLE_ - _GOT2_TABLE_) >> 2;
@@ -77,12 +49,8 @@ SECTIONS
 
   .data:
   {
-*(.data)
-*(.data1)
-*(.sdata)
-*(.sdata2)
-*(.dynamic)
-CONSTRUCTORS
+*(.data*)
+*(.sdata*)
   }
   _edata  =  .;
   PROVIDE (edata = .);
@@ -108,9 +76,8 @@ SECTIONS
   __bss_start = .;
   .bss (NOLOAD)   :
   {
-   *(.sbss) *(.scommon)
-   *(.dynbss)
-   *(.bss)
+   *(.bss*)
+   *(.sbss*)
*(COMMON)
. = ALIGN(4);
   }
diff --git a/board/freescale/common/Makefile b/board/freescale/common/Makefile
index 703a347..905dd7a 100644
--- a/board/freescale/common/Makefile
+++ b/board/freescale/common/Makefile
@@ -24,10 +24,10 @@
 include $(TOPDIR)/config.mk
 
 ifneq ($(OBJTREE),$(SRCTREE))
-$(shell mkdir -p $(obj)board/$(VENDOR)/common)
+$(shell mkdir -p $(obj)board/freescale/common)
 endif
 
-LIB= $(obj)lib$(VENDOR).o
+LIB= $(obj)libfreescale.o
 
 COBJS-$(CONFIG_FSL_CADMUS) += cadmus.o
 COBJS-$(CONFIG_FSL_VIA)+= cds_via.o
-- 
1.7.3.2

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/l