Re: [U-Boot] [PATCH] ARM: Don't grab memory for LCD if FB address is defined

[Wolfgang Denk]

Dear Minkyu Kang,

In message <4d6f5611.40...@samsung.com> you wrote:
> If FB address is defined as specific address then don't grab memory for LCD
> 
> Signed-off-by: Minkyu Kang 
> ---
>  arch/arm/lib/board.c |4 
>  1 files changed, 4 insertions(+), 0 deletions(-)

Sorry, but NAK.

You cannot make this change for ARM only.  It needs to be implemented
for all architectures.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
There comes to all races an ultimate crisis which  you  have  yet  to
face    One  day  our  minds became so powerful we dared think of
ourselves as gods.
-- Sargon, "Return to Tomorrow", stardate 4768.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] ARM: Don't grab memory for LCD if FB address is defined

[Minkyu Kang]

If FB address is defined as specific address then don't grab memory for LCD

Signed-off-by: Minkyu Kang 
---
 arch/arm/lib/board.c |4 
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
index c620d2c..5a4d2bd 100644
--- a/arch/arm/lib/board.c
+++ b/arch/arm/lib/board.c
@@ -356,9 +356,13 @@ void board_init_f (ulong bootflag)
 #endif /* CONFIG_VFD */
 
 #ifdef CONFIG_LCD
+#ifdef CONFIG_FB_ADDR
+   gd->fb_base = CONFIG_FB_ADDR;
+#else
/* reserve memory for LCD display (always full pages) */
addr = lcd_setmem (addr);
gd->fb_base = addr;
+#endif /* CONFIG_FB_ADDR */
 #endif /* CONFIG_LCD */
 
/*
-- 
1.7.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot