Re: [U-Boot] [PATCH] ARM: rockchip: rock: Correct test to use CONFIG_IS_ENABLED not defined

[Tom Rini]

On Mon, Aug 14, 2017 at 01:24:48PM -0400, Tom Rini wrote:

> While it is likely that this entire case is superfluous and can be
> removed, correct the test now to match what is in rockchip-common.h and
> makes sense based on context of the code.  Otherwise we get a large
> number of warnings.
> 
> Reviewed-by: Philipp Tomsich 
> Signed-off-by: Tom Rini 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] ARM: rockchip: rock: Correct test to use CONFIG_IS_ENABLED not defined

[Dr. Philipp Tomsich]

> On 14 Aug 2017, at 19:24, Tom Rini  wrote:
> 
> While it is likely that this entire case is superfluous and can be
> removed, correct the test now to match what is in rockchip-common.h and
> makes sense based on context of the code.  Otherwise we get a large
> number of warnings.
> 
> Cc: hilipp Tomsich 
> Signed-off-by: Tom Rini 

Reviewed-by: Philipp Tomsich < philipp.toms...@theobroma-systems.com>

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] ARM: rockchip: rock: Correct test to use CONFIG_IS_ENABLED not defined

[Tom Rini]

While it is likely that this entire case is superfluous and can be
removed, correct the test now to match what is in rockchip-common.h and
makes sense based on context of the code.  Otherwise we get a large
number of warnings.

Cc: hilipp Tomsich 
Signed-off-by: Tom Rini 
---
 include/configs/rock.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/rock.h b/include/configs/rock.h
index 6b0788be9db5..8d845d95e378 100644
--- a/include/configs/rock.h
+++ b/include/configs/rock.h
@@ -12,7 +12,7 @@
 
 #define CONFIG_SYS_MMC_ENV_DEV 0
 
-#if defined(ROCKCHIP_BACK_TO_BROM)
+#if CONFIG_IS_ENABLED(ROCKCHIP_BACK_TO_BROM)
 /* SPL @ 32k for 34k
  * u-boot directly after @ 68k for 400k or so
  * ENV @ 992k
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot