Re: [U-Boot] [PATCH] Kconfig: Add support for hash and sha1sum commands

2017-05-23 Thread Daniel Thompson 

On 22/05/17 22:17, Tom Rini wrote:

On Mon, May 22, 2017 at 02:26:57PM -0600, Simon Glass wrote:

Hi Daniel,

On 19 May 2017 at 10:26, Daniel Thompson  wrote:

Currently these (board agnostic) commands cannot be selected using
menuconfig and friends. Fix this the obvious way.

Signed-off-by: Daniel Thompson 
---
  cmd/Kconfig | 27 +++
  1 file changed, 27 insertions(+)


Great to see this. However CMD_HASH is already in progress at
u-boot-dm/kconfig-working. I hope it will make it to mainline soon.
But in the meantime could you please  rebase on that and send v2?


Since this needs moveconfig.py run as well, I'll just v2 it, thanks!


Does that translate into "Daniel, don't worry about the rebase there are 
other things that I'd need to change as well and its quicker and easier 
for me just to do them".


I totally happy with that translation but just want to check it's correct.


Daniel.

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] Kconfig: Add support for hash and sha1sum commands

2017-05-22 Thread Tom Rini 
On Mon, May 22, 2017 at 02:26:57PM -0600, Simon Glass wrote:
> Hi Daniel,
> 
> On 19 May 2017 at 10:26, Daniel Thompson  wrote:
> > Currently these (board agnostic) commands cannot be selected using
> > menuconfig and friends. Fix this the obvious way.
> >
> > Signed-off-by: Daniel Thompson 
> > ---
> >  cmd/Kconfig | 27 +++
> >  1 file changed, 27 insertions(+)
> 
> Great to see this. However CMD_HASH is already in progress at
> u-boot-dm/kconfig-working. I hope it will make it to mainline soon.
> But in the meantime could you please  rebase on that and send v2?

Since this needs moveconfig.py run as well, I'll just v2 it, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] Kconfig: Add support for hash and sha1sum commands

2017-05-22 Thread Simon Glass 
Hi Daniel,

On 19 May 2017 at 10:26, Daniel Thompson  wrote:
> Currently these (board agnostic) commands cannot be selected using
> menuconfig and friends. Fix this the obvious way.
>
> Signed-off-by: Daniel Thompson 
> ---
>  cmd/Kconfig | 27 +++
>  1 file changed, 27 insertions(+)

Great to see this. However CMD_HASH is already in progress at
u-boot-dm/kconfig-working. I hope it will make it to mainline soon.
But in the meantime could you please  rebase on that and send v2?

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] Kconfig: Add support for hash and sha1sum commands

2017-05-19 Thread Daniel Thompson 
Currently these (board agnostic) commands cannot be selected using
menuconfig and friends. Fix this the obvious way.

Signed-off-by: Daniel Thompson 
---
 cmd/Kconfig | 27 +++
 1 file changed, 27 insertions(+)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index d9f7151bacdc..f459f8440346 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -338,6 +338,19 @@ config CMD_CRC32
help
  Compute CRC32.

+config CMD_HASH
+   bool "hash"
+   default n
+   help
+ Compute a hash using any algorithm supported by hash_lookup_algo().
+
+config HASH_VERIFY
+   bool "hash -v"
+   default n
+   depends on CMD_HASH
+   help
+ Add -v option to verify data against a hash.
+
 config CMD_MD5SUM
bool "md5sum"
default n
@@ -352,6 +365,20 @@ config MD5SUM_VERFIY
help
  Add -v option to verify data against an MD5 checksum.

+config CMD_SHA1SUM
+   bool "sha1sum"
+   default n
+   select SHA1
+   help
+ Compute SHA1 checksum.
+
+config SHA1SUM_VERFIY
+   bool "sha1sum -v"
+   default n
+   depends on CMD_SHA1SUM
+   help
+ Add -v option to verify data against an SHA1 checksum.
+
 config LOOPW
bool "loopw"
help
--
2.9.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot