Re: [U-Boot] [PATCH] OMAP3: Overo: Update GPMC timing for ethernet chip.

2011-09-08 Thread Enric Balletbò i Serra 
2011/9/8 Philip Balister :
> On 09/08/2011 10:45 AM, Enric Balletbò i Serra wrote:
>>
>> 2011/9/8 Steve Sakoman:
>>>
>>> On Wed, Sep 7, 2011 at 4:57 AM, Philip Balister
>>>  wrote:

 The existing timing does not quite meet the minimum requirements
 in the LAN9221 datasheet. The timing in this patch solves problems
 noticed on some parts.

 Signed-off-by: Philip Balister
>>>
>>> Acked-by: Steve Sakoman
>>> Tested-by: Steve Sakoman
>>>
 ---
  board/overo/overo.h |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)

 diff --git a/board/overo/overo.h b/board/overo/overo.h
 index 68e1243..617c0c3 100644
 --- a/board/overo/overo.h
 +++ b/board/overo/overo.h
 @@ -35,10 +35,10 @@ const omap3_sysinfo sysinfo = {

  /* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
  #define NET_LAN9221_GPMC_CONFIG1    0x1000
 -#define NET_LAN9221_GPMC_CONFIG2    0x00080701
 +#define NET_LAN9221_GPMC_CONFIG2    0x00060700
  #define NET_LAN9221_GPMC_CONFIG3    0x00020201
 -#define NET_LAN9221_GPMC_CONFIG4    0x08030703
 -#define NET_LAN9221_GPMC_CONFIG5    0x00060908
 +#define NET_LAN9221_GPMC_CONFIG4    0x06000700
 +#define NET_LAN9221_GPMC_CONFIG5    0x0006090A
  #define NET_LAN9221_GPMC_CONFIG6    0x8703
  #define NET_LAN9221_GPMC_CONFIG7    0x0f6c

 --
 1.7.4.4

 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot

>>> ___
>>> U-Boot mailing list
>>> U-Boot@lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>>>
>>
>> Other boards like IGEP v2 board uses the same LAN9221 ethernet
>> controller, so this code is duplicated on overo.h and igep0020.h
>> files. Maybe could be a good idea move this part to
>> arch/arm/include/asm/arch-omap3/omap_gpmc.h or another file to not
>> duplicate the code.
>
> Is there anyone around with an igep v2 board who could test/ack such a
> patch?
>
> Philip
>

Yes, I can, I expect test the patch tomorrow ...

  Enric
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] OMAP3: Overo: Update GPMC timing for ethernet chip.

2011-09-08 Thread Philip Balister 
On 09/08/2011 10:45 AM, Enric Balletbò i Serra wrote:
> 2011/9/8 Steve Sakoman:
>> On Wed, Sep 7, 2011 at 4:57 AM, Philip Balister  wrote:
>>> The existing timing does not quite meet the minimum requirements
>>> in the LAN9221 datasheet. The timing in this patch solves problems
>>> noticed on some parts.
>>>
>>> Signed-off-by: Philip Balister
>>
>> Acked-by: Steve Sakoman
>> Tested-by: Steve Sakoman
>>
>>> ---
>>>   board/overo/overo.h |6 +++---
>>>   1 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/board/overo/overo.h b/board/overo/overo.h
>>> index 68e1243..617c0c3 100644
>>> --- a/board/overo/overo.h
>>> +++ b/board/overo/overo.h
>>> @@ -35,10 +35,10 @@ const omap3_sysinfo sysinfo = {
>>>
>>>   /* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>>>   #define NET_LAN9221_GPMC_CONFIG10x1000
>>> -#define NET_LAN9221_GPMC_CONFIG20x00080701
>>> +#define NET_LAN9221_GPMC_CONFIG20x00060700
>>>   #define NET_LAN9221_GPMC_CONFIG30x00020201
>>> -#define NET_LAN9221_GPMC_CONFIG40x08030703
>>> -#define NET_LAN9221_GPMC_CONFIG50x00060908
>>> +#define NET_LAN9221_GPMC_CONFIG40x06000700
>>> +#define NET_LAN9221_GPMC_CONFIG50x0006090A
>>>   #define NET_LAN9221_GPMC_CONFIG60x8703
>>>   #define NET_LAN9221_GPMC_CONFIG70x0f6c
>>>
>>> --
>>> 1.7.4.4
>>>
>>> ___
>>> U-Boot mailing list
>>> U-Boot@lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>>>
>> ___
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>
> Other boards like IGEP v2 board uses the same LAN9221 ethernet
> controller, so this code is duplicated on overo.h and igep0020.h
> files. Maybe could be a good idea move this part to
> arch/arm/include/asm/arch-omap3/omap_gpmc.h or another file to not
> duplicate the code.

Is there anyone around with an igep v2 board who could test/ack such a 
patch?

Philip
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] OMAP3: Overo: Update GPMC timing for ethernet chip.

2011-09-08 Thread Enric Balletbò i Serra 
2011/9/8 Steve Sakoman :
> On Wed, Sep 7, 2011 at 4:57 AM, Philip Balister  wrote:
>> The existing timing does not quite meet the minimum requirements
>> in the LAN9221 datasheet. The timing in this patch solves problems
>> noticed on some parts.
>>
>> Signed-off-by: Philip Balister 
>
> Acked-by: Steve Sakoman 
> Tested-by: Steve Sakoman 
>
>> ---
>>  board/overo/overo.h |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/board/overo/overo.h b/board/overo/overo.h
>> index 68e1243..617c0c3 100644
>> --- a/board/overo/overo.h
>> +++ b/board/overo/overo.h
>> @@ -35,10 +35,10 @@ const omap3_sysinfo sysinfo = {
>>
>>  /* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>>  #define NET_LAN9221_GPMC_CONFIG1    0x1000
>> -#define NET_LAN9221_GPMC_CONFIG2    0x00080701
>> +#define NET_LAN9221_GPMC_CONFIG2    0x00060700
>>  #define NET_LAN9221_GPMC_CONFIG3    0x00020201
>> -#define NET_LAN9221_GPMC_CONFIG4    0x08030703
>> -#define NET_LAN9221_GPMC_CONFIG5    0x00060908
>> +#define NET_LAN9221_GPMC_CONFIG4    0x06000700
>> +#define NET_LAN9221_GPMC_CONFIG5    0x0006090A
>>  #define NET_LAN9221_GPMC_CONFIG6    0x8703
>>  #define NET_LAN9221_GPMC_CONFIG7    0x0f6c
>>
>> --
>> 1.7.4.4
>>
>> ___
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

Other boards like IGEP v2 board uses the same LAN9221 ethernet
controller, so this code is duplicated on overo.h and igep0020.h
files. Maybe could be a good idea move this part to
arch/arm/include/asm/arch-omap3/omap_gpmc.h or another file to not
duplicate the code.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] OMAP3: Overo: Update GPMC timing for ethernet chip.

2011-09-08 Thread Steve Sakoman 
On Wed, Sep 7, 2011 at 4:57 AM, Philip Balister  wrote:
> The existing timing does not quite meet the minimum requirements
> in the LAN9221 datasheet. The timing in this patch solves problems
> noticed on some parts.
>
> Signed-off-by: Philip Balister 

Acked-by: Steve Sakoman 
Tested-by: Steve Sakoman 

> ---
>  board/overo/overo.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/board/overo/overo.h b/board/overo/overo.h
> index 68e1243..617c0c3 100644
> --- a/board/overo/overo.h
> +++ b/board/overo/overo.h
> @@ -35,10 +35,10 @@ const omap3_sysinfo sysinfo = {
>
>  /* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>  #define NET_LAN9221_GPMC_CONFIG1    0x1000
> -#define NET_LAN9221_GPMC_CONFIG2    0x00080701
> +#define NET_LAN9221_GPMC_CONFIG2    0x00060700
>  #define NET_LAN9221_GPMC_CONFIG3    0x00020201
> -#define NET_LAN9221_GPMC_CONFIG4    0x08030703
> -#define NET_LAN9221_GPMC_CONFIG5    0x00060908
> +#define NET_LAN9221_GPMC_CONFIG4    0x06000700
> +#define NET_LAN9221_GPMC_CONFIG5    0x0006090A
>  #define NET_LAN9221_GPMC_CONFIG6    0x8703
>  #define NET_LAN9221_GPMC_CONFIG7    0x0f6c
>
> --
> 1.7.4.4
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] OMAP3: Overo: Update GPMC timing for ethernet chip.

2011-09-07 Thread Philip Balister 
The existing timing does not quite meet the minimum requirements
in the LAN9221 datasheet. The timing in this patch solves problems
noticed on some parts.

Signed-off-by: Philip Balister 
---
 board/overo/overo.h |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/board/overo/overo.h b/board/overo/overo.h
index 68e1243..617c0c3 100644
--- a/board/overo/overo.h
+++ b/board/overo/overo.h
@@ -35,10 +35,10 @@ const omap3_sysinfo sysinfo = {
 
 /* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
 #define NET_LAN9221_GPMC_CONFIG10x1000
-#define NET_LAN9221_GPMC_CONFIG20x00080701
+#define NET_LAN9221_GPMC_CONFIG20x00060700
 #define NET_LAN9221_GPMC_CONFIG30x00020201
-#define NET_LAN9221_GPMC_CONFIG40x08030703
-#define NET_LAN9221_GPMC_CONFIG50x00060908
+#define NET_LAN9221_GPMC_CONFIG40x06000700
+#define NET_LAN9221_GPMC_CONFIG50x0006090A
 #define NET_LAN9221_GPMC_CONFIG60x8703
 #define NET_LAN9221_GPMC_CONFIG70x0f6c
 
-- 
1.7.4.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot