Re: [U-Boot] [PATCH] V3 Add support for the galaxy5200

2009-08-13 Thread Peter Tyser
The title should be "[PATCH V3] ...", not "[PATCH] V3 ...".

On Thu, 2009-08-13 at 08:13 -0500, Eric Millbrandt wrote:
> Removed trailing whitespace introduced in V2 to conform with U-Boot coding 
> style.
> Defined additional chip select region.

This should all go below the "---" below.

> Signed-off-by: Eric Millbrandt 
> ---

Comments that shouldn't be committed go here.

>  MAINTAINERS   |4 +
>  MAKEALL   |1 +
>  Makefile  |6 +
>  board/galaxy5200/Makefile |   50 +
>  board/galaxy5200/config.mk|   45 +
>  board/galaxy5200/galaxy5200.c |  199 +++
>  include/configs/galaxy5200.h  |  428 
> +
>  7 files changed, 733 insertions(+), 0 deletions(-)
>  create mode 100644 board/galaxy5200/Makefile
>  create mode 100644 board/galaxy5200/config.mk
>  create mode 100644 board/galaxy5200/galaxy5200.c
>  create mode 100644 include/configs/galaxy5200.h

To be explicit, your patch should look like this:


[PATCH V4] Add support for the galaxy5200

Add support for the DEKA Research and Development galaxy5200 board



Signed-off-by: Eric Millbrandt 
---

Changes since v1:
- Amended with comments from Wolfgang
- Make change to top level makefile per Wolfgang's suggestion.

Changes since v2:
- Defined additional chip select region.

Changes since v3:
- Fixed up patch title and commit message per Peter's suggestion.

 MAINTAINERS   |4 +
 MAKEALL   |1 +
 Makefile  |6 +
 board/galaxy5200/Makefile |   50 +
 board/galaxy5200/config.mk|   45 +
 board/galaxy5200/galaxy5200.c |  199 +++
 include/configs/galaxy5200.h  |  428
+
 7 files changed, 733 insertions(+), 0 deletions(-)
 create mode 100644 board/galaxy5200/Makefile
 create mode 100644 board/galaxy5200/config.mk
 create mode 100644 board/galaxy5200/galaxy5200.c
 create mode 100644 include/configs/galaxy5200.h

...

Best,
Peter

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] V3 Add support for the galaxy5200

2009-08-13 Thread Eric Millbrandt
Removed trailing whitespace introduced in V2 to conform with U-Boot coding 
style.
Defined additional chip select region.

Signed-off-by: Eric Millbrandt 
---
 MAINTAINERS   |4 +
 MAKEALL   |1 +
 Makefile  |6 +
 board/galaxy5200/Makefile |   50 +
 board/galaxy5200/config.mk|   45 +
 board/galaxy5200/galaxy5200.c |  199 +++
 include/configs/galaxy5200.h  |  428 +
 7 files changed, 733 insertions(+), 0 deletions(-)
 create mode 100644 board/galaxy5200/Makefile
 create mode 100644 board/galaxy5200/config.mk
 create mode 100644 board/galaxy5200/galaxy5200.c
 create mode 100644 include/configs/galaxy5200.h

diff --git a/MAINTAINERS b/MAINTAINERS
index 620604c..85ba8d2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -616,6 +616,10 @@ David M
smdk2410ARM920T
VCMA9   ARM920T
 
+Eric Millbrandt 
+
+   galaxy5200  mpc5200
+
 Rolf Offermanns 
 
shannon SA1100
diff --git a/MAKEALL b/MAKEALL
index edebaea..65cd6d0 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -50,6 +50,7 @@ LIST_5xxx="   \
digsy_mtc   \
EVAL5200\
fo300   \
+   galaxy5200  \
icecube_5100\
icecube_5200\
inka4x0 \
diff --git a/Makefile b/Makefile
index 329e0f5..569549c 100644
--- a/Makefile
+++ b/Makefile
@@ -531,6 +531,12 @@ digsy_mtc_RAMBOOT_config:  unconfig
}
@$(MKCONFIG) -a digsy_mtc  ppc mpc5xxx digsy_mtc
 
+galaxy5200_LOWBOOT_config \
+galaxy5200_config: unconfig
+   @mkdir -p $(obj)include
+   @echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h
+   @$(MKCONFIG) -a galaxy5200 ppc mpc5xxx galaxy5200
+
 hmi1001_config:unconfig
@$(MKCONFIG) hmi1001 ppc mpc5xxx hmi1001
 
diff --git a/board/galaxy5200/Makefile b/board/galaxy5200/Makefile
new file mode 100644
index 000..22ce8e6
--- /dev/null
+++ b/board/galaxy5200/Makefile
@@ -0,0 +1,50 @@
+#
+# (C) Copyright 2003-2007
+# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB= $(obj)lib$(BOARD).a
+
+COBJS  := $(BOARD).o
+
+SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS   := $(addprefix $(obj),$(COBJS))
+SOBJS  := $(addprefix $(obj),$(SOBJS))
+
+$(LIB):$(obj).depend $(OBJS)
+   $(AR) $(ARFLAGS) $@ $(OBJS)
+
+clean:
+   rm -f $(SOBJS) $(OBJS)
+
+distclean: clean
+   rm -f $(LIB) core *.bak $(obj).depend
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#
diff --git a/board/galaxy5200/config.mk b/board/galaxy5200/config.mk
new file mode 100644
index 000..c6398b2
--- /dev/null
+++ b/board/galaxy5200/config.mk
@@ -0,0 +1,45 @@
+#
+# (C) Copyright 2003
+# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+#
+# galaxy5200 board:
+#
+#  Valid values for TEXT_BASE are:
+#
+#  0xFFF0   boot high (standard configuration)
+#  0xFE00   boot low
+#  0x0010   boot from RAM (for testing only) does not work
+#
+
+sinclude $(TOPDIR)/board/$(BOARDDIR)/config.tmp
+
+ifdef CONFIG_galaxy5200_LOWBOOT
+TEXT_BASE = 0xFE000