Re: [U-Boot] [PATCH] add missing space
On Fri, Dec 16, 2011 at 10:59:03AM -0500, Mike Frysinger wrote: On Friday 16 December 2011 07:13:47 Anatolij Gustschin wrote: On Fri, 16 Dec 2011 00:32:15 +0100 Luka Perkov wrote: Cosmetic patch for first U-Boot line that gets printed. --- a/include/version.h +++ b/include/version.h #define U_BOOT_VERSION_STRING U_BOOT_VERSION ( U_BOOT_DATE - \ - U_BOOT_TIME ) CONFIG_IDENT_STRING + U_BOOT_TIME ) CONFIG_IDENT_STRING This change is not needed I think. Most boards defining CONFIG_IDENT_STRING use either a string starting with new line or strings like something. So this patch will deface version string. Your CONFIG_IDENT_STRING should be fixed instead. +1 -mike Ok, thanks for pointing this out. I guess that something like patch bellow is not acceptable? # grep CONFIG_IDENT_STRING * -r | grep ' ' | wc -l 41 Bye, Luka diff --git a/include/configs/GEN860T.h b/include/configs/GEN860T.h index 68a0cfd..01e5b93 100644 --- a/include/configs/GEN860T.h +++ b/include/configs/GEN860T.h @@ -41,9 +41,9 @@ * Identify the board */ #if !defined(CONFIG_SC) -#define CONFIG_IDENT_STRING B2 +#define CONFIG_IDENT_STRINGB2 #else -#define CONFIG_IDENT_STRING SC +#define CONFIG_IDENT_STRINGSC #endif /* diff --git a/include/configs/IVML24.h b/include/configs/IVML24.h index b827954..7d8d2e0 100644 --- a/include/configs/IVML24.h +++ b/include/configs/IVML24.h @@ -39,11 +39,11 @@ #defineCONFIG_SYS_TEXT_BASE0xFF00 #if defined (CONFIG_IVML24_16M) -# define CONFIG_IDENT_STRING IVML24 +# define CONFIG_IDENT_STRING IVML24 #elif defined (CONFIG_IVML24_32M) -# define CONFIG_IDENT_STRING IVML24_128 +# define CONFIG_IDENT_STRING IVML24_128 #elif defined (CONFIG_IVML24_64M) -# define CONFIG_IDENT_STRING IVML24_256 +# define CONFIG_IDENT_STRING IVML24_256 #endif #defineCONFIG_8xx_CONS_SMC11 /* Console is on SMC1 */ diff --git a/include/configs/IVMS8.h b/include/configs/IVMS8.h index 9b0c32a..9a3b258 100644 --- a/include/configs/IVMS8.h +++ b/include/configs/IVMS8.h @@ -39,11 +39,11 @@ #defineCONFIG_SYS_TEXT_BASE0xFF00 #if defined (CONFIG_IVMS8_16M) -# define CONFIG_IDENT_STRING IVMS8 +# define CONFIG_IDENT_STRING IVMS8 #elif defined (CONFIG_IVMS8_32M) -# define CONFIG_IDENT_STRING IVMS8_128 +# define CONFIG_IDENT_STRING IVMS8_128 #elif defined (CONFIG_IVMS8_64M) -# define CONFIG_IDENT_STRING IVMS8_256 +# define CONFIG_IDENT_STRING IVMS8_256 #endif #defineCONFIG_8xx_CONS_SMC11 /* Console is on SMC1 */ diff --git a/include/configs/KAREF.h b/include/configs/KAREF.h index 06fa676..d46c2ad 100644 --- a/include/configs/KAREF.h +++ b/include/configs/KAREF.h @@ -52,7 +52,7 @@ #define CONFIG_VERY_BIG_RAM 1 #define CONFIG_VERSION_VARIABLE -#define CONFIG_IDENT_STRING Sandburst Kamino Reference Design +#define CONFIG_IDENT_STRING Sandburst Kamino Reference Design /*--- * Base addresses -- Note these are effective addresses where the diff --git a/include/configs/METROBOX.h b/include/configs/METROBOX.h index c75a256..9e9eb31 100644 --- a/include/configs/METROBOX.h +++ b/include/configs/METROBOX.h @@ -118,7 +118,7 @@ #define CONFIG_VERY_BIG_RAM 1 #define CONFIG_VERSION_VARIABLE -#define CONFIG_IDENT_STRING Sandburst Metrobox +#define CONFIG_IDENT_STRING Sandburst Metrobox /*--- * Base addresses -- Note these are effective addresses where the diff --git a/include/configs/TOP860.h b/include/configs/TOP860.h index 3a01292..15a726e 100644 --- a/include/configs/TOP860.h +++ b/include/configs/TOP860.h @@ -57,7 +57,7 @@ #defineCONFIG_SYS_TEXT_BASE0x8000 #undef CONFIG_WATCHDOG /* watchdog disabled*/ -#defineCONFIG_IDENT_STRING EMK TOP860 +#defineCONFIG_IDENT_STRING EMK TOP860 /*--- * CLOCK settings diff --git a/include/configs/WUH405.h b/include/configs/WUH405.h index 504ad96..21cae7c 100644 --- a/include/configs/WUH405.h +++ b/include/configs/WUH405.h @@ -32,7 +32,7 @@ * High Level Configuration Options * (easy to change) */ -#define CONFIG_IDENT_STRING $Name: $ +#define CONFIG_IDENT_STRING $Name: $ #define CONFIG_405EP 1 /* This is a PPC405 CPU */ #define CONFIG_4xx 1 /* ...member of PPC4xx family */ diff --git a/include/configs/dlvision-10g.h b/include/configs/dlvision-10g.h index 1468197..e069b60 100644 --- a/include/configs/dlvision-10g.h +++ b/include/configs/dlvision-10g.h @@ -34,7 +34,7 @@ * Include common defines/options for all AMCC eval boards */ #define CONFIG_HOSTNAMEdlvsion-10g -#define CONFIG_IDENT_STRING
Re: [U-Boot] [PATCH] add missing space
Dear Luka Perkov, In message 20111216234317.GB1393@w500.iskon.local you wrote: Ok, thanks for pointing this out. I guess that something like patch bellow is not acceptable? acceptable is somethign that is a bit hard to define. Let's say, there is no real incentive to apply this patch. Instead of leaving all formatting options open to the end user (including the option to directoy attach his custom string to the standard output) this would dictate that there always has to be a space, and even boards which do not want to use a custom sting would output the space. Sorry, this makes no sense to me. I'm not going to accept this. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The price of curiosity is a terminal experience. - Terry Pratchett, _The Dark Side of the Sun_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add missing space
Hi Luka, On Fri, 16 Dec 2011 00:32:15 +0100 Luka Perkov li...@lukaperkov.net wrote: Cosmetic patch for first U-Boot line that gets printed. Signed-off-by: Luka Perkov li...@lukaperkov.net --- diff --git a/include/version.h b/include/version.h index c908bd3..ac5a39a 100644 --- a/include/version.h +++ b/include/version.h @@ -35,7 +35,7 @@ #endif #define U_BOOT_VERSION_STRING U_BOOT_VERSION ( U_BOOT_DATE - \ - U_BOOT_TIME ) CONFIG_IDENT_STRING + U_BOOT_TIME ) CONFIG_IDENT_STRING This change is not needed I think. Most boards defining CONFIG_IDENT_STRING use either a string starting with new line or strings like something. So this patch will deface version string. Your CONFIG_IDENT_STRING should be fixed instead. Thanks, Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add missing space
On Friday 16 December 2011 07:13:47 Anatolij Gustschin wrote: On Fri, 16 Dec 2011 00:32:15 +0100 Luka Perkov wrote: Cosmetic patch for first U-Boot line that gets printed. --- a/include/version.h +++ b/include/version.h #define U_BOOT_VERSION_STRING U_BOOT_VERSION ( U_BOOT_DATE - \ - U_BOOT_TIME ) CONFIG_IDENT_STRING + U_BOOT_TIME ) CONFIG_IDENT_STRING This change is not needed I think. Most boards defining CONFIG_IDENT_STRING use either a string starting with new line or strings like something. So this patch will deface version string. Your CONFIG_IDENT_STRING should be fixed instead. +1 -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add missing space
On Friday 16 December 2011 18:43:18 Luka Perkov wrote: On Fri, Dec 16, 2011 at 10:59:03AM -0500, Mike Frysinger wrote: On Friday 16 December 2011 07:13:47 Anatolij Gustschin wrote: On Fri, 16 Dec 2011 00:32:15 +0100 Luka Perkov wrote: Cosmetic patch for first U-Boot line that gets printed. --- a/include/version.h +++ b/include/version.h #define U_BOOT_VERSION_STRING U_BOOT_VERSION ( U_BOOT_DATE - \ - U_BOOT_TIME ) CONFIG_IDENT_STRING + U_BOOT_TIME ) CONFIG_IDENT_STRING This change is not needed I think. Most boards defining CONFIG_IDENT_STRING use either a string starting with new line or strings like something. So this patch will deface version string. Your CONFIG_IDENT_STRING should be fixed instead. +1 -mike Ok, thanks for pointing this out. I guess that something like patch bellow is not acceptable? no, because you're adding a useless space for everyone who doesn't define CONFIG_IDENT_STRING :) -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] add missing space
Cosmetic patch for first U-Boot line that gets printed. Signed-off-by: Luka Perkov li...@lukaperkov.net --- diff --git a/include/version.h b/include/version.h index c908bd3..ac5a39a 100644 --- a/include/version.h +++ b/include/version.h @@ -35,7 +35,7 @@ #endif #define U_BOOT_VERSION_STRING U_BOOT_VERSION ( U_BOOT_DATE - \ - U_BOOT_TIME ) CONFIG_IDENT_STRING + U_BOOT_TIME ) CONFIG_IDENT_STRING #ifndef __ASSEMBLY__ extern const char version_string[]; ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
