Re: [U-Boot] [PATCH] arm, post, memory: fix bug if sdram base != 0x00000000

2011-10-23 Thread Wolfgang Denk 
Dear Heiko Schocher,

In message 1317969600-32496-1-git-send-email...@denx.de you wrote:
 commit 8d3fcb5e60b6c8e1d530dbc2e2e33ec6a44670da breaks post
 memory support for sdram base != 0x. Fix this.
 
 Signed-off-by: Heiko Schocher h...@denx.de
 Cc: Valentin Longchamp valentin.longch...@keymile.com
 Cc: Holger Brunck holger.bru...@keymile.com
 ---
 $ /home/git/linux-denx/scripts/checkpatch.pl 
 0001-arm-post-memory-fix-bug-if-sdram-base-0x.patch
 total: 0 errors, 0 warnings, 14 lines checked
 
 0001-arm-post-memory-fix-bug-if-sdram-base-0x.patch has no obvious 
 style problems and is ready for submission.
 
  post/drivers/memory.c |7 ---
  1 files changed, 4 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The History of every  major  Galactic  Civilization  tends  to  pass
through  three  distinct  and recognizable phases, those of Survival,
Inquiry and Sophistication, otherwise known as the How, Why and Where
phases. For instance,  the  first  phase  is  characterized  by  the
question  'How  can  we  eat?'  the second by the question 'Why do we
eat?' and the third by the question 'Where shall we have lunch?'
- Hitchhiker's Guide to the Galaxy
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] arm, post, memory: fix bug if sdram base != 0x00000000

2011-10-07 Thread Heiko Schocher 
commit 8d3fcb5e60b6c8e1d530dbc2e2e33ec6a44670da breaks post
memory support for sdram base != 0x. Fix this.

Signed-off-by: Heiko Schocher h...@denx.de
Cc: Valentin Longchamp valentin.longch...@keymile.com
Cc: Holger Brunck holger.bru...@keymile.com
---
$ /home/git/linux-denx/scripts/checkpatch.pl 
0001-arm-post-memory-fix-bug-if-sdram-base-0x.patch
total: 0 errors, 0 warnings, 14 lines checked

0001-arm-post-memory-fix-bug-if-sdram-base-0x.patch has no obvious 
style problems and is ready for submission.

 post/drivers/memory.c |7 ---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/post/drivers/memory.c b/post/drivers/memory.c
index 69973c0..d25e323 100644
--- a/post/drivers/memory.c
+++ b/post/drivers/memory.c
@@ -466,10 +466,11 @@ static int memory_post_test_regions(unsigned long start, 
unsigned long size)
 
for (i = 0; i  (size  20)  (!ret); i++) {
if (!ret)
-   ret = memory_post_test_patterns(i  20, 0x800);
-   if (!ret)
-   ret = memory_post_test_patterns((i  20) + 0xff800,
+   ret = memory_post_test_patterns(start + (i  20),
0x800);
+   if (!ret)
+   ret = memory_post_test_patterns(start + (i  20) +
+   0xff800, 0x800);
}
 
return ret;
-- 
1.7.6.2

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] arm, post, memory: fix bug if sdram base != 0x00000000

2011-10-07 Thread Valentin Longchamp 
On 10/07/2011 08:40 AM, Heiko Schocher wrote:
 commit 8d3fcb5e60b6c8e1d530dbc2e2e33ec6a44670da breaks post
 memory support for sdram base != 0x. Fix this.
 
 Signed-off-by: Heiko Schocher h...@denx.de
 Cc: Valentin Longchamp valentin.longch...@keymile.com
 Cc: Holger Brunck holger.bru...@keymile.com
 ---
 $ /home/git/linux-denx/scripts/checkpatch.pl 
 0001-arm-post-memory-fix-bug-if-sdram-base-0x.patch
 total: 0 errors, 0 warnings, 14 lines checked
 
 0001-arm-post-memory-fix-bug-if-sdram-base-0x.patch has no obvious 
 style problems and is ready for submission.
 
  post/drivers/memory.c |7 ---
  1 files changed, 4 insertions(+), 3 deletions(-)
 
 diff --git a/post/drivers/memory.c b/post/drivers/memory.c
 index 69973c0..d25e323 100644
 --- a/post/drivers/memory.c
 +++ b/post/drivers/memory.c
 @@ -466,10 +466,11 @@ static int memory_post_test_regions(unsigned long 
 start, unsigned long size)
  
   for (i = 0; i  (size  20)  (!ret); i++) {
   if (!ret)
 - ret = memory_post_test_patterns(i  20, 0x800);
 - if (!ret)
 - ret = memory_post_test_patterns((i  20) + 0xff800,
 + ret = memory_post_test_patterns(start + (i  20),
   0x800);
 + if (!ret)
 + ret = memory_post_test_patterns(start + (i  20) +
 + 0xff800, 0x800);
   }
  
   return ret;

Thanks for fixing that Heiko: we only have boards starting @0x so I did
not notice this bug.

Ackey-by: Valentin Longchamp valentin.longch...@keymile.com

Valentin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] arm, post, memory: fix bug if sdram base != 0x00000000

2011-10-07 Thread Mike Frysinger 
Acked-by: Mike Frysinger vap...@gentoo.org
-mike


signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot