Re: [U-Boot] [PATCH] arm: socfpga: Add do_bridge_reset for Arria 10

2018-06-01 Thread Marek Vasut 
On 06/01/2018 10:13 AM, Ley Foon Tan wrote:
> Add do_bridge_reset() function for Arria 10, it is required by misc.c.
> 
> arch/arm/mach-socfpga/built-in.o: In function `do_bridge':
> arch/arm/mach-socfpga/misc.c:221: undefined reference to `do_bridge_reset'
> make[1]: *** [u-boot] Error 1
> 
> Signed-off-by: Ley Foon Tan 
> ---
>  arch/arm/mach-socfpga/misc_arria10.c | 9 +
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/mach-socfpga/misc_arria10.c 
> b/arch/arm/mach-socfpga/misc_arria10.c
> index 47a9d50..a75cbc4 100644
> --- a/arch/arm/mach-socfpga/misc_arria10.c
> +++ b/arch/arm/mach-socfpga/misc_arria10.c
> @@ -14,6 +14,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -262,3 +263,11 @@ int arch_misc_init(void)
>   return socfpga_eth_reset();
>  }
>  #endif
> +
> +void do_bridge_reset(int enable)
> +{
> + if (enable)
> + socfpga_reset_deassert_bridges_handoff();
> + else
> + socfpga_bridges_reset();
> +}
> 
Ignore my previous comment, applied.

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] arm: socfpga: Add do_bridge_reset for Arria 10

2018-06-01 Thread Marek Vasut 
On 06/01/2018 10:13 AM, Ley Foon Tan wrote:
> Add do_bridge_reset() function for Arria 10, it is required by misc.c.
> 
> arch/arm/mach-socfpga/built-in.o: In function `do_bridge':
> arch/arm/mach-socfpga/misc.c:221: undefined reference to `do_bridge_reset'
> make[1]: *** [u-boot] Error 1
> 
> Signed-off-by: Ley Foon Tan 
> ---
>  arch/arm/mach-socfpga/misc_arria10.c | 9 +
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/mach-socfpga/misc_arria10.c 
> b/arch/arm/mach-socfpga/misc_arria10.c
> index 47a9d50..a75cbc4 100644
> --- a/arch/arm/mach-socfpga/misc_arria10.c
> +++ b/arch/arm/mach-socfpga/misc_arria10.c
> @@ -14,6 +14,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -262,3 +263,11 @@ int arch_misc_init(void)
>   return socfpga_eth_reset();
>  }
>  #endif
> +
> +void do_bridge_reset(int enable)
> +{
> + if (enable)
> + socfpga_reset_deassert_bridges_handoff();
> + else
> + socfpga_bridges_reset();
> +}
> 
http://git.denx.de/?p=u-boot/u-boot-socfpga.git;a=commit;h=8bed1b1dbaee66def9a8ded4f855e3d1f258d183

is probably better, since it uses the same command line API to operate
bridges as Gen5. Can you please rebase that one and submit it instead ?

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] arm: socfpga: Add do_bridge_reset for Arria 10

2018-06-01 Thread Ley Foon Tan 
Add do_bridge_reset() function for Arria 10, it is required by misc.c.

arch/arm/mach-socfpga/built-in.o: In function `do_bridge':
arch/arm/mach-socfpga/misc.c:221: undefined reference to `do_bridge_reset'
make[1]: *** [u-boot] Error 1

Signed-off-by: Ley Foon Tan 
---
 arch/arm/mach-socfpga/misc_arria10.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/mach-socfpga/misc_arria10.c 
b/arch/arm/mach-socfpga/misc_arria10.c
index 47a9d50..a75cbc4 100644
--- a/arch/arm/mach-socfpga/misc_arria10.c
+++ b/arch/arm/mach-socfpga/misc_arria10.c
@@ -14,6 +14,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -262,3 +263,11 @@ int arch_misc_init(void)
return socfpga_eth_reset();
 }
 #endif
+
+void do_bridge_reset(int enable)
+{
+   if (enable)
+   socfpga_reset_deassert_bridges_handoff();
+   else
+   socfpga_bridges_reset();
+}
-- 
2.2.2

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot