Re: [U-Boot] [PATCH] arm926ejs: remove noop flush_dcache_all function

2011-12-13 Thread Tom Rini 
2011/12/12 Matthias Weißer weiss...@arcor.de:
 Am 12.12.2011 00:09, schrieb Ilya Yanok:

 Commit 2f3427c added noop cache functions implementation for arm926ejs
 to fix compilation of drivers depending on these functions (DaVinci
 EMAC in particular).

 Unfortunately, the bug was introduced: noop implementation calls
 dcache_disable which calls flush_dcache_all which in turn calls
 dcache_disable thus creating an infinite loop.

 This patch removes noop implementation for flush_dcache_all, we already
 have default one in arch/arm/lib/cache.c and it should be used instead.

 Signed-off-by: Ilya Yanokya...@emcraft.com
 ---

 Hi Matthias,

 thanks for cathing this. Surely my initial patch was totally wrong.
 Could you please test this one?

 This patches solves at least my problem. Thanks.

 Tested-by: Matthias Weisser weiss...@arcor.de

Merged to u-boot-ti/master, thanks!

-- 
Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] arm926ejs: remove noop flush_dcache_all function

2011-12-12 Thread Matthias Weißer 

Am 12.12.2011 00:09, schrieb Ilya Yanok:
 Commit 2f3427c added noop cache functions implementation for arm926ejs
 to fix compilation of drivers depending on these functions (DaVinci
 EMAC in particular).

 Unfortunately, the bug was introduced: noop implementation calls
 dcache_disable which calls flush_dcache_all which in turn calls
 dcache_disable thus creating an infinite loop.

 This patch removes noop implementation for flush_dcache_all, we already
 have default one in arch/arm/lib/cache.c and it should be used instead.

 Signed-off-by: Ilya Yanokya...@emcraft.com
 ---

 Hi Matthias,

 thanks for cathing this. Surely my initial patch was totally wrong.
 Could you please test this one?

This patches solves at least my problem. Thanks.

Tested-by: Matthias Weisser weiss...@arcor.de

Matthias
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] arm926ejs: remove noop flush_dcache_all function

2011-12-11 Thread Ilya Yanok 
Commit 2f3427c added noop cache functions implementation for arm926ejs
to fix compilation of drivers depending on these functions (DaVinci
EMAC in particular).

Unfortunately, the bug was introduced: noop implementation calls
dcache_disable which calls flush_dcache_all which in turn calls
dcache_disable thus creating an infinite loop.

This patch removes noop implementation for flush_dcache_all, we already
have default one in arch/arm/lib/cache.c and it should be used instead.

Signed-off-by: Ilya Yanok ya...@emcraft.com
---

Hi Matthias,

thanks for cathing this. Surely my initial patch was totally wrong.
Could you please test this one?

Regards, Ilya.

 arch/arm/cpu/arm926ejs/cache.c |5 -
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/arch/arm/cpu/arm926ejs/cache.c b/arch/arm/cpu/arm926ejs/cache.c
index 4415642..ee90ab7 100644
--- a/arch/arm/cpu/arm926ejs/cache.c
+++ b/arch/arm/cpu/arm926ejs/cache.c
@@ -38,11 +38,6 @@ void invalidate_dcache_all(void)
dcache_noop();
 }
 
-void flush_dcache_all(void)
-{
-   dcache_noop();
-}
-
 void invalidate_dcache_range(unsigned long start, unsigned long stop)
 {
dcache_noop();
-- 
1.7.6.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot