Re: [U-Boot] [PATCH] buildman: Deal nicely with invalid build-status file

2019-01-03 Thread sjg
The 'done' files created by buildman may end up being empty if buildman
runs out of disk space while writing them. This error is then persistent,
since even if disk space is reclaimed and the build retries, the empty
file causes an exception in the builder thread.

Deal with this silently by doing a rebuild.

Signed-off-by: Simon Glass 
---

 tools/buildman/builderthread.py | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Applied to u-boot-dm/master, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH] buildman: Deal nicely with invalid build-status file

2018-12-10 Thread Simon Glass
The 'done' files created by buildman may end up being empty if buildman
runs out of disk space while writing them. This error is then persistent,
since even if disk space is reclaimed and the build retries, the empty
file causes an exception in the builder thread.

Deal with this silently by doing a rebuild.

Signed-off-by: Simon Glass 
---

 tools/buildman/builderthread.py | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index c84ba6acf11..b91634f3abb 100644
--- a/tools/buildman/builderthread.py
+++ b/tools/buildman/builderthread.py
@@ -156,7 +156,12 @@ class BuilderThread(threading.Thread):
 if result.already_done:
 # Get the return code from that build and use it
 with open(done_file, 'r') as fd:
-result.return_code = int(fd.readline())
+try:
+result.return_code = int(fd.readline())
+except ValueError:
+# The file may be empty due to running out of disk space.
+# Try a rebuild
+result.return_code = RETURN_CODE_RETRY
 
 # Check the signal that the build needs to be retried
 if result.return_code == RETURN_CODE_RETRY:
-- 
2.20.0.rc2.403.gdbc3b29805-goog

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot