Re: [U-Boot] [PATCH] cmd_cache: use cache/invalidate functions available in common.h

[Wolfgang Denk]

Dear Stefan Kristiansson,

In message 
1320121272-17613-1-git-send-email-stefan.kristians...@saunalahti.fi you wrote:
 flush_dcache()/flush_icache() aren't defined in common.h,
 flush_dcache_all()/invalidate_icache_all() however are.
 
 Let the icache and dcache commands use those instead.
 
 Signed-off-by: Stefan Kristiansson stefan.kristians...@saunalahti.fi
 ---
  common/cmd_cache.c |   16 
  1 files changed, 8 insertions(+), 8 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The lesser of two evils -- is evil. - Seymour (Sy) Leon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] cmd_cache: use cache/invalidate functions available in common.h

[Mike Frysinger]

i think the ppc guys might need to rename some of their funcs, and it seems 
like boards/drivers that use these are ppc-only, so there probably won't be 
any tree breakage ...

Acked-by: Mike Frysinger vap...@gentoo.org
-mike


signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] cmd_cache: use cache/invalidate functions available in common.h

[Stefan Kristiansson]

flush_dcache()/flush_icache() aren't defined in common.h,
flush_dcache_all()/invalidate_icache_all() however are.

Let the icache and dcache commands use those instead.

Signed-off-by: Stefan Kristiansson stefan.kristians...@saunalahti.fi
---
 common/cmd_cache.c |   16 
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/common/cmd_cache.c b/common/cmd_cache.c
index 9778d3b..360136c 100644
--- a/common/cmd_cache.c
+++ b/common/cmd_cache.c
@@ -30,10 +30,10 @@
 
 static int parse_argv(const char *);
 
-void __weak flush_icache(void)
+void __weak invalidate_icache_all(void)
 {
-   /* please define arch specific flush_icache */
-   puts(No arch specific flush_icache available!\n);
+   /* please define arch specific invalidate_icache_all */
+   puts(No arch specific invalidate_icache_all available!\n);
 }
 
 int do_icache ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
@@ -45,7 +45,7 @@ int do_icache ( cmd_tbl_t *cmdtp, int flag, int argc, char * 
const argv[])
break;
case 1: icache_enable ();
break;
-   case 2: flush_icache();
+   case 2: invalidate_icache_all();
break;
}
/* FALL TROUGH */
@@ -59,10 +59,10 @@ int do_icache ( cmd_tbl_t *cmdtp, int flag, int argc, char 
* const argv[])
return 0;
 }
 
-void __weak flush_dcache(void)
+void __weak flush_dcache_all(void)
 {
-   puts(No arch specific flush_dcache available!\n);
-   /* please define arch specific flush_dcache */
+   puts(No arch specific flush_dcache_all available!\n);
+   /* please define arch specific flush_dcache_all */
 }
 
 int do_dcache ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
@@ -74,7 +74,7 @@ int do_dcache ( cmd_tbl_t *cmdtp, int flag, int argc, char * 
const argv[])
break;
case 1: dcache_enable ();
break;
-   case 2: flush_dcache();
+   case 2: flush_dcache_all();
break;
}
/* FALL TROUGH */
-- 
1.7.5.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot