Re: [U-Boot] [PATCH] common/cmd_bdinfo.c: fix do_bdinfo() for AVR32

2010-11-03 Thread Andreas Bießmann 
Dear Reinhard Meyer,

Am 02.11.2010 18:01, schrieb Andreas Bießmann:
 Am 02.11.2010 um 17:34 schrieb Reinhard Meyer:
 Your e-Mail is:
 Content-Transfer-Encoding: quoted-printable

 That means ' ' comes as =20, '=' comes as =3D
 grr .. I wonder which part of the chain it was, will fix that.

I found it ... The mails on this system went through local exim which
did some conversion. The v2 patches should be ok, are they?

regards

Andreas Bießmann
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] common/cmd_bdinfo.c: fix do_bdinfo() for AVR32

2010-11-02 Thread Andreas Bießmann 
There was a prototype change from do_bdinfo(.. char *) to do_bdinfo(.. char *
const). This patch respect this change for AVR32 architecture.

Signed-off-by: Andreas Bießmann biessm...@corscience.de
---
 common/cmd_bdinfo.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
index bba7374..1d76ffa 100644
--- a/common/cmd_bdinfo.c
+++ b/common/cmd_bdinfo.c
@@ -304,7 +304,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char 
* const argv[])
 
 #elif defined(CONFIG_AVR32)
 
-int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
bd_t *bd = gd-bd;
 
-- 
1.7.2.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] common/cmd_bdinfo.c: fix do_bdinfo() for AVR32

2010-11-02 Thread Reinhard Meyer 
Dear Andreas Bießmann,

Your e-Mail is:
Content-Transfer-Encoding: quoted-printable

That means ' ' comes as =20, '=' comes as =3D

 There was a prototype change from do_bdinfo(.. char *) to do_bdinfo(.. char *
 const). This patch respect this change for AVR32 architecture.
 
 Signed-off-by: Andreas Bießmann biessm...@corscience.de
 ---
  common/cmd_bdinfo.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
 index bba7374..1d76ffa 100644
 --- a/common/cmd_bdinfo.c
 +++ b/common/cmd_bdinfo.c
 @@ -304,7 +304,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, 
 char * const argv[])
  
  #elif defined(CONFIG_AVR32)
  
 -int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 +int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
  {
   bd_t *bd = gd-bd;
  

I see that cmd_bdinfo.c has lots of coding style violations, but
some architectures have them fixed.
Could we at least fix them in the AVR32 part, if we touch it anyway?
See the BLACKFIN example ;)

Or is it OK to leave it as is? Wolfgang?

Best Regards,
Reinhard
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] common/cmd_bdinfo.c: fix do_bdinfo() for AVR32

2010-11-02 Thread Andreas Bießmann 
Dear Reinhard Meyer,

Am 02.11.2010 um 17:34 schrieb Reinhard Meyer:

 Dear Andreas Bießmann,
 
 Your e-Mail is:
 Content-Transfer-Encoding: quoted-printable
 
 That means ' ' comes as =20, '=' comes as =3D
grr .. I wonder which part of the chain it was, will fix that.

 I see that cmd_bdinfo.c has lots of coding style violations, but
 some architectures have them fixed.
 Could we at least fix them in the AVR32 part, if we touch it anyway?
 See the BLACKFIN example ;)

I see, will fix that too. I have one additional change (my board does not have 
network at all ;). Patch will follow tomorrow.

regards

Andreas Bießmann
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] common/cmd_bdinfo.c: fix do_bdinfo() for AVR32

2010-11-02 Thread Wolfgang Denk 
Dear Reinhard Meyer,

In message 4cd03d9c.6070...@emk-elektronik.de you wrote:

 I see that cmd_bdinfo.c has lots of coding style violations, but
 some architectures have them fixed.
 Could we at least fix them in the AVR32 part, if we touch it anyway?
 See the BLACKFIN example ;)
 
 Or is it OK to leave it as is? Wolfgang?

Coding style fixes are OK, but should be done on file scope, and
independent from changed to the actual content of the file.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Whenever people agree with me, I always think I must be wrong.
- Oscar Wilde
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot