Re: [U-Boot] [PATCH] common: env_sf: Add exclamation mark

[Tom Rini]

On Mon, Mar 28, 2016 at 05:26:27PM +0800, Peng Fan wrote:

> Add exclamation mark to the errmsg, when error and set_default_env.

This is awkwardly worded.  We aren't adding a literal ! to the errmsg
itself, we're adding that as a flag.  I'll try and re-word this when
applying to be clearer.

> 
> Signed-off-by: Peng Fan 
> Cc: Mario Schuknecht 
> Cc: Vignesh R 
> Cc: Jagan Teki 
> Cc: Ravi Babu 
> Cc: York Sun 
> Cc: Tom Rini 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] common: env_sf: Add exclamation mark

[Peng Fan]

Add exclamation mark to the errmsg, when error and set_default_env.

Signed-off-by: Peng Fan 
Cc: Mario Schuknecht 
Cc: Vignesh R 
Cc: Jagan Teki 
Cc: Ravi Babu 
Cc: York Sun 
Cc: Tom Rini 
---
 common/env_sf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/env_sf.c b/common/env_sf.c
index 892e6cb..273098c 100644
--- a/common/env_sf.c
+++ b/common/env_sf.c
@@ -225,7 +225,7 @@ void env_relocate_spec(void)
ret = env_import((char *)ep, 0);
if (!ret) {
error("Cannot import environment: errno = %d\n", errno);
-   set_default_env("env_import failed");
+   set_default_env("!env_import failed");
}
 
 err_read:
-- 
2.6.2

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot