Re: [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition
On Mon, Sep 09, 2013 at 05:41:46PM +0200, Wolfgang Denk wrote: Dear Rob, In message 522de2ff.2080...@gmail.com you wrote: What do I do with current boards that are wrong? I should make all these Good question... boards have build errors or fix them to use 1000 which may break them at runtime depending on their possible misuse of CONFIG_SYS_HZ? include/configs/KAREF.h:#define CONFIG_SYS_HZ 100 /* decr freq: 1 ms ticks */ include/configs/M5271EVB.h:#define CONFIG_SYS_HZ 100 include/configs/METROBOX.h:#define CONFIG_SYS_HZ 100/* decr freq: 1 ms ticks */ include/configs/MVBLUE.h:#define CONFIG_SYS_HZ 1 include/configs/idmr.h:#define CONFIG_SYS_HZ (5000 / 64) include/configs/mini2440.h:#define CONFIG_SYS_HZ 1562500 include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400 include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ ((V_SCLK) / (2 CONFIG_SYS_PTV)) include/configs/omap730p2.h:#define CONFIG_SYS_HZ ((CONFIG_SYS_CLK_FREQ)/(2 CONFIG_SYS_PTV)) include/configs/rsk7203.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7264.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7269.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400 /* incrementer freq: 3.6864 MHz */ include/configs/versatile.h:#define CONFIG_SYS_HZ (100 / 256) Hm... which of these boards are actually still being maintained? KAREF and METROBOX are PPC systems, and the comment suggests that the value is actually just a typo. Here it should be harmless to change this to use 1000 Hz instead. Ditto probably for MVBLUE. The rest might actually be dead? Guess we should have their builds break and make the board maintainers fix them. If they don't (because the boards are unmaintained), we will drop the board code from the repo. Actually breaking them will cause hell on the folks building everything. Lets correct the ones we can correct easily and poke maintainers for the rest so we know what we can/should move to orphaned or just drop. -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition
On Thu, Sep 19, 2013 at 2:06 PM, Tom Rini tr...@ti.com wrote: On Mon, Sep 09, 2013 at 05:41:46PM +0200, Wolfgang Denk wrote: Dear Rob, In message 522de2ff.2080...@gmail.com you wrote: What do I do with current boards that are wrong? I should make all these Good question... boards have build errors or fix them to use 1000 which may break them at runtime depending on their possible misuse of CONFIG_SYS_HZ? include/configs/KAREF.h:#define CONFIG_SYS_HZ 100 /* decr freq: 1 ms ticks */ include/configs/M5271EVB.h:#define CONFIG_SYS_HZ 100 include/configs/METROBOX.h:#define CONFIG_SYS_HZ 100/* decr freq: 1 ms ticks */ include/configs/MVBLUE.h:#define CONFIG_SYS_HZ 1 include/configs/idmr.h:#define CONFIG_SYS_HZ (5000 / 64) include/configs/mini2440.h:#define CONFIG_SYS_HZ 1562500 include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400 include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ ((V_SCLK) / (2 CONFIG_SYS_PTV)) include/configs/omap730p2.h:#define CONFIG_SYS_HZ ((CONFIG_SYS_CLK_FREQ)/(2 CONFIG_SYS_PTV)) include/configs/rsk7203.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7264.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7269.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400 /* incrementer freq: 3.6864 MHz */ include/configs/versatile.h:#define CONFIG_SYS_HZ (100 / 256) Hm... which of these boards are actually still being maintained? KAREF and METROBOX are PPC systems, and the comment suggests that the value is actually just a typo. Here it should be harmless to change this to use 1000 Hz instead. Ditto probably for MVBLUE. The rest might actually be dead? Guess we should have their builds break and make the board maintainers fix them. If they don't (because the boards are unmaintained), we will drop the board code from the repo. Actually breaking them will cause hell on the folks building everything. Lets correct the ones we can correct easily and poke maintainers for the rest so we know what we can/should move to orphaned or just drop. How about just a warning instead? Here's an updated list which missed some: include/configs/M5271EVB.h:#define CONFIG_SYS_HZ100 include/configs/balloon3.h:#define CONFIG_SYS_HZ 325 /* Timer @ 325 Hz */ include/configs/idmr.h:#define CONFIG_SYS_HZ(5000 / 64) include/configs/mini2440.h:#define CONFIG_SYS_HZ1562500 include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400 include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ ((V_SCLK) / (2 CONFIG_SYS_PTV)) include/configs/omap730p2.h:#define CONFIG_SYS_HZ ((CONFIG_SYS_CLK_FREQ)/(2 CONFIG_SYS_PTV)) include/configs/palmld.h:#defineCONFIG_SYS_HZ 325 /* Timer @ 325 Hz */ include/configs/palmtc.h:#defineCONFIG_SYS_HZ 3686400 /* Timer @ 3686400 Hz */ include/configs/rsk7203.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7264.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7269.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400 /* incrementer freq: 3.6864 MHz */ include/configs/versatile.h:#define CONFIG_SYS_HZ (100 / 256) include/configs/zipitz2.h:#define CONFIG_SYS_HZ 325 /* Timer @ 325 Hz */ Rob ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/19/2013 05:02 PM, Rob Herring wrote: On Thu, Sep 19, 2013 at 2:06 PM, Tom Rini tr...@ti.com wrote: On Mon, Sep 09, 2013 at 05:41:46PM +0200, Wolfgang Denk wrote: Dear Rob, In message 522de2ff.2080...@gmail.com you wrote: What do I do with current boards that are wrong? I should make all these Good question... boards have build errors or fix them to use 1000 which may break them at runtime depending on their possible misuse of CONFIG_SYS_HZ? include/configs/KAREF.h:#define CONFIG_SYS_HZ 100 /* decr freq: 1 ms ticks */ include/configs/M5271EVB.h:#define CONFIG_SYS_HZ 100 include/configs/METROBOX.h:#define CONFIG_SYS_HZ 100/* decr freq: 1 ms ticks */ include/configs/MVBLUE.h:#define CONFIG_SYS_HZ 1 include/configs/idmr.h:#define CONFIG_SYS_HZ (5000 / 64) include/configs/mini2440.h:#define CONFIG_SYS_HZ 1562500 include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400 include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ ((V_SCLK) / (2 CONFIG_SYS_PTV)) include/configs/omap730p2.h:#define CONFIG_SYS_HZ ((CONFIG_SYS_CLK_FREQ)/(2 CONFIG_SYS_PTV)) include/configs/rsk7203.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7264.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7269.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400 /* incrementer freq: 3.6864 MHz */ include/configs/versatile.h:#define CONFIG_SYS_HZ (100 / 256) Hm... which of these boards are actually still being maintained? KAREF and METROBOX are PPC systems, and the comment suggests that the value is actually just a typo. Here it should be harmless to change this to use 1000 Hz instead. Ditto probably for MVBLUE. The rest might actually be dead? Guess we should have their builds break and make the board maintainers fix them. If they don't (because the boards are unmaintained), we will drop the board code from the repo. Actually breaking them will cause hell on the folks building everything. Lets correct the ones we can correct easily and poke maintainers for the rest so we know what we can/should move to orphaned or just drop. How about just a warning instead? Here's an updated list which missed some: include/configs/M5271EVB.h:#define CONFIG_SYS_HZ 100 include/configs/balloon3.h:#define CONFIG_SYS_HZ 325 /* Timer @ 325 Hz */ include/configs/idmr.h:#define CONFIG_SYS_HZ(5000 / 64) include/configs/mini2440.h:#define CONFIG_SYS_HZ 1562500 include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400 include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ ((V_SCLK) / (2 CONFIG_SYS_PTV)) include/configs/omap730p2.h:#define CONFIG_SYS_HZ ((CONFIG_SYS_CLK_FREQ)/(2 CONFIG_SYS_PTV)) include/configs/palmld.h:#defineCONFIG_SYS_HZ 325 /* Timer @ 325 Hz */ include/configs/palmtc.h:#defineCONFIG_SYS_HZ 3686400 /* Timer @ 3686400 Hz */ include/configs/rsk7203.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7264.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7269.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400 /* incrementer freq: 3.6864 MHz */ include/configs/versatile.h:#define CONFIG_SYS_HZ (100 / 256) include/configs/zipitz2.h:#define CONFIG_SYS_HZ 325 /* Timer @ 325 Hz */ I could live with that I think. - -- Tom -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSO3cBAAoJENk4IS6UOR1W0I4P/0l+rxS4C6tiFmCIQo9Wtf2i owKufT+cvGsQCtzbH84g3gUR/0bLE+FTAslYLyZ8DptFqlpOnOtc+pHqlOVgWZAp R1mZyVz1jU+8bRkieDFb6tv6PFGcXAkcC37epKlVk6b9A0vJnm6xEXQ1Hwb7XGhG j5DZ8KeUXWYyGcn5SYY5wRMztWcfQMMZ8MQVbioD8LE2vh7E2QnWBio168yfUS8l rbvxoykj6fxikYCWcdlr7ov7adzCa+nmwc4u0qxXzXro5Nm0uZ98FnJSj0HmuaS0 ISG0VMO+E6BnBFOBhwYbAgKgSFvTdxM8yo5lU66UuzVwVYvqqANbHhAR0I+8e4v4 k8jlouvUcFuQycWAotZopfqPnHMpDx51UYEjIcgw+MvCc9KqIH07epDOKuq4TLgn tGrM2N6HyX+ofKjKB1r6zRrqECzbGu8E5fAZNf/JrNgUTbfFRhmMvLFJ7F99ZUb+ chjveTUsY2yCmadgwxrQjOTLBn9MCabFqkm/mGweN+EjjAKJ25aE+JgIj2izYLal B1AzToq8YmAHJcFne6FJX3n2DUPKJ0BahvOkGjos9/jJjJdMI0bZw1x/As0ea6ZO NPKgewt5F7/uyhFe+B4wyi9xCgamR/ICGwS/K/ooIxB6rs+M17bb+PiV6QbX1DV4 imnvmPivTmbhQ/mGMM6c =+vhz -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition
Dear Rob Herring, In message 1378670088-17602-1-git-send-email-robherri...@gmail.com you wrote: ... diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h index e59ee96..4c25289 100644 --- a/include/config_fallbacks.h +++ b/include/config_fallbacks.h @@ -53,4 +53,8 @@ #define HAVE_BLOCK_DEVICE #endif +#ifndef CONFIG_SYS_HZ +#define CONFIG_SYS_HZ1000 +#endif This should be not a fallback (i. e. default value) which can be silently overwritten - this should be a mandatory definition that causes build errors if somebody tries to define a different value. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Steal five dollars and you were a petty thief. Steal thousands of dollars and you are either a government or a hero. - Terry Pratchett, _Going_Postal_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition
On 09/09/2013 09:06 AM, Wolfgang Denk wrote: Dear Rob Herring, In message 1378670088-17602-1-git-send-email-robherri...@gmail.com you wrote: ... diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h index e59ee96..4c25289 100644 --- a/include/config_fallbacks.h +++ b/include/config_fallbacks.h @@ -53,4 +53,8 @@ #define HAVE_BLOCK_DEVICE #endif +#ifndef CONFIG_SYS_HZ +#define CONFIG_SYS_HZ 1000 +#endif This should be not a fallback (i. e. default value) which can be silently overwritten - this should be a mandatory definition that causes build errors if somebody tries to define a different value. What do I do with current boards that are wrong? I should make all these boards have build errors or fix them to use 1000 which may break them at runtime depending on their possible misuse of CONFIG_SYS_HZ? include/configs/KAREF.h:#define CONFIG_SYS_HZ 100 /* decr freq: 1 ms ticks */ include/configs/M5271EVB.h:#define CONFIG_SYS_HZ 100 include/configs/METROBOX.h:#define CONFIG_SYS_HZ 100/* decr freq: 1 ms ticks */ include/configs/MVBLUE.h:#define CONFIG_SYS_HZ 1 include/configs/idmr.h:#define CONFIG_SYS_HZ (5000 / 64) include/configs/mini2440.h:#define CONFIG_SYS_HZ 1562500 include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400 include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ ((V_SCLK) / (2 CONFIG_SYS_PTV)) include/configs/omap730p2.h:#define CONFIG_SYS_HZ ((CONFIG_SYS_CLK_FREQ)/(2 CONFIG_SYS_PTV)) include/configs/rsk7203.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7264.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7269.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400 /* incrementer freq: 3.6864 MHz */ include/configs/versatile.h:#define CONFIG_SYS_HZ (100 / 256) Rob ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition
Dear Rob, In message 522de2ff.2080...@gmail.com you wrote: What do I do with current boards that are wrong? I should make all these Good question... boards have build errors or fix them to use 1000 which may break them at runtime depending on their possible misuse of CONFIG_SYS_HZ? include/configs/KAREF.h:#define CONFIG_SYS_HZ 100 /* decr freq: 1 ms ticks */ include/configs/M5271EVB.h:#define CONFIG_SYS_HZ 100 include/configs/METROBOX.h:#define CONFIG_SYS_HZ 100/* decr freq: 1 ms ticks */ include/configs/MVBLUE.h:#define CONFIG_SYS_HZ 1 include/configs/idmr.h:#define CONFIG_SYS_HZ (5000 / 64) include/configs/mini2440.h:#define CONFIG_SYS_HZ 1562500 include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400 include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ ((V_SCLK) / (2 CONFIG_SYS_PTV)) include/configs/omap730p2.h:#define CONFIG_SYS_HZ ((CONFIG_SYS_CLK_FREQ)/(2 CONFIG_SYS_PTV)) include/configs/rsk7203.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7264.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/rsk7269.h:#define CONFIG_SYS_HZ (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400 /* incrementer freq: 3.6864 MHz */ include/configs/versatile.h:#define CONFIG_SYS_HZ (100 / 256) Hm... which of these boards are actually still being maintained? KAREF and METROBOX are PPC systems, and the comment suggests that the value is actually just a typo. Here it should be harmless to change this to use 1000 Hz instead. Ditto probably for MVBLUE. The rest might actually be dead? Guess we should have their builds break and make the board maintainers fix them. If they don't (because the boards are unmaintained), we will drop the board code from the repo. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There's nothing disgusting about it [the Companion]. It's just another life form, that's all. You get used to those things. -- McCoy, Metamorphosis, stardate 3219.8 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
