Re: [U-Boot] [PATCH] da850 evm: Fix definition of 'pinmux' macro

2010-07-15 Thread Paulraj, Sandeep

 
 Usage of parenthesis in pinmux macro definition changes the
 definition of the macro and raises the precedence of ''
 operator inadvertently over '[]'.
 
 Signed-off-by: Prakash PM prakash...@ti.com
 ---
  board/davinci/da8xxevm/da850evm.c |   22 +++---
  1 files changed, 11 insertions(+), 11 deletions(-)
 
 diff --git a/board/davinci/da8xxevm/da850evm.c
 b/board/davinci/da8xxevm/da850evm.c
 index 959b2c6..eeb456c 100644
 --- a/board/davinci/da8xxevm/da850evm.c
 +++ b/board/davinci/da8xxevm/da850evm.c

Pushed to u-boot-ti
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] da850 evm: Fix definition of 'pinmux' macro

2010-07-06 Thread Prakash PM
Usage of parenthesis in pinmux macro definition changes the
definition of the macro and raises the precedence of ''
operator inadvertently over '[]'.

Signed-off-by: Prakash PM prakash...@ti.com
---
 board/davinci/da8xxevm/da850evm.c |   22 +++---
 1 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/board/davinci/da8xxevm/da850evm.c 
b/board/davinci/da8xxevm/da850evm.c
index 959b2c6..eeb456c 100644
--- a/board/davinci/da8xxevm/da850evm.c
+++ b/board/davinci/da8xxevm/da850evm.c
@@ -30,28 +30,28 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-#define pinmux (davinci_syscfg_regs-pinmux)
+#define pinmux(x)  (davinci_syscfg_regs-pinmux[x])
 
 /* SPI0 pin muxer settings */
 static const struct pinmux_config spi1_pins[] = {
-   { pinmux[5], 1, 1 },
-   { pinmux[5], 1, 2 },
-   { pinmux[5], 1, 4 },
-   { pinmux[5], 1, 5 }
+   { pinmux(5), 1, 1 },
+   { pinmux(5), 1, 2 },
+   { pinmux(5), 1, 4 },
+   { pinmux(5), 1, 5 }
 };
 
 /* UART pin muxer settings */
 static const struct pinmux_config uart_pins[] = {
-   { pinmux[0], 4, 6 },
-   { pinmux[0], 4, 7 },
-   { pinmux[4], 2, 4 },
-   { pinmux[4], 2, 5 }
+   { pinmux(0), 4, 6 },
+   { pinmux(0), 4, 7 },
+   { pinmux(4), 2, 4 },
+   { pinmux(4), 2, 5 }
 };
 
 /* I2C pin muxer settings */
 static const struct pinmux_config i2c_pins[] = {
-   { pinmux[4], 2, 2 },
-   { pinmux[4], 2, 3 }
+   { pinmux(4), 2, 2 },
+   { pinmux(4), 2, 3 }
 };
 
 static const struct pinmux_resource pinmuxes[] = {
-- 
1.5.6

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot