Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

2011-11-17 Thread Stefano Babic 
On 11/17/2011 08:56 AM, Thierry Reding wrote:

 I had actually set Doug Anderson diand...@chromium.org on Cc 
 because he was involved with the initial patch but for some reason 
 he got stripped from Cc. Does anybody know why this is happening?

Probably Doug has received the first e-mail. I noted that git
send-email strips the CC addresses (maybe to avoid SPAM ?), but the
e-mail is sent anyway.

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: off...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

2011-11-17 Thread Thierry Reding 
* Stefano Babic wrote:
 On 11/17/2011 08:56 AM, Thierry Reding wrote:
 
  I had actually set Doug Anderson diand...@chromium.org on Cc 
  because he was involved with the initial patch but for some reason 
  he got stripped from Cc. Does anybody know why this is happening?
 
 Probably Doug has received the first e-mail. I noted that git
 send-email strips the CC addresses (maybe to avoid SPAM ?), but the
 e-mail is sent anyway.

I don't think git send-email is stripping the Cc header because I've seen it
work properly for other mailing lists. Perhaps the mailing list software is
the culprit here? Could it be that it strips people that are subscribed (and
will receive the mails anyway) but not those that aren't subscribed? Not that
Tom Warren wasn't stripped from Cc.

Thierry


pgpT9FB1YOXiL.pgp
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

2011-11-17 Thread Stephen Warren 
Thierry Reding wrote at Thursday, November 17, 2011 12:05 AM:
 Something apparently went wrong when the patch in commit deb5ca8 was
 applied. Commit f75dd58 changed the type of gpt_head to be a pointer and
 correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got
 applied, the gpt_head was again reverted to (gpt_head), which was the
 state before deb5ca8.
 
 This commit fixes the passing of gpt_head into is_gpt_valid().

I already posted this patch a while back:
http://patchwork.ozlabs.org/patch/122485/

-- 
nvpublic

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

2011-11-17 Thread Thierry Reding 
* Stephen Warren wrote:
 Thierry Reding wrote at Thursday, November 17, 2011 12:05 AM:
  Something apparently went wrong when the patch in commit deb5ca8 was
  applied. Commit f75dd58 changed the type of gpt_head to be a pointer and
  correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got
  applied, the gpt_head was again reverted to (gpt_head), which was the
  state before deb5ca8.
  
  This commit fixes the passing of gpt_head into is_gpt_valid().
 
 I already posted this patch a while back:
 http://patchwork.ozlabs.org/patch/122485/

I wasn't aware of that. Please ignore then.

Thierry


pgp7j29ElXzll.pgp
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

2011-11-17 Thread Tom Warren 
Doug is in the CC field (via Outlook in my 'U-Boot' folder @ work), and has 
been for every message in this thread.

 -Original Message-
 From: Thierry Reding [mailto:thierry.red...@avionic-design.de]
 Sent: Thursday, November 17, 2011 8:08 AM
 To: Stefano Babic
 Cc: Tom Warren; Doug Anderson; u-boot@lists.denx.de
 Subject: Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to
 is_gpt_valid().
 
 * PGP Signed by an unknown key
 
 * Stefano Babic wrote:
  On 11/17/2011 08:56 AM, Thierry Reding wrote:
 
   I had actually set Doug Anderson diand...@chromium.org on Cc
   because he was involved with the initial patch but for some reason
   he got stripped from Cc. Does anybody know why this is happening?
 
  Probably Doug has received the first e-mail. I noted that git
  send-email strips the CC addresses (maybe to avoid SPAM ?), but the
  e-mail is sent anyway.
 
 I don't think git send-email is stripping the Cc header because I've seen it
 work properly for other mailing lists. Perhaps the mailing list software is
 the culprit here? Could it be that it strips people that are subscribed (and
 will receive the mails anyway) but not those that aren't subscribed? Not
 that
 Tom Warren wasn't stripped from Cc.
 
 Thierry
 
 * Unknown Key
 * 0xA2E3269F
---
This email message is for the sole use of the intended recipient(s) and may 
contain
confidential information.  Any unauthorized review, use, disclosure or 
distribution
is prohibited.  If you are not the intended recipient, please contact the 
sender by
reply email and destroy all copies of the original message.
---
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

2011-11-17 Thread Premi, Sanjeev 
 -Original Message-
 From: u-boot-boun...@lists.denx.de 
 [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Thierry Reding
 Sent: Thursday, November 17, 2011 12:35 PM
 To: u-boot@lists.denx.de
 Cc: Tom Warren
 Subject: [U-Boot] [PATCH] disk: part_efi: Fix parameters 
 passed to is_gpt_valid().
 
 Something apparently went wrong when the patch in commit deb5ca8 was
 applied. Commit f75dd58 changed the type of gpt_head to be a 
 pointer and
 correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got
 applied, the gpt_head was again reverted to (gpt_head), which was the
 state before deb5ca8.
 
 This commit fixes the passing of gpt_head into is_gpt_valid().
 
 Signed-off-by: Thierry Reding thierry.red...@avionic-design.de
 ---
  disk/part_efi.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/disk/part_efi.c b/disk/part_efi.c
 index e7f2714..ddf80a7 100644
 --- a/disk/part_efi.c
 +++ b/disk/part_efi.c
 @@ -130,7 +130,7 @@ void print_part_efi(block_dev_desc_t * dev_desc)
   }
   /* This function validates AND fills in the GPT header 
 and PTE */
   if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
 -  (gpt_head), gpt_pte) != 1) {
 +  gpt_head, gpt_pte) != 1) {
   printf(%s: *** ERROR: Invalid GPT ***\n, __func__);
   return;
   }
 @@ -169,7 +169,7 @@ int 
 get_partition_info_efi(block_dev_desc_t * dev_desc, int part,
  
   /* This function validates AND fills in the GPT header 
 and PTE */
   if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
 - (gpt_head), gpt_pte) != 1) {
 + gpt_head, gpt_pte) != 1) {
   printf(%s: *** ERROR: Invalid GPT ***\n, __func__);
   return -1;
   }
 -- 

I had already posted 2 revisions of this patch:

http://lists.denx.de/pipermail/u-boot/2011-November/109791.html
http://lists.denx.de/pipermail/u-boot/2011-November/109899.html

And they are included in this pull request:

http://lists.denx.de/pipermail/u-boot/2011-November/110017.html


 1.7.7.3
 
 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot
 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

2011-11-17 Thread Doug Anderson 
Agreed--I see myself in the CC from the start.

Thanks for Stephen to pointing to the fix that he already posted.

-Doug

---

On Thu, Nov 17, 2011 at 9:02 AM, Tom Warren twar...@nvidia.com wrote:

 Doug is in the CC field (via Outlook in my 'U-Boot' folder @ work), and
 has been for every message in this thread.

  -Original Message-
  From: Thierry Reding [mailto:thierry.red...@avionic-design.de]
  Sent: Thursday, November 17, 2011 8:08 AM
  To: Stefano Babic
  Cc: Tom Warren; Doug Anderson; u-boot@lists.denx.de
  Subject: Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to
  is_gpt_valid().
 
  * PGP Signed by an unknown key
 
  * Stefano Babic wrote:
   On 11/17/2011 08:56 AM, Thierry Reding wrote:
  
I had actually set Doug Anderson diand...@chromium.org on Cc
because he was involved with the initial patch but for some reason
he got stripped from Cc. Does anybody know why this is happening?
  
   Probably Doug has received the first e-mail. I noted that git
   send-email strips the CC addresses (maybe to avoid SPAM ?), but the
   e-mail is sent anyway.
 
  I don't think git send-email is stripping the Cc header because I've
 seen it
  work properly for other mailing lists. Perhaps the mailing list software
 is
  the culprit here? Could it be that it strips people that are subscribed
 (and
  will receive the mails anyway) but not those that aren't subscribed? Not
  that
  Tom Warren wasn't stripped from Cc.
 
  Thierry
 
  * Unknown Key
  * 0xA2E3269F

 ---
 This email message is for the sole use of the intended recipient(s) and
 may contain
 confidential information.  Any unauthorized review, use, disclosure or
 distribution
 is prohibited.  If you are not the intended recipient, please contact the
 sender by
 reply email and destroy all copies of the original message.

 ---

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

2011-11-17 Thread Detlev Zundel 
Hi Thierry,

 * Stefano Babic wrote:
 On 11/17/2011 08:56 AM, Thierry Reding wrote:
 
  I had actually set Doug Anderson diand...@chromium.org on Cc 
  because he was involved with the initial patch but for some reason 
  he got stripped from Cc. Does anybody know why this is happening?
 
 Probably Doug has received the first e-mail. I noted that git
 send-email strips the CC addresses (maybe to avoid SPAM ?), but the
 e-mail is sent anyway.

 I don't think git send-email is stripping the Cc header because I've seen it
 work properly for other mailing lists. Perhaps the mailing list software is
 the culprit here? Could it be that it strips people that are subscribed (and
 will receive the mails anyway) but not those that aren't subscribed? Not that
 Tom Warren wasn't stripped from Cc.

Actually I know that sometimes there are such phenomena on the mailing
list, but as yet I failed to find a reason for it.  What I saw in the
past is that the CC field of individual mails sent to individual
subscribers has a reduced CC field with respect to the original mail,
i.e. a mail I received had a stripped header compared to what is in the
archives.

I will try to look into this when I find some time.

Cheers
  Detlev

-- 
Whatever you do will be insignificant,
but it is very important that you do it.
-- Mahatma Gandhi
--
DENX Software Engineering GmbH,  MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

2011-11-17 Thread Thierry Reding 
* Doug Anderson wrote:
 Agreed--I see myself in the CC from the start.

That leaves me really confused.

Thierry


pgptqQ3sZUSiB.pgp
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

2011-11-16 Thread Thierry Reding 
Something apparently went wrong when the patch in commit deb5ca8 was
applied. Commit f75dd58 changed the type of gpt_head to be a pointer and
correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got
applied, the gpt_head was again reverted to (gpt_head), which was the
state before deb5ca8.

This commit fixes the passing of gpt_head into is_gpt_valid().

Signed-off-by: Thierry Reding thierry.red...@avionic-design.de
---
 disk/part_efi.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/disk/part_efi.c b/disk/part_efi.c
index e7f2714..ddf80a7 100644
--- a/disk/part_efi.c
+++ b/disk/part_efi.c
@@ -130,7 +130,7 @@ void print_part_efi(block_dev_desc_t * dev_desc)
}
/* This function validates AND fills in the GPT header and PTE */
if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
-(gpt_head), gpt_pte) != 1) {
+gpt_head, gpt_pte) != 1) {
printf(%s: *** ERROR: Invalid GPT ***\n, __func__);
return;
}
@@ -169,7 +169,7 @@ int get_partition_info_efi(block_dev_desc_t * dev_desc, int 
part,
 
/* This function validates AND fills in the GPT header and PTE */
if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
-   (gpt_head), gpt_pte) != 1) {
+   gpt_head, gpt_pte) != 1) {
printf(%s: *** ERROR: Invalid GPT ***\n, __func__);
return -1;
}
-- 
1.7.7.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

2011-11-16 Thread Thierry Reding 
* Thierry Reding wrote:
 Something apparently went wrong when the patch in commit deb5ca8 was
 applied. Commit f75dd58 changed the type of gpt_head to be a pointer and
 correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got
 applied, the gpt_head was again reverted to (gpt_head), which was the
 state before deb5ca8.
 
 This commit fixes the passing of gpt_head into is_gpt_valid().
 
 Signed-off-by: Thierry Reding thierry.red...@avionic-design.de
 ---
  disk/part_efi.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/disk/part_efi.c b/disk/part_efi.c
 index e7f2714..ddf80a7 100644
 --- a/disk/part_efi.c
 +++ b/disk/part_efi.c
 @@ -130,7 +130,7 @@ void print_part_efi(block_dev_desc_t * dev_desc)
   }
   /* This function validates AND fills in the GPT header and PTE */
   if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
 -  (gpt_head), gpt_pte) != 1) {
 +  gpt_head, gpt_pte) != 1) {
   printf(%s: *** ERROR: Invalid GPT ***\n, __func__);
   return;
   }
 @@ -169,7 +169,7 @@ int get_partition_info_efi(block_dev_desc_t * dev_desc, 
 int part,
  
   /* This function validates AND fills in the GPT header and PTE */
   if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
 - (gpt_head), gpt_pte) != 1) {
 + gpt_head, gpt_pte) != 1) {
   printf(%s: *** ERROR: Invalid GPT ***\n, __func__);
   return -1;
   }
 -- 
 1.7.7.3

I had actually set Doug Anderson diand...@chromium.org on Cc because he
was involved with the initial patch but for some reason he got stripped from
Cc. Does anybody know why this is happening?

It seems like the To: header is unmodified so perhaps I should only be adding
people with --to when sending out patches with git send-email.

Thierry


pgpul5qmaLpEq.pgp
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot