Re: [U-Boot] [PATCH] edid: Fix gcc 7.1 warning

2017-06-02 Thread Anatolij Gustschin 
On Tue, 23 May 2017 23:05:30 +0200
Jernej Skrabec jernej.skra...@siol.net wrote:

> This commit fixes the warning produced by gcc 7.1.
> 
> Signed-off-by: Jernej Skrabec 
> ---
> 
>  common/edid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to u-boot-video/master, thanks!

--
Anatolij
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] edid: Fix gcc 7.1 warning

2017-05-31 Thread Simon Glass 
On 23 May 2017 at 15:05, Jernej Skrabec  wrote:
> This commit fixes the warning produced by gcc 7.1.
>
> Signed-off-by: Jernej Skrabec 
> ---
>
>  common/edid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] edid: Fix gcc 7.1 warning

2017-05-24 Thread Peter Robinson 
On Wed, May 24, 2017 at 5:35 AM, Jernej Škrabec  wrote:
> Hi,
>
> Dne sreda, 24. maj 2017 ob 03:00:16 CEST je Tom Rini napisal(a):
>> On Tue, May 23, 2017 at 11:05:30PM +0200, Jernej Skrabec wrote:
>> > This commit fixes the warning produced by gcc 7.1.
>> >
>> > Signed-off-by: Jernej Skrabec 
>>
>> Reviewed-by: Tom Rini 
>>
>> And I'm curious, where is your gcc-7.1 toolchain from, self built or
>> something else?  Thanks!
>
> It's from Arch Linux repository.
>
> I'm sorry to say that there seems to be something wrong with either gcc 7.1 or
> bootp code. With OrangePi 2 board, bootp crashes and resets the board
> (ethernet cable is not connected). I didn't have time to investigate it
> further.

I think we might have seen something similar with Fedora and gcc-7,
I'll ask some of the QA people and see if they can provide any more
details.

Peter
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] edid: Fix gcc 7.1 warning

2017-05-23 Thread Jernej Škrabec 
Hi,

Dne sreda, 24. maj 2017 ob 03:00:16 CEST je Tom Rini napisal(a):
> On Tue, May 23, 2017 at 11:05:30PM +0200, Jernej Skrabec wrote:
> > This commit fixes the warning produced by gcc 7.1.
> > 
> > Signed-off-by: Jernej Skrabec 
> 
> Reviewed-by: Tom Rini 
> 
> And I'm curious, where is your gcc-7.1 toolchain from, self built or
> something else?  Thanks!

It's from Arch Linux repository.

I'm sorry to say that there seems to be something wrong with either gcc 7.1 or 
bootp code. With OrangePi 2 board, bootp crashes and resets the board 
(ethernet cable is not connected). I didn't have time to investigate it 
further.

Best regards,
Jernej



___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] edid: Fix gcc 7.1 warning

2017-05-23 Thread Tom Rini 
On Tue, May 23, 2017 at 11:05:30PM +0200, Jernej Skrabec wrote:

> This commit fixes the warning produced by gcc 7.1.
> 
> Signed-off-by: Jernej Skrabec 

Reviewed-by: Tom Rini 

And I'm curious, where is your gcc-7.1 toolchain from, self built or
something else?  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] edid: Fix gcc 7.1 warning

2017-05-23 Thread Jernej Skrabec 
This commit fixes the warning produced by gcc 7.1.

Signed-off-by: Jernej Skrabec 
---

 common/edid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/edid.c b/common/edid.c
index 19410aa4fc..854d40c8f8 100644
--- a/common/edid.c
+++ b/common/edid.c
@@ -295,7 +295,7 @@ static void edid_print_dtd(struct edid_monitor_descriptor 
*monitor,
 
h_total = h_active + h_blanking;
v_total = v_active + v_blanking;
-   if (v_total * h_total)
+   if (v_total > 0 && h_total > 0)
vfreq = pixclock / (v_total * h_total);
else
vfreq = 1; /* Error case */
-- 
2.13.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot