Re: [U-Boot] [PATCH] ehci-pci: print hccr, hcor and hc_lenght

2010-09-12 Thread Remy Bohmer
Hi Florian,

2010/4/23 Florian Fainelli f.faine...@gmail.com:
 It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure it was
 successfully registered, and at the correct location.

 Signed-off-by: Florian Fainelli f.faine...@gmail.com
 ---
 diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
 index 047902a..4402abb 100644
 --- a/drivers/usb/host/ehci-pci.c
 +++ b/drivers/usb/host/ehci-pci.c
 @@ -53,6 +53,10 @@ int ehci_hcd_init(void)
        hcor = (struct ehci_hcor *)((uint32_t) hccr +
                        HC_LENGTH(ehci_readl(hccr-cr_capbase)));

 +       printf(EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n,
 +                       (uint32_t)hccr, (uint32_t)hcor,
 +                       (uint32_t)HC_LENGTH(ehci_readl(hccr-cr_capbase)));
 +

I guess I missed this patch...
Should the 'printf' not be a 'debug' statement?

Kind regards,

Remy
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] ehci-pci: print hccr, hcor and hc_lenght

2010-09-12 Thread Florian Fainelli
Hi Remy,

Le Sunday 12 September 2010 12:01:18, Remy Bohmer a écrit :
 Hi Florian,
 
 2010/4/23 Florian Fainelli f.faine...@gmail.com:
  It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure
  it was successfully registered, and at the correct location.
  
  Signed-off-by: Florian Fainelli f.faine...@gmail.com
  ---
  diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
  index 047902a..4402abb 100644
  --- a/drivers/usb/host/ehci-pci.c
  +++ b/drivers/usb/host/ehci-pci.c
  @@ -53,6 +53,10 @@ int ehci_hcd_init(void)
 hcor = (struct ehci_hcor *)((uint32_t) hccr +
 HC_LENGTH(ehci_readl(hccr-cr_capbase)));
  
  +   printf(EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n,
  +   (uint32_t)hccr, (uint32_t)hcor,
  +  
  (uint32_t)HC_LENGTH(ehci_readl(hccr-cr_capbase))); +
 
 I guess I missed this patch...

No problem.

 Should the 'printf' not be a 'debug' statement?

I think so, I will respin this patch. Thanks!
-- 
Florian
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] ehci-pci: print hccr, hcor and hc_lenght

2010-04-23 Thread Florian Fainelli
It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure it was
successfully registered, and at the correct location.

Signed-off-by: Florian Fainelli f.faine...@gmail.com
---
diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index 047902a..4402abb 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -53,6 +53,10 @@ int ehci_hcd_init(void)
hcor = (struct ehci_hcor *)((uint32_t) hccr +
HC_LENGTH(ehci_readl(hccr-cr_capbase)));
 
+   printf(EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n,
+   (uint32_t)hccr, (uint32_t)hcor,
+   (uint32_t)HC_LENGTH(ehci_readl(hccr-cr_capbase)));
+
return 0;
 }
 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot