Re: [U-Boot] [PATCH] fit: Add support for printing more than one FPGA node name

2019-05-19 Thread Tom Rini
On Wed, Feb 13, 2019 at 08:32:24PM +0800, tien.fong.c...@intel.com wrote:

> From: Tien Fong Chee 
> 
> This would print out all the FPGA node names setting to fpga property.
> 
> Signed-off-by: Tien Fong Chee 
> ---
>  common/image-fit.c |   14 +++---
>  1 files changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/common/image-fit.c b/common/image-fit.c
> index ac901e1..816e17d 100644
> --- a/common/image-fit.c
> +++ b/common/image-fit.c
> @@ -263,6 +263,7 @@ static void fit_conf_print(const void *fit, int noffset, 
> const char *p)
>   int ret;
>   int fdt_index, loadables_index;
>   int ndepth;
> + ulong count;
>  
>   /* Mandatory properties */
>   ret = fit_get_desc(fit, noffset, );
> @@ -299,9 +300,16 @@ static void fit_conf_print(const void *fit, int noffset, 
> const char *p)
>   printf("%s\n", uname);
>   }
>  
> - uname = fdt_getprop(fit, noffset, FIT_FPGA_PROP, NULL);
> - if (uname)
> - printf("%s  FPGA: %s\n", p, uname);
> + count = fit_conf_get_prop_node_count(fit, noffset, FIT_FPGA_PROP);
> +
> + for (ndepth = 0; ndepth < count; ndepth++) {
> + int images_noffset = fit_conf_get_prop_node_index(fit, noffset,
> + FIT_FPGA_PROP, ndepth);
> + uname = fit_get_name(fit, images_noffset, NULL);
> +
> + if (uname)
> + printf("%s  FPGA: %s\n", p, uname);
> + }
>  
>   /* Print out all of the specified loadables */
>   for (loadables_index = 0;

There's a problem here.  When I use buildman to make multiple boards
(say 'arm', but something smaller should trigger it too), all of my
builds get stuck on mkimage doing something.  A build of a single board
is fine.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH] fit: Add support for printing more than one FPGA node name

2019-02-13 Thread tien . fong . chee
From: Tien Fong Chee 

This would print out all the FPGA node names setting to fpga property.

Signed-off-by: Tien Fong Chee 
---
 common/image-fit.c |   14 +++---
 1 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/common/image-fit.c b/common/image-fit.c
index ac901e1..816e17d 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -263,6 +263,7 @@ static void fit_conf_print(const void *fit, int noffset, 
const char *p)
int ret;
int fdt_index, loadables_index;
int ndepth;
+   ulong count;
 
/* Mandatory properties */
ret = fit_get_desc(fit, noffset, );
@@ -299,9 +300,16 @@ static void fit_conf_print(const void *fit, int noffset, 
const char *p)
printf("%s\n", uname);
}
 
-   uname = fdt_getprop(fit, noffset, FIT_FPGA_PROP, NULL);
-   if (uname)
-   printf("%s  FPGA: %s\n", p, uname);
+   count = fit_conf_get_prop_node_count(fit, noffset, FIT_FPGA_PROP);
+
+   for (ndepth = 0; ndepth < count; ndepth++) {
+   int images_noffset = fit_conf_get_prop_node_index(fit, noffset,
+   FIT_FPGA_PROP, ndepth);
+   uname = fit_get_name(fit, images_noffset, NULL);
+
+   if (uname)
+   printf("%s  FPGA: %s\n", p, uname);
+   }
 
/* Print out all of the specified loadables */
for (loadables_index = 0;
-- 
1.7.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot