[U-Boot] [PATCH] kbuild: create a build directory automatically for out-of-tree build
Prior to Kbuild, the build system created a build directory, when it did not exist, for out-of-tree build. This feature was dropped when we switched to Kbuild because many of lines in makefiles were copied from Linux Kernel. (In Linux Kernel, we have to create a build directory by ourselves before starting build.) That feature seems worth reviving for less typing even if our code and Linux Kernel diverge. Signed-off-by: Masahiro Yamada Suggested-by: Simon Glass --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 538c3bf..0522ba8 100644 --- a/Makefile +++ b/Makefile @@ -124,7 +124,8 @@ ifneq ($(KBUILD_OUTPUT),) # Invoke a second make in the output directory, passing relevant variables # check that the output directory actually exists saved-output := $(KBUILD_OUTPUT) -KBUILD_OUTPUT := $(shell cd $(KBUILD_OUTPUT) && /bin/pwd) +KBUILD_OUTPUT := $(shell mkdir -p $(KBUILD_OUTPUT) && cd $(KBUILD_OUTPUT) \ + && /bin/pwd) $(if $(KBUILD_OUTPUT),, \ $(error output directory "$(saved-output)" does not exist)) -- 1.8.3.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] kbuild: create a build directory automatically for out-of-tree build
+Tom On 23 March 2014 22:55, Masahiro Yamada wrote: > Prior to Kbuild, the build system created a build directory, > when it did not exist, for out-of-tree build. > > This feature was dropped when we switched to Kbuild > because many of lines in makefiles were copied from Linux Kernel. > (In Linux Kernel, we have to create a build directory by ourselves > before starting build.) > > That feature seems worth reviving for less typing > even if our code and Linux Kernel diverge. > > Signed-off-by: Masahiro Yamada > Suggested-by: Simon Glass > Acked-by: Simon Glass Tested-by: Simon Glass Arguably could be a bug-fix for this release. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] kbuild: create a build directory automatically for out-of-tree build
On Mon, Mar 24, 2014 at 05:41:47PM -0600, Simon Glass wrote: > +Tom > > On 23 March 2014 22:55, Masahiro Yamada wrote: > > > Prior to Kbuild, the build system created a build directory, > > when it did not exist, for out-of-tree build. > > > > This feature was dropped when we switched to Kbuild > > because many of lines in makefiles were copied from Linux Kernel. > > (In Linux Kernel, we have to create a build directory by ourselves > > before starting build.) > > > > That feature seems worth reviving for less typing > > even if our code and Linux Kernel diverge. > > > > Signed-off-by: Masahiro Yamada > > Suggested-by: Simon Glass > > > > Acked-by: Simon Glass > Tested-by: Simon Glass > > Arguably could be a bug-fix for this release. Yeah, I like this and will pick it up. The only question is, has this idea already been rejected in the kernel? -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] kbuild: create a build directory automatically for out-of-tree build
Hi Tom, On Thu, 27 Mar 2014 13:20:33 -0400 Tom Rini wrote: > On Mon, Mar 24, 2014 at 05:41:47PM -0600, Simon Glass wrote: > > +Tom > > > > On 23 March 2014 22:55, Masahiro Yamada wrote: > > > > > Prior to Kbuild, the build system created a build directory, > > > when it did not exist, for out-of-tree build. > > > > > > This feature was dropped when we switched to Kbuild > > > because many of lines in makefiles were copied from Linux Kernel. > > > (In Linux Kernel, we have to create a build directory by ourselves > > > before starting build.) > > > > > > That feature seems worth reviving for less typing > > > even if our code and Linux Kernel diverge. > > > > > > Signed-off-by: Masahiro Yamada > > > Suggested-by: Simon Glass > > > > > > > Acked-by: Simon Glass > > Tested-by: Simon Glass > > > > Arguably could be a bug-fix for this release. > > Yeah, I like this and will pick it up. The only question is, has this > idea already been rejected in the kernel? > I have not sent this patch to the kernel community yet. OK. I will. Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] kbuild: create a build directory automatically for out-of-tree build
Hi, On 27 March 2014 20:37, Masahiro Yamada wrote: > Hi Tom, > > > On Thu, 27 Mar 2014 13:20:33 -0400 > Tom Rini wrote: > > > On Mon, Mar 24, 2014 at 05:41:47PM -0600, Simon Glass wrote: > > > +Tom > > > > > > On 23 March 2014 22:55, Masahiro Yamada > wrote: > > > > > > > Prior to Kbuild, the build system created a build directory, > > > > when it did not exist, for out-of-tree build. > > > > > > > > This feature was dropped when we switched to Kbuild > > > > because many of lines in makefiles were copied from Linux Kernel. > > > > (In Linux Kernel, we have to create a build directory by ourselves > > > > before starting build.) > > > > > > > > That feature seems worth reviving for less typing > > > > even if our code and Linux Kernel diverge. > > > > > > > > Signed-off-by: Masahiro Yamada > > > > Suggested-by: Simon Glass > > > > > > > > > > Acked-by: Simon Glass > > > Tested-by: Simon Glass > > > > > > Arguably could be a bug-fix for this release. > > > > Yeah, I like this and will pick it up. The only question is, has this > > idea already been rejected in the kernel? > > > > I have not sent this patch to the kernel community yet. > OK. I will. > My point is that this is a change from the old U-Boot behaviour, so it would be nice to fix it. Regards, Simon > > > Best Regards > Masahiro Yamada > > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] kbuild: create a build directory automatically for out-of-tree build
Hi Tom, On Fri, 28 Mar 2014 11:37:28 +0900 Masahiro Yamada wrote: > Hi Tom, > > > On Thu, 27 Mar 2014 13:20:33 -0400 > Tom Rini wrote: > > > On Mon, Mar 24, 2014 at 05:41:47PM -0600, Simon Glass wrote: > > > +Tom > > > > > > On 23 March 2014 22:55, Masahiro Yamada wrote: > > > > > > > Prior to Kbuild, the build system created a build directory, > > > > when it did not exist, for out-of-tree build. > > > > > > > > This feature was dropped when we switched to Kbuild > > > > because many of lines in makefiles were copied from Linux Kernel. > > > > (In Linux Kernel, we have to create a build directory by ourselves > > > > before starting build.) > > > > > > > > That feature seems worth reviving for less typing > > > > even if our code and Linux Kernel diverge. > > > > > > > > Signed-off-by: Masahiro Yamada > > > > Suggested-by: Simon Glass > > > > > > > > > > Acked-by: Simon Glass > > > Tested-by: Simon Glass > > > > > > Arguably could be a bug-fix for this release. > > > > Yeah, I like this and will pick it up. The only question is, has this > > idea already been rejected in the kernel? > > > > I have not sent this patch to the kernel community yet. > OK. I will. > The good news is this feature was merged in Linux Kernel mainline (commit 1c9e70a55). Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
