Re: [U-Boot] [PATCH] kconfig: Avoid format overflow warning from GCC 8.1

[Masahiro Yamada]

2018-07-06 5:55 GMT+09:00 Luis Araneda :
> cherry-pick kernel commit 2ae89c7 (2018-06-05)
> to avoid warnings when compiling with GCC 8.1
>
> In file included from scripts/kconfig/zconf.tab.c:2486:
> scripts/kconfig/confdata.c: In function ‘conf_write’:
> scripts/kconfig/confdata.c:771:22: warning: ‘%s’ directive writing likely 7 
> or more bytes into a region of size between 1 and 4097 [-Wformat-overflow=]
>   sprintf(newname, "%s%s", dirname, basename);
>   ^~
> scripts/kconfig/confdata.c:771:19: note: assuming directive output of 7 bytes
>   sprintf(newname, "%s%s", dirname, basename);
>^~
> scripts/kconfig/confdata.c:771:2: note: ‘sprintf’ output 1 or more bytes 
> (assuming 4104) into a destination of size 4097
>   sprintf(newname, "%s%s", dirname, basename);
>   ^~~
> scripts/kconfig/confdata.c:774:23: warning: ‘.tmpconfig.’ directive writing 
> 11 bytes into a region of size between 1 and 4097 [-Wformat-overflow=]
>sprintf(tmpname, "%s.tmpconfig.%d", dirname, (int)getpid());
>^~~
> scripts/kconfig/confdata.c:774:3: note: ‘sprintf’ output between 13 and 4119 
> bytes into a destination of size 4097
>sprintf(tmpname, "%s.tmpconfig.%d", dirname, (int)getpid());
>^~~
>
> Signed-off-by: Luis Araneda 
> ---

Applied to u-boot-uniphier.

>  scripts/kconfig/confdata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index e4cbb87d76..a04bb26304 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -743,7 +743,7 @@ int conf_write(const char *name)
> struct menu *menu;
> const char *basename;
> const char *str;
> -   char dirname[PATH_MAX+1], tmpname[PATH_MAX+1], newname[PATH_MAX+1];
> +   char dirname[PATH_MAX+1], tmpname[PATH_MAX+22], newname[PATH_MAX+8];
> char *env;
>
> dirname[0] = 0;
> --
> 2.18.0
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot



-- 
Best Regards
Masahiro Yamada
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] kconfig: Avoid format overflow warning from GCC 8.1

[Luis Araneda]

cherry-pick kernel commit 2ae89c7 (2018-06-05)
to avoid warnings when compiling with GCC 8.1

In file included from scripts/kconfig/zconf.tab.c:2486:
scripts/kconfig/confdata.c: In function ‘conf_write’:
scripts/kconfig/confdata.c:771:22: warning: ‘%s’ directive writing likely 7 or 
more bytes into a region of size between 1 and 4097 [-Wformat-overflow=]
  sprintf(newname, "%s%s", dirname, basename);
  ^~
scripts/kconfig/confdata.c:771:19: note: assuming directive output of 7 bytes
  sprintf(newname, "%s%s", dirname, basename);
   ^~
scripts/kconfig/confdata.c:771:2: note: ‘sprintf’ output 1 or more bytes 
(assuming 4104) into a destination of size 4097
  sprintf(newname, "%s%s", dirname, basename);
  ^~~
scripts/kconfig/confdata.c:774:23: warning: ‘.tmpconfig.’ directive writing 11 
bytes into a region of size between 1 and 4097 [-Wformat-overflow=]
   sprintf(tmpname, "%s.tmpconfig.%d", dirname, (int)getpid());
   ^~~
scripts/kconfig/confdata.c:774:3: note: ‘sprintf’ output between 13 and 4119 
bytes into a destination of size 4097
   sprintf(tmpname, "%s.tmpconfig.%d", dirname, (int)getpid());
   ^~~

Signed-off-by: Luis Araneda 
---
 scripts/kconfig/confdata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index e4cbb87d76..a04bb26304 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -743,7 +743,7 @@ int conf_write(const char *name)
struct menu *menu;
const char *basename;
const char *str;
-   char dirname[PATH_MAX+1], tmpname[PATH_MAX+1], newname[PATH_MAX+1];
+   char dirname[PATH_MAX+1], tmpname[PATH_MAX+22], newname[PATH_MAX+8];
char *env;
 
dirname[0] = 0;
-- 
2.18.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot