Re: [U-Boot] [PATCH] moveconfig: Fix error message for a missing toolchain
2017-10-10 12:00 GMT+09:00 Masahiro Yamada : > 2017-10-08 19:31 GMT+09:00 Tuomas Tynkkynen : >> Due to misplaced quote the error message is literally e.g.: >> >> MigoR_defconfig >> Tool chain for '%s' is missing. Do nothing. >> % arch >> >> Fix it to correctly show the architecture: >> >> MigoR_defconfig >> Tool chain for 'sh' is missing. Do nothing. >> >> Signed-off-by: Tuomas Tynkkynen >> --- >> tools/moveconfig.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/moveconfig.py b/tools/moveconfig.py >> index e3116461ba..bdd4899fcd 100755 >> --- a/tools/moveconfig.py >> +++ b/tools/moveconfig.py >> @@ -1170,7 +1170,7 @@ class Slot: >> toolchain = self.toolchains.Select(arch) >> except ValueError: >> self.log += color_text(self.options.color, COLOR_YELLOW, >> -"Tool chain for '%s' is missing. Do nothing.\n % arch") >> +"Tool chain for '%s' is missing. Do nothing.\n" % arch) >> self.finish(False) >> return >> env = toolchain.MakeEnvironment(False) > > > Acked-by: Masahiro Yamada > This is correct, but Chris had sent an equivalent one http://patchwork.ozlabs.org/patch/806202/ It has not been applied yet, somehow. I honored the first one. -- Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] moveconfig: Fix error message for a missing toolchain
2017-10-08 19:31 GMT+09:00 Tuomas Tynkkynen : > Due to misplaced quote the error message is literally e.g.: > > MigoR_defconfig > Tool chain for '%s' is missing. Do nothing. > % arch > > Fix it to correctly show the architecture: > > MigoR_defconfig > Tool chain for 'sh' is missing. Do nothing. > > Signed-off-by: Tuomas Tynkkynen > --- > tools/moveconfig.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/moveconfig.py b/tools/moveconfig.py > index e3116461ba..bdd4899fcd 100755 > --- a/tools/moveconfig.py > +++ b/tools/moveconfig.py > @@ -1170,7 +1170,7 @@ class Slot: > toolchain = self.toolchains.Select(arch) > except ValueError: > self.log += color_text(self.options.color, COLOR_YELLOW, > -"Tool chain for '%s' is missing. Do nothing.\n % arch") > +"Tool chain for '%s' is missing. Do nothing.\n" % arch) > self.finish(False) > return > env = toolchain.MakeEnvironment(False) Acked-by: Masahiro Yamada -- Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] moveconfig: Fix error message for a missing toolchain
Due to misplaced quote the error message is literally e.g.: MigoR_defconfig Tool chain for '%s' is missing. Do nothing. % arch Fix it to correctly show the architecture: MigoR_defconfig Tool chain for 'sh' is missing. Do nothing. Signed-off-by: Tuomas Tynkkynen --- tools/moveconfig.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/moveconfig.py b/tools/moveconfig.py index e3116461ba..bdd4899fcd 100755 --- a/tools/moveconfig.py +++ b/tools/moveconfig.py @@ -1170,7 +1170,7 @@ class Slot: toolchain = self.toolchains.Select(arch) except ValueError: self.log += color_text(self.options.color, COLOR_YELLOW, -"Tool chain for '%s' is missing. Do nothing.\n % arch") +"Tool chain for '%s' is missing. Do nothing.\n" % arch) self.finish(False) return env = toolchain.MakeEnvironment(False) -- 2.14.2 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
