Re: [U-Boot] [PATCH] mx27: 16-bit wide watchdog registers

2016-03-25 Thread Stefano Babic 
On 20/03/2016 14:10, Leonid Iziumtsev wrote:
> From: Leonid Iziumtsev 
> 
> Make the watchdog registers 16-bit wide, as they are according to TRM.
> 
> Signed-off-by: Leonid Iziumtsev 
> ---
>  arch/arm/cpu/arm926ejs/mx27/reset.c   | 8 
>  arch/arm/include/asm/arch-mx27/imx-regs.h | 6 +++---
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mx27/reset.c 
> b/arch/arm/cpu/arm926ejs/mx27/reset.c
> index f7b4a1c..e764986 100644
> --- a/arch/arm/cpu/arm926ejs/mx27/reset.c
> +++ b/arch/arm/cpu/arm926ejs/mx27/reset.c
> @@ -27,14 +27,14 @@ void reset_cpu(ulong ignored)
>  {
>   struct wdog_regs *regs = (struct wdog_regs *)IMX_WDT_BASE;
>   /* Disable watchdog and set Time-Out field to 0 */
> - writel(0x, >wcr);
> + writew(0x, >wcr);
>  
>   /* Write Service Sequence */
> - writel(0x, >wsr);
> - writel(0x, >wsr);
> + writew(0x, >wsr);
> + writew(0x, >wsr);
>  
>   /* Enable watchdog */
> - writel(WCR_WDE, >wcr);
> + writew(WCR_WDE, >wcr);
>  
>   while (1);
>   /*NOTREACHED*/
> diff --git a/arch/arm/include/asm/arch-mx27/imx-regs.h 
> b/arch/arm/include/asm/arch-mx27/imx-regs.h
> index baf1d29..40b76d2 100644
> --- a/arch/arm/include/asm/arch-mx27/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx27/imx-regs.h
> @@ -106,9 +106,9 @@ struct esdramc_regs {
>  
>  /* Watchdog Registers*/
>  struct wdog_regs {
> - u32 wcr;
> - u32 wsr;
> - u32 wstr;
> + u16 wcr;
> + u16 wsr;
> + u16 wstr;
>  };
>  
>  /* PLL registers */
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mx27: 16-bit wide watchdog registers

2016-03-20 Thread Fabio Estevam 
On Sun, Mar 20, 2016 at 10:10 AM, Leonid Iziumtsev
 wrote:
> From: Leonid Iziumtsev 
>
> Make the watchdog registers 16-bit wide, as they are according to TRM.
>
> Signed-off-by: Leonid Iziumtsev 

Reviewed-by: Fabio Estevam 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] mx27: 16-bit wide watchdog registers

2016-03-20 Thread Leonid Iziumtsev 
From: Leonid Iziumtsev 

Make the watchdog registers 16-bit wide, as they are according to TRM.

Signed-off-by: Leonid Iziumtsev 
---
 arch/arm/cpu/arm926ejs/mx27/reset.c   | 8 
 arch/arm/include/asm/arch-mx27/imx-regs.h | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/cpu/arm926ejs/mx27/reset.c 
b/arch/arm/cpu/arm926ejs/mx27/reset.c
index f7b4a1c..e764986 100644
--- a/arch/arm/cpu/arm926ejs/mx27/reset.c
+++ b/arch/arm/cpu/arm926ejs/mx27/reset.c
@@ -27,14 +27,14 @@ void reset_cpu(ulong ignored)
 {
struct wdog_regs *regs = (struct wdog_regs *)IMX_WDT_BASE;
/* Disable watchdog and set Time-Out field to 0 */
-   writel(0x, >wcr);
+   writew(0x, >wcr);
 
/* Write Service Sequence */
-   writel(0x, >wsr);
-   writel(0x, >wsr);
+   writew(0x, >wsr);
+   writew(0x, >wsr);
 
/* Enable watchdog */
-   writel(WCR_WDE, >wcr);
+   writew(WCR_WDE, >wcr);
 
while (1);
/*NOTREACHED*/
diff --git a/arch/arm/include/asm/arch-mx27/imx-regs.h 
b/arch/arm/include/asm/arch-mx27/imx-regs.h
index baf1d29..40b76d2 100644
--- a/arch/arm/include/asm/arch-mx27/imx-regs.h
+++ b/arch/arm/include/asm/arch-mx27/imx-regs.h
@@ -106,9 +106,9 @@ struct esdramc_regs {
 
 /* Watchdog Registers*/
 struct wdog_regs {
-   u32 wcr;
-   u32 wsr;
-   u32 wstr;
+   u16 wcr;
+   u16 wsr;
+   u16 wstr;
 };
 
 /* PLL registers */
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot