Re: [U-Boot] [PATCH] mx6sabresd: Remove unneeded enable_lvds() function

[Stefano Babic]

On 25/03/2016 15:37, Fabio Estevam wrote:
> From: Fabio Estevam 
> 
> enable_lvds() function only set bits IOMUXC_GPR2_DATA_WIDTH_CH0_18BIT and
> IOMUXC_GPR2_DATA_WIDTH_CH1_18BIT, but these bits were already set
> previously inside setup_display().
> 
> We can safely remove enable_lvds() then.
> 
> Signed-off-by: Fabio Estevam 
> ---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] mx6sabresd: Remove unneeded enable_lvds() function

[Fabio Estevam]

From: Fabio Estevam 

enable_lvds() function only set bits IOMUXC_GPR2_DATA_WIDTH_CH0_18BIT and
IOMUXC_GPR2_DATA_WIDTH_CH1_18BIT, but these bits were already set
previously inside setup_display().

We can safely remove enable_lvds() then.

Signed-off-by: Fabio Estevam 
---
 board/freescale/mx6sabresd/mx6sabresd.c | 12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/board/freescale/mx6sabresd/mx6sabresd.c 
b/board/freescale/mx6sabresd/mx6sabresd.c
index 727334a..2319354 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -365,22 +365,12 @@ static void do_enable_hdmi(struct display_info_t const 
*dev)
imx_enable_hdmi_phy();
 }
 
-static void enable_lvds(struct display_info_t const *dev)
-{
-   struct iomuxc *iomux = (struct iomuxc *)
-   IOMUXC_BASE_ADDR;
-   u32 reg = readl(>gpr[2]);
-   reg |= IOMUXC_GPR2_DATA_WIDTH_CH0_18BIT |
-  IOMUXC_GPR2_DATA_WIDTH_CH1_18BIT;
-   writel(reg, >gpr[2]);
-}
-
 struct display_info_t const displays[] = {{
.bus= -1,
.addr   = 0,
.pixfmt = IPU_PIX_FMT_RGB666,
.detect = NULL,
-   .enable = enable_lvds,
+   .enable = NULL,
.mode   = {
.name   = "Hannstar-XGA",
.refresh= 60,
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot