Re: [U-Boot] [PATCH] net: Add \n before warning message so it prints on a new line.
Hi Philip, Le 07/09/2011 13:57, Philip Balister a écrit : Signed-off-by: Philip Balisterphi...@opensdr.com --- net/eth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/eth.c b/net/eth.c index dbd1e2d..67a8039 100644 --- a/net/eth.c +++ b/net/eth.c @@ -305,7 +305,7 @@ int eth_initialize(bd_t *bis) puts(\nWarning: eth device name has a space!\n); if (eth_write_hwaddr(dev, eth, eth_number)) - puts(Warning: failed to set MAC address\n); + puts(\nWarning: failed to set MAC address\n); I believe warning messages with \n on more than one end are frowned upon. eth_number++; dev = dev-next; Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Add \n before warning message so it prints on a new line.
On 09/08/2011 11:01 AM, Albert ARIBAUD wrote: Hi Philip, Le 07/09/2011 13:57, Philip Balister a écrit : Signed-off-by: Philip Balisterphi...@opensdr.com --- net/eth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/eth.c b/net/eth.c index dbd1e2d..67a8039 100644 --- a/net/eth.c +++ b/net/eth.c @@ -305,7 +305,7 @@ int eth_initialize(bd_t *bis) puts(\nWarning: eth device name has a space!\n); if (eth_write_hwaddr(dev, eth, eth_number)) - puts(Warning: failed to set MAC address\n); + puts(\nWarning: failed to set MAC address\n); I believe warning messages with \n on more than one end are frowned upon. Look closely at the patch, the warning message above has to do the same thing. Without the leading \n on the message, it prints directly after the ethernet chip name, with no space. This is not right. I chose to copy the existing code, rather than add a leading space. Philip eth_number++; dev = dev-next; Amicalement, ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Add \n before warning message so it prints on a new line.
Le 08/09/2011 17:04, Philip Balister a écrit : On 09/08/2011 11:01 AM, Albert ARIBAUD wrote: Hi Philip, Le 07/09/2011 13:57, Philip Balister a écrit : Signed-off-by: Philip Balisterphi...@opensdr.com --- net/eth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/eth.c b/net/eth.c index dbd1e2d..67a8039 100644 --- a/net/eth.c +++ b/net/eth.c @@ -305,7 +305,7 @@ int eth_initialize(bd_t *bis) puts(\nWarning: eth device name has a space!\n); if (eth_write_hwaddr(dev, eth, eth_number)) - puts(Warning: failed to set MAC address\n); + puts(\nWarning: failed to set MAC address\n); I believe warning messages with \n on more than one end are frowned upon. Look closely at the patch, the warning message above has to do the same thing. Without the leading \n on the message, it prints directly after the ethernet chip name, with no space. This is not right. I chose to copy the existing code, rather than add a leading space. Just because original code has an error does not make it right to reproduce it. :) More seriously, heterogeneous \n placement makes it complicated to get and keep printing right -- for instance here the warning messages have a trailing \n but the code loop adds one at the end. I would prefer that the code do a first loop (while dev!= eth_devices) to try and set up ethernet devices, emitting simple warning\n messages as needed, then a second loop (for dev=0 to eth_number-1) to print a summary of the final list of eth devices found and initialized. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] net: Add \n before warning message so it prints on a new line.
Signed-off-by: Philip Balister phi...@opensdr.com --- net/eth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/eth.c b/net/eth.c index dbd1e2d..67a8039 100644 --- a/net/eth.c +++ b/net/eth.c @@ -305,7 +305,7 @@ int eth_initialize(bd_t *bis) puts(\nWarning: eth device name has a space!\n); if (eth_write_hwaddr(dev, eth, eth_number)) - puts(Warning: failed to set MAC address\n); + puts(\nWarning: failed to set MAC address\n); eth_number++; dev = dev-next; -- 1.7.4.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
