Re: [U-Boot] [PATCH] net: Change the NFS_TIMEOUT to 20s for using nfs load image.
Dear Wolfgang >> >> The work flow is that: >> Every "timeout" is reached, it will call NfsSend() and whatever the >> state is finally it will call rpc_req() which will increase the >> rpc_id value every time. The rpc_id value is increased but the >> reply.id is not increased by "timeout". This makes the judgement statement: >> If (ntohl(rpc_pkt.u.reply.id) != rpc_id) is true and it will return >> -1. Then we got the error message: *** ERROR: Cannot mount. >> >> So far, I am raising the timeout limit to avoid rpc_id being increased >> unexpectedly. >What sort of NFS server is this? It is a Debian NFS server. Best regards, Jin Qing ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Change the NFS_TIMEOUT to 20s for using nfs load image.
Dear Jin Qing-B24347, In message you wrote: > > The work flow is that: > Every "timeout" is reached, it will call NfsSend() and whatever the > state is finally it will call rpc_req() which will increase the rpc_id > value every time. The rpc_id value is increased but the reply.id is not > increased by "timeout". This makes the judgement statement: > If (ntohl(rpc_pkt.u.reply.id) != rpc_id) is true and it will return > -1. Then we got the error message: *** ERROR: Cannot mount. > > So far, I am raising the timeout limit to avoid rpc_id being increased > unexpectedly. What sort of NFS server is this? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Have you lived in this village all your life?""No, not yet." ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Change the NFS_TIMEOUT to 20s for using nfs load image.
Dear Wolfgang, The work flow is that: Every "timeout" is reached, it will call NfsSend() and whatever the state is finally it will call rpc_req() which will increase the rpc_id value every time. The rpc_id value is increased but the reply.id is not increased by "timeout". This makes the judgement statement: If (ntohl(rpc_pkt.u.reply.id) != rpc_id) is true and it will return -1. Then we got the error message: *** ERROR: Cannot mount. So far, I am raising the timeout limit to avoid rpc_id being increased unexpectedly. Do you have any suggestion about this issue? Best Regards, Jin Qing -Original Message- From: Wolfgang Denk [mailto:w...@denx.de] Sent: 2010年8月16日 18:46 To: Li Yang-R58472 Cc: u-boot@lists.denx.de; Jin Qing-B24347 Subject: Re: [U-Boot] [PATCH] net: Change the NFS_TIMEOUT to 20s for using nfs load image. Dear Li Yang, In message you wrote: > > >> #define NFS_RETRY_COUNT 30 > >> -#define NFS_TIMEOUT 2000UL > >> +#define NFS_TIMEOUT 2UL > > > > You mean 30 retries (NFS_RETRY_COUNT) every two seconds were not > > sufficient in your case? > > > > That's a full minute... > > It didn't retry 30 times before it fails completely in our test: > > Load address: 0x40 > Loading: T T T T T *** ERROR: Cannot mount T T *** ERROR: Cannot > umount > > Looks like the state machine is not working as expected? ...or something else is causing errors. I have never seen such behaviour yet. Please try and debug it. Simply raising the timeout limit seems the wrong approach to me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When the bosses talk about improving productivity, they are never talking about themselves. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Change the NFS_TIMEOUT to 20s for using nfs load image.
Dear Li Yang, In message you wrote: > > >> #define NFS_RETRY_COUNT 30 > >> -#define NFS_TIMEOUT 2000UL > >> +#define NFS_TIMEOUT 2UL > > > > You mean 30 retries (NFS_RETRY_COUNT) every two seconds were not > > sufficient in your case? > > > > That's a full minute... > > It didn't retry 30 times before it fails completely in our test: > > Load address: 0x40 > Loading: T T T T T *** ERROR: Cannot mount > T T *** ERROR: Cannot umount > > Looks like the state machine is not working as expected? ...or something else is causing errors. I have never seen such behaviour yet. Please try and debug it. Simply raising the timeout limit seems the wrong approach to me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When the bosses talk about improving productivity, they are never talking about themselves. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Change the NFS_TIMEOUT to 20s for using nfs load image.
On Mon, Aug 16, 2010 at 6:09 PM, Wolfgang Denk wrote: > Dear Li Yang, > > In message <1281947653-5530-1-git-send-email-le...@freescale.com> you wrote: >> From: Jin Qing >> >> The NFS_TIMEOUT is 2s before. It is too short for some nfs server to >> respond. >> >> Signed-off-by: Jin Qing >> --- >> We are not sure what is the expected timeout period. Using 20s to make sure >> the mount works. >> >> net/nfs.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/net/nfs.c b/net/nfs.c >> index 4017c3e..cabadfe 100644 >> --- a/net/nfs.c >> +++ b/net/nfs.c >> @@ -33,7 +33,7 @@ >> >> #define HASHES_PER_LINE 65 /* Number of "loading" hashes per line */ >> #define NFS_RETRY_COUNT 30 >> -#define NFS_TIMEOUT 2000UL >> +#define NFS_TIMEOUT 2UL > > You mean 30 retries (NFS_RETRY_COUNT) every two seconds were not > sufficient in your case? > > That's a full minute... It didn't retry 30 times before it fails completely in our test: Load address: 0x40 Loading: T T T T T *** ERROR: Cannot mount T T *** ERROR: Cannot umount Looks like the state machine is not working as expected? - Leo ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Change the NFS_TIMEOUT to 20s for using nfs load image.
Dear Li Yang, In message <1281947653-5530-1-git-send-email-le...@freescale.com> you wrote: > From: Jin Qing > > The NFS_TIMEOUT is 2s before. It is too short for some nfs server to respond. > > Signed-off-by: Jin Qing > --- > We are not sure what is the expected timeout period. Using 20s to make sure > the mount works. > > net/nfs.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/nfs.c b/net/nfs.c > index 4017c3e..cabadfe 100644 > --- a/net/nfs.c > +++ b/net/nfs.c > @@ -33,7 +33,7 @@ > > #define HASHES_PER_LINE 65 /* Number of "loading" hashes per line */ > #define NFS_RETRY_COUNT 30 > -#define NFS_TIMEOUT 2000UL > +#define NFS_TIMEOUT 2UL You mean 30 retries (NFS_RETRY_COUNT) every two seconds were not sufficient in your case? That's a full minute... Waiting 10 minutes for a command to complete seems way too long to me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Always leave room to add an explanation if it doesn't work out. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] net: Change the NFS_TIMEOUT to 20s for using nfs load image.
From: Jin Qing The NFS_TIMEOUT is 2s before. It is too short for some nfs server to respond. Signed-off-by: Jin Qing --- We are not sure what is the expected timeout period. Using 20s to make sure the mount works. net/nfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/nfs.c b/net/nfs.c index 4017c3e..cabadfe 100644 --- a/net/nfs.c +++ b/net/nfs.c @@ -33,7 +33,7 @@ #define HASHES_PER_LINE 65 /* Number of "loading" hashes per line */ #define NFS_RETRY_COUNT 30 -#define NFS_TIMEOUT 2000UL +#define NFS_TIMEOUT 2UL static int fs_mounted = 0; static unsigned long rpc_id = 0; -- 1.6.6-rc1.GIT ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
