[U-Boot] [PATCH] net: bugfix: NetSetTimeout assumes CONFIG_SYS_HZ=1000
NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000. Signed-off-by: Tetsuyuki Kobayashi --- net/net.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/net.c b/net/net.c index 9de7d92..ac9c2c8 100644 --- a/net/net.c +++ b/net/net.c @@ -653,7 +653,7 @@ NetSetTimeout(ulong iv, thand_f *f) "--- NetLoop timeout handler set (%p)\n", f); timeHandler = f; timeStart = get_timer(0); - timeDelta = iv; + timeDelta = iv * CONFIG_SYS_HZ / 1000; } } -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: bugfix: NetSetTimeout assumes CONFIG_SYS_HZ=1000
Dear Tetsuyuki Kobayashi, In message <4fe85b87.6090...@kmckk.co.jp> you wrote: > NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000. Your patch is OK per se, but please note that it is a mandatory requirement that CONFIG_SYS_HZ == 1000. So if you have any board where this is not the case, this board needs to be fixed, too. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The management question ... is not _whether_ to build a pilot system and throw it away. You _will_ do that. The only question is whether to plan in advance to build a throwaway, or to promise to deliver the throwaway to customers. - Fred Brooks, "The Mythical Man Month" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: bugfix: NetSetTimeout assumes CONFIG_SYS_HZ=1000
Dear Wolfgang Denk, (07/09/2012 04:58 AM), Wolfgang Denk wrote: > Dear Tetsuyuki Kobayashi, > > In message <4fe85b87.6090...@kmckk.co.jp> you wrote: >> NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000. > > Your patch is OK per se, but please note that it is a mandatory > requirement that CONFIG_SYS_HZ == 1000. So if you have any board > where this is not the case, this board needs to be fixed, too. Thank you for reviewing my patch. I didn't know that it is a mandatory requirement that CONFIG_SYS_HZ == 1000. I grep'ed for CONFIG_SYS_HZ in README and under doc/, but I could not find any description about it. $ grep -r CONFIG_SYS_HZ README doc/* doc/README.LED:(CONFIG_SYS_HZ / ) where is the frequency of the blink. Typical values And I couldn't find that what value should be return in ulong get_timer(ulong base); I hope "how to implement system timer" documented. Best regards, Tetsuyuki Kobayashi ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: bugfix: NetSetTimeout assumes CONFIG_SYS_HZ=1000
Hi Wolfgang, On Sun, Jul 8, 2012 at 2:58 PM, Wolfgang Denk wrote: > Dear Tetsuyuki Kobayashi, > > In message <4fe85b87.6090...@kmckk.co.jp> you wrote: >> NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000. > > Your patch is OK per se, but please note that it is a mandatory > requirement that CONFIG_SYS_HZ == 1000. So if you have any board > where this is not the case, this board needs to be fixed, too. If that is a hard requirement, then I don't see a point to applying this patch. I also don't know why the CONFIG_SYS_HZ variable exists. Thanks, -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: bugfix: NetSetTimeout assumes CONFIG_SYS_HZ=1000
Hi Tetsuyuki, On Mon, Jun 25, 2012 at 7:37 AM, Tetsuyuki Kobayashi wrote: > NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000. > > Signed-off-by: Tetsuyuki Kobayashi > --- I decided this doesn't hurt and it sort-of documents what "must be" (tm). Applied, thanks. -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
